00:50:22 <johnstein> ??rebuild
00:50:22 <Sequell> rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.jorgrun.rocks/rebuild/ Bug |amethyst or Nap.Kin for CDO. Use your powers wisely.
01:03:36 <Rotatell> Experimental (hellcrawl-cbro) branch on crawl.beRotato.org updated to: v1.0-428-g4089b7e
01:05:01 <johnstein> !tell hellmonk should the version in-game be: This is Dungeon Crawl Stone Soup v3.33-hellcrawl-137-g4089b7e ?
01:05:02 <Sequell> johnstein: OK, I'll let hellmonk know.
01:05:51 <johnstein> maybe I need to git fetch hellcrawl or something. I always get confused with tags with multiple remotes
01:06:58 <hellmonk> looks correct
01:07:04 <johnstein> cool
01:07:34 <johnstein> all I did was rename the old hellcrawl install dir so technically the old saves didn't get nuked. just buried
01:07:48 <johnstein> let me know if anything looks wonky
01:08:07 <hellmonk> ok, will do
02:36:16 -!- Dracunos_ is now known as Dracunos
03:11:49 <Cheibriados> Unknown objects still selectable in discoveries menu when all objects of a given type found 13https://crawl.develz.org/mantis/view.php?id=11202 by damerell
04:45:33 <Cheibriados> New branch created: pull/604 (1 commit) 13https://github.com/crawl/crawl/pull/604
04:45:33 <Cheibriados> 03johnstein02 07https://github.com/crawl/crawl/pull/604 * 0.21-a0-222-g43b64fd: Clarify failure msg for !invis while haloed 10(2 hours ago, 1 file, 11+ 1-) 13https://github.com/crawl/crawl/commit/43b64fd954e0
05:38:03 -!- buki_ is now known as buki
09:22:05 <alexjurkiewicz> !tell hellmonk old saves nuked
09:22:06 <Sequell> alexjurkiewicz: OK, I'll let hellmonk know.
09:57:41 <gammafunk> hrmm
09:57:47 <gammafunk> more adventures in mon-place.cc
09:58:01 <gammafunk> !define VAULT_MON_TYPES_KEY
09:58:09 <gammafunk> !source VAULT_MON_TYPES_KEY
09:58:11 <Sequell> Can't find VAULT_MON_TYPES_KEY.
09:58:12 <gammafunk> that used to work
09:58:30 <gammafunk> !cmd define
09:58:30 <Sequell> No command !define
09:58:30 <gammafunk> !cmd defines
09:58:30 <Sequell> No command !defines
09:58:30 <gammafunk> !cmd function
09:58:30 <Sequell> Built-in: !function => https://github.com/crawl/sequell/blob/master/commands/source.pl
09:59:05 <gammafunk> !source mon-place.h:127
09:59:06 <Sequell> https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-place.h#L127
09:59:41 <gammafunk> these key's are marked for removal with major version bumbp
09:59:43 <gammafunk> *bump
09:59:50 <gammafunk> from what I can tell, that shouldn't be the case
10:02:46 <gammafunk> %git 76029e05d88bf5
10:02:46 <Cheibriados> 07wheals02 * 0.16-a0-1017-g76029e0: Make vault-defined monster lists use level_ids, not packed places. 10(2 years, 11 months ago, 4 files, 67+ 21-) 13https://github.com/crawl/crawl/commit/76029e05d88b
10:04:44 <gammafunk> oh I see
10:04:45 <gammafunk> it was moved
10:05:22 <wheals_> mm?
10:05:37 <wheals_> yeah, they only need to be in a public header till save compat gets bumped
10:05:38 <gammafunk> wheals_: you moved the relevant keys in these monster place vectors
10:06:00 <gammafunk> alright, I guess that's fine then
10:06:11 <gammafunk> I think I can remove the entire place thing
10:06:32 <gammafunk> well, if I can confirm it's only relevant to monsters coming from stairs I can
10:07:05 <gammafunk> or, maybe this is from the mon spec
10:07:15 <gammafunk> ah yeah, you can specify monsters as coming from another place, right
10:07:20 <gammafunk> like for zombies
10:07:30 <wheals_> yeah
10:07:34 <gammafunk> well damn, that place pointer will need to stay then
10:07:37 <gammafunk> not a big deal though
10:07:43 <wheals_> or even not as zombies, just "place: D:5" will put a monster from D:5
10:08:00 <gammafunk> yeah, something that probably doesn't see much legitimate use
10:09:02 <gammafunk> a little hard to say from looking at des, but it seems there are a few of them
10:10:59 <wheals_> looking at it again, i didn't need to make VAULT_MON_WEIGHTS_KEY or VAULT_MON_BANDS_KEY be in the header even pre-save-compat break, though
10:11:40 <gammafunk> oh ok, I can maybe remove that then
10:12:02 <gammafunk> just have the BANDS key in tags.cc or something?
10:12:09 <gammafunk> since I think the compat was only about that one
10:12:16 <gammafunk> or no, there's also PLACE
10:13:36 <gammafunk> well if you know how to modify that to not have the TAG_MAJOR, feel free to update, otherwise I'll take a look when I actually touch some of this stuff
10:16:00 <wheals_> the tags.cc code could just use the raw strings instead of #defines, it's dirty but it's just save compat stuff
10:17:26 <gammafunk> yeah, I suppose that would be fine, since it's code meant to be removed
13:56:10 <espais> !tell Napkin reCaptcha has been pushed to the mantis repo
13:56:10 <Sequell> espais: OK, I'll let napkin know.
14:00:26 <espais> !tell napkin I had to update the API key to use the cdo domain, which means that I won't be able to see if it works until its in a place on the webserver that is visible to the web on cdo
14:00:27 <Sequell> espais: OK, I'll let napkin know.
14:01:41 <gammafunk> Finally, I'll prove that I'm not a robot
14:02:06 <espais> !tell napkin note that gammafunk's IP address has been blacklisted
14:02:06 <Sequell> espais: OK, I'll let napkin know.
14:02:25 <gammafunk> FeelsRobotMan
14:02:43 <espais> ¯\_(ツ)_/¯
14:09:36 <Napkin> lol
14:09:36 <Sequell> Napkin: You have 7 messages. Use !messages to read them.
14:14:39 <Napkin> espais, could you put the secret and the data-sitekey in config_inc.php and reference from there?
14:16:28 <espais> sure, i can do that
14:16:41 <Napkin> that would be nice
14:21:18 <espais> do you want me to add that to the repo then or just email it to you?
14:21:32 <Napkin> repo is easiest, no?
14:21:45 <espais> if config_inc.php were a part of the repo, yes :)
14:21:56 <Napkin> ahhh, right :D
14:21:56 <espais> i can add it, but you'd had it separated so i wanted to check
14:22:01 <Napkin> nono, don't
14:22:19 <Napkin> privmsg
14:39:21 <gammafunk> @?queen ant
14:39:22 <Gretell> queen ant (04a) | Spd: 10 | HD: 13 | HP: 54-84 | AC/EV: 14/3 | Dam: 2004(strong poison:47-84) | Res: 06magic(60) | Vul: 09poison | Chunks: 14noxious | XP: 879 | Sz: Large | Int: animal.
14:40:18 <espais> napkin: sent you the updated file, but obviously you'll have to update the connection string
14:40:41 <espais> changes to signup/signup_form.php also pushed
14:40:50 <espais> ....i probably should be working :S
14:58:28 <Napkin> you see the private message, espais?
15:55:44 <Napkin> alright, reCaptcha is live
15:55:49 <Napkin> let's see if that helps
15:56:19 <Napkin> !tell espais all hail espais! reCaptcha is live!
15:56:20 <Sequell> Napkin: OK, I'll let espais know.
16:04:44 <gammafunk> https://cdn.discordapp.com/attachments/205316046230388737/352181745069588491/unknown.png
16:04:47 <gammafunk> I told you guys
16:04:50 <gammafunk> no one believed me
16:06:10 <Napkin> mmh?
16:06:20 <Napkin> looks ok to me, gammafunk
16:06:26 <Napkin> what's wrong?
16:07:04 <geekosaur> referencing "I'm not a robot" joking
16:07:09 <geekosaur> some hours ago
16:07:24 <Napkin> what a cheater! ;)
16:07:50 <gammafunk> 🤖🤖🤖
16:12:38 <amalloy> that captcha made me question whether i am a robot
16:13:01 <Napkin> might be
16:13:02 <gammafunk> You couldn't figure out what humans mean by "road", could you?
16:13:12 <amalloy> no, it asked me about street signs
16:13:22 <Napkin> i hate that
16:13:44 <Napkin> but more i hated 50 fake accounts a day, i have to admit
16:14:02 <amalloy> like, here are some pictures, mark all parts of the picture with a street sign in them. but like...do i count the post on which the signs are installed? or just the part of the sign with text?
16:14:04 <gammafunk> I'm really glad that we no longer have those korean spam bots
16:14:40 <gammafunk> I think it's fairly forgiving of that since it's evaluating a bunch of different things in addition to just which you select
16:15:03 <amalloy> probably there are multiple right answers too
16:15:07 <gammafunk> but I opt for "anything where anyone might declare X to have Y for any remote reason"
16:15:23 <amalloy> i went the other way, deciding that the signpost is not part of the sign
16:15:48 <gammafunk> please just don't bias it so that my selection methodology gets me declared to be a robot!
16:16:08 <amalloy> could also be that google doesn't know yet. there were two pictures, so probably one was a control group google knows the answer for and the other they're trying to learn about
16:16:14 <amalloy> like they do/did for books
16:17:32 <gammafunk> what if it showed pictures of code and asked to select the pictures with good code
16:18:49 <amalloy> reverse image search them, and select the ones that don't come from crawl/crawl
16:23:13 <Napkin> weeeell, no fake registration yet!
16:26:28 <amalloy> any real registrations?
16:26:46 <Napkin> no, only my test account
16:28:28 <amalloy> Napkin: if you'd like we could make an announcement on /r/dcss that we fixed signup and welcome people to test it
16:29:15 <Napkin> nah, not "test it" - but rather "participate easily again" or something like that
16:30:36 <amalloy> sure
16:30:58 <Napkin> good idea, i think
16:37:07 <amalloy> https://www.reddit.com/r/dcss/comments/6wu2ft/mantis_tavern_bugreporting_captcha_fixed/
18:05:51 <johnstein> !tell |amethyst can you take another look at: https://github.com/crawl/crawl/pull/594 (since your wrote the bug) I do prefer my behavior over the simpler PR 536, but I'm obviously biased :)
18:05:52 <Sequell> johnstein: OK, I'll let |amethyst know.
18:06:50 <johnstein> (or any other Dev too. pretty sure I bugged amalloy and gammafunk about it when I was working on it)
18:42:29 -!- yesno_ is now known as yesno
18:44:38 <Cheibriados> 03PleasingFungus02 {GitHub} 07https://github.com/crawl/crawl/pull/603 * 0.21-a0-223-gc4e17e0: Brace. 10(4 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/c4e17e0ce5ab
18:45:54 <Cheibriados> 03Floodkiller02 {PleasingFungus} 07* 0.21-a0-226-gb48fd38: Don't list Chei attribute support for Gnolls (#11183) 10(6 days ago, 1 file, 1+ 0-) 13https://github.com/crawl/crawl/commit/b48fd38146bb
18:45:54 <Cheibriados> 03PleasingFungus02 07* 0.21-a0-227-g58a7c62: Brace. 10(6 minutes ago, 1 file, 5+ 3-) 13https://github.com/crawl/crawl/commit/58a7c62a0140
19:09:14 <Jorgrell> Unstable branch on crawl.jorgrun.rocks updated to: 0.21-a0-227-g58a7c62 (34)
19:18:57 <wheals_> the ever-elusive PF commit
19:22:34 <gammafunk> Brace yourself
20:03:36 <gammafunk> Before I remove this code
20:05:09 <gammafunk> If anyone sees why place_monster() should have special code to try to "shove" the player off stairs when spawning mosnters near stairs and the chosen spwan location in on said stairs
20:05:18 <gammafunk> s/in on/is on/
20:05:21 <gammafunk> let me know
20:06:47 <gammafunk> But as far as I can tell the logic is only for proximity of spawning near stairs, which is only used for things like orb spawns and spawns in non-connected branches to try to make them a bit nastier
20:07:11 <gammafunk> And there would be no good reason to try to move the player off of stairs for a monster spawn
20:37:02 <alexjurkiewicz> !seen PleasingFungus
20:37:02 <Sequell> I last saw Pleasingfungus at Fri Aug  4 00:07:54 2017 UTC (3w 5d 29m 8s ago) quitting, saying 'Quit: ChatZilla 0.9.93 [Firefox 54.0.1/20170628075643]'.
20:39:11 <amalloy> gammafunk: what you say makes sense to me. i can't attest to whether your change does what you describe, though. maybe create a PR if you want review?
20:40:42 <gammafunk> amalloy: yeah, I'm still not completely finished with a refactor, but just because some of the logic is very old (and very broken, if you saw that nice for loop I pointed out), maybe I'll branch this and make a PR
20:40:54 <gammafunk> !source is_near_stair
20:40:55 <Sequell> Can't find is_near_stair.
20:40:58 <gammafunk> !source is_near_stairs
20:40:59 <Sequell> Can't find is_near_stairs.
20:41:03 <gammafunk> er
20:41:07 <gammafunk> !source _is_near_stairs
20:41:07 <Sequell> 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-place.cc#L736
20:41:21 <gammafunk> oh you saw that one, since you found the commit
20:41:22 <amalloy> yes, i remember that
20:41:40 <gammafunk> but the whole logic in that function with the near stairs proximity is pretty borked I think
20:41:45 <amalloy> agreed
20:42:10 <gammafunk> it just got mixed up in the refactoring, and since it was never very critical, as it only related to some weird spawning mechanic, it never got looked at
21:21:14 -!- amalloy is now known as amalloy_
21:39:53 -!- amalloy_ is now known as amalloy
23:59:25 <Eksell> Unstable branch on CRAWL.XTAHUA.COM updated to: 0.21-a0-227-g58a7c62 (34)