00:18:11 https://www.reddit.com/r/dcss/comments/64ar4k/barachi/ 00:28:33 ??barachian 00:28:33 barachi[1/4]: New frog-like species in trunk. Has a Hop ability letting the player choose a spot up to 4 tiles away, landing them randomly in a 5x5 area. Range upgrades to 6 at XL13. Barachians have Slow 1 (move 1.2, faster than Na), are amphibious, and have average stats and apts (see barachian[2]). In addition, they have +1 LOS for a total of 8. 00:28:34 ??barachian[2 00:28:34 barachi[2/4]: http://i.imgur.com/cfacRyA.jpg 00:28:35 ??barachian[3 00:28:35 barachi[3/4]: http://i.imgur.com/A6n0jg1.jpg 00:28:35 ??barachian[4 00:28:35 barachi[4/4]: http://i.imgur.com/23atM.jpg 01:19:00 Unstable branch on crawl.develz.org updated to: 0.20-a0-972-gb9bd3e6 (34) 01:58:28 Windows builds of master branch on crawl.develz.org updated to: 0.20-a0-972-gb9bd3e6 02:51:51 Monster database of master branch on crawl.develz.org updated to: 0.20-a0-972-gb9bd3e6 03:12:51 Unstable branch on crawl.beRotato.org updated to: 0.20-a0-972-gb9bd3e6 (34) 03:33:17 Aphrodieselac (L20 HOFi) ASSERT(map_bounds(pbolt.target) || !(flags & SPFLAG_TARGETING_MASK)) in 'mon-cast.cc' at line 5703 failed. (Elf:3) 03:53:54 -!- mibe_ is now known as mibe 05:14:44 You're in the heat of big fight, when you notice that some of the monsters are summoned, but there are no obvious summoners around. Ok, someone read a scroll of summoning. But who? 05:15:57 It would be useful to implement some kind of search engine in history log and/or leave a note onto summoned monsters' info who their owner is. 05:17:26 or put a highlight on the summoner when your cursor is on the summon 05:33:35 -!- amalloy_ is now known as amalloy 06:11:18 ziggurnaut (L24 GrBe) (Depths:3) 06:14:32 Lightning rod not recharging until you use all its charges - bug or feature? 06:18:18 03gammafunk02 07* 0.20-a0-973-g0df07f8: Fix monster placement in a vault 10(8 hours ago, 1 file, 7+ 1-) 13https://github.com/crawl/crawl/commit/0df07f836105 06:18:18 03gammafunk02 07* 0.20-a0-974-g3e3c7a0: A batch of vaults from Cheibrodos (#10813) 10(4 days ago, 11 files, 974+ 1-) 13https://github.com/crawl/crawl/commit/3e3c7a0514a4 06:18:18 03gammafunk02 07* 0.20-a0-975-gfaf0b63: Nerf a Dungeon vault (Cheibrodos, #10891) 10(3 hours ago, 1 file, 10+ 5-) 13https://github.com/crawl/crawl/commit/faf0b637fd58 06:18:18 03gammafunk02 07* 0.20-a0-976-g035ce40: Rework a Lair ending vault (Cheibrodos, #10874) 10(3 hours ago, 1 file, 44+ 41-) 13https://github.com/crawl/crawl/commit/035ce4085c47 06:27:13 -!- amalloy is now known as amalloy_ 06:30:47 -!- Dracunos_ is now known as Dracunos 06:47:28 !kw hotspot 06:47:29 Keyword: hotspot => vlong>=0.19-a0-1829-g8a8ed2c 06:47:57 !kw hotspot2 vlong>=0.20-a0-976-g035ce40 06:47:57 Defined keyword: hotspot2 => vlong>=0.20-a0-976-g035ce40 07:09:25 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-976-g035ce40 (34) 11:02:23 03advil02 07[mutation_cleanup] * 0.20-a0-979-gb3f3db5: Improve mutation tests and lua bindings 10(2 minutes ago, 5 files, 140+ 30-) 13https://github.com/crawl/crawl/commit/b3f3db537523 11:02:38 can i please be done 11:23:07 New branch created: pull/510 (7 commits) 13https://github.com/crawl/crawl/pull/510 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-973-g37059eb: Rework the mutation api and add lua bindings 10(6 days ago, 65 files, 1150+ 688-) 13https://github.com/crawl/crawl/commit/37059eb41ddc 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-974-g314c042: Add a (c++) validate function for mutations, including Ds muts 10(4 days ago, 2 files, 65+ 1-) 13https://github.com/crawl/crawl/commit/314c042c2152 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-975-gfea3def: Add a demonspawn random mutation test 10(4 days ago, 5 files, 162+ 15-) 13https://github.com/crawl/crawl/commit/fea3def7368f 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-976-g155407d: Fix innate/non-innate mutation interactions 10(2 days ago, 9 files, 78+ 49-) 13https://github.com/crawl/crawl/commit/155407d6cb22 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-977-g89e8290: Generalize Ds testing to all species 10(17 hours ago, 3 files, 85+ 66-) 13https://github.com/crawl/crawl/commit/89e82909da22 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-978-gb59fc3d: Fix a deletion case, add some docstrings 10(12 hours ago, 7 files, 79+ 20-) 13https://github.com/crawl/crawl/commit/b59fc3d987b5 11:23:08 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-979-gb3f3db5: Improve mutation tests and lua bindings 10(22 minutes ago, 5 files, 140+ 30-) 13https://github.com/crawl/crawl/commit/b3f3db537523 11:23:54 oops, all the commit message spam 11:29:55 https://crawl.develz.org/tavern/viewtopic.php?f=17&t=23399 11:30:02 "I've managed to build and run DCSS on Apple TV" 11:30:08 local tiles, apparently 11:52:19 03advil02 07[mutation_cleanup] * 0.20-a0-979-gb683dd6: Improve mutation tests and lua bindings 10(52 minutes ago, 5 files, 142+ 32-) 13https://github.com/crawl/crawl/commit/b683dd6bdf23 11:52:23 03advil02 07https://github.com/crawl/crawl/pull/510 * 0.20-a0-979-gb683dd6: Improve mutation tests and lua bindings 10(52 minutes ago, 5 files, 142+ 32-) 13https://github.com/crawl/crawl/commit/b683dd6bdf23 11:52:54 03advil02 07* 0.20-a0-977-gf20264c: Rework the mutation api and add lua bindings 10(6 days ago, 65 files, 1150+ 688-) 13https://github.com/crawl/crawl/commit/f20264c8a055 11:52:54 03advil02 07* 0.20-a0-978-g96a32bd: Add a (c++) validate function for mutations, including Ds muts 10(4 days ago, 2 files, 65+ 1-) 13https://github.com/crawl/crawl/commit/96a32bd6970a 11:52:54 03advil02 07* 0.20-a0-979-gaec8439: Add a demonspawn random mutation test 10(4 days ago, 5 files, 162+ 15-) 13https://github.com/crawl/crawl/commit/aec8439ba07c 11:52:54 03advil02 07* 0.20-a0-980-gf97edb8: Fix innate/non-innate mutation interactions 10(2 days ago, 9 files, 78+ 49-) 13https://github.com/crawl/crawl/commit/f97edb84718e 11:52:54 03advil02 07* 0.20-a0-981-g2ae7950: Generalize Ds testing to all species 10(18 hours ago, 3 files, 85+ 66-) 13https://github.com/crawl/crawl/commit/2ae79503be8b 11:52:54 03advil02 07* 0.20-a0-982-gdc20831: Fix a deletion case, add some docstrings 10(12 hours ago, 7 files, 79+ 20-) 13https://github.com/crawl/crawl/commit/dc208312b984 11:52:54 03advil02 07* 0.20-a0-983-g35de22d: Improve mutation tests and lua bindings 10(52 minutes ago, 5 files, 142+ 32-) 13https://github.com/crawl/crawl/commit/35de22d400f7 11:54:05 ok 11:54:09 only small projects for a while 11:55:52 famous last words 11:55:57 heh 11:56:08 (see also: yak shaving,, crawlcode) 11:57:46 cleaning up the mutation api is definitely a yak shaving situation, now that I know the code somewhat better I can think of a ton more things that one might want to do 11:59:11 <|amethyst> advil: why'd you make a PR anyway, if you already had the branch? 11:59:22 so I could use the rebase and merge button 11:59:32 (also it makes the revert button possible in an emergency) 11:59:58 basically, laziness :-) 12:00:38 <|amethyst> I have a different definition of laziness and am glad to type three or four lines in the shell if it saves me a click 12:00:42 <|amethyst> the mouse is so far away! 12:01:04 heh 12:01:46 though one thing I learned in this project also is that if you PR it right away, the github interface for commenting etc is a lot smoother. So I kind of wish I'd used a PR from the beginning 12:09:18 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-983-g35de22d (34) 12:10:00 now I can let the CJR/CPO crashes roll in 12:14:33 <|amethyst> advil: hmm 12:15:03 uh oh 12:15:43 <|amethyst> advil: in that second commit (validate_mutations), take a look at the change to perma_mutate 12:15:57 <|amethyst> it removes the increment to you.innate_mutation as well 12:16:05 I moved it into mutate 12:16:21 <|amethyst> oh, I see 12:16:24 all the bookkeeping (except transient mutation xp) is centralized in mutate 12:16:29 it was spread all over before 12:18:09 in mutate and in _delete_single_mutation_level that is 12:18:31 <|amethyst> just wasn't expecting to see that change in that commit 12:18:52 <|amethyst> so thought it was an accidental over-deletion 12:19:08 yeah, reasonable -- the reason it is there IIRC is that I needed to do that one at a time in order to get the validation logic to work 12:19:29 <|amethyst> yeah, makes sense 12:19:32 before, perma_mutate did all the mutations and then incremented the levels, and I wanted to validate Ds mutations at every change 12:20:28 in retrospect I definitely could have made the commits better chunked, but I didn't know how until I'd already done a lot of it :-/ 12:20:34 <|amethyst> :) 12:21:20 is there a good workflow for breaking a large commit into smaller chunks? 12:21:42 I found "git add -p" which is great in some cases but kind of fiddly to use for a big commit 12:22:57 <|amethyst> git reset + N*(git add -p; git commit) is what I would do 12:24:06 yeah, I tried that a bit 12:24:12 <|amethyst> probably you could make it a bit easier with git difftool but I've never used it 12:24:16 <|amethyst> (I do use mergetool) 12:24:27 ah, I don't know either of those 12:24:47 part of the problem is that I'm a bit ocd about not committing unless it at least compiles, and git add -p makes that a pain 12:24:53 <|amethyst> they rely on external tools, so you need to have and know those 12:25:01 <|amethyst> yeah 12:25:13 <|amethyst> can't really do anything there but test 12:25:26 <|amethyst> you can git stash save compile git stash pop after each commit 12:25:28 I was using stash 12:25:29 yeah 12:26:12 <|amethyst> or there's probably an option to git stash save to only stash changes that aren't in the index 12:26:17 <|amethyst> so then you could do it before you commit 12:26:50 <|amethyst> I'm sure there are tools out there to make all this easier 12:27:20 <|amethyst> or if not, it's just a bit of shell scripting 12:27:33 <|amethyst> "just" 12:27:34 <|amethyst> "bit" 12:29:14 <|amethyst> oh, I know you want nothing to do with refactoring mutation code right now, but 12:29:36 <|amethyst> it would be nice to wrap those four boolean arguments to mutate() into a class 12:29:57 <|amethyst> err, really a struct I'm sure 12:30:10 <|amethyst> or even a bitfield enum 12:30:28 there's definitely a bunch more abstraction that could/should be done 12:30:48 one thing I would still like to do also is make an actual iterator for mutation_type 12:31:02 <|amethyst> hm? 12:31:41 instead of "for (int i = 0; i < NUM_MUTATIONS; ++i)" everywhere 12:32:29 but yeah, doing something about those boolean arguments might help with a bunch of functions (get_base_mutation_level also) 12:33:14 <|amethyst> I don't know, for (mutation_iterator i; i != mutation_iterator::end(); ++i) doesn't seem that much better to me 12:33:56 <|amethyst> particularly when things like the save code does depend on the mutations coming out in order and that order not changing 12:34:44 <|amethyst> (to be fair, you could simplify what I wrote to: for (mutation_iterator i; i; ++i) with an appropriate operator bool()) 12:34:59 <|amethyst> but 12:36:39 <|amethyst> if you made a data-free class mutation_range with members mutation_type begin() const returning mutation_type(0), and mutation_type end() const returning NUM_MUTATIONS 12:36:54 <|amethyst> you could do for (mutation_type m : mutation_range) 12:37:32 <|amethyst> you'd probably need DEF_ENUM_INC(mutation_type) to allow you to use ++ directly on the mutation type 12:37:51 yeah, that's sort of what I had in mind. 12:37:58 <|amethyst> oh wait 12:38:18 <|amethyst> you'd need a wrapper because for-range uses operator* 12:39:01 also, it would be really useful to use find_if etc, and sometimes you want to include the category mutations (MUT_RANDOM) and sometimes you don't 12:40:16 I didn't mean changing anything about the underlying enum, I think you're right that saving is using that in order 13:26:27 Unstable branch on crawl.akrasiac.org updated to: 0.20-a0-983-g35de22d (34) 13:56:19 !tell pleasingfungus https://www.reddit.com/r/dcss/comments/64ar4k/barachi/ 13:56:20 Brannock: OK, I'll let pleasingfungus know. 14:29:43 j 14:35:00 <|amethyst> https://www.reddit.com/r/dcss/comments/64eazf/my_formicid_is_literally_trapped_any_suggestions/ 14:35:08 <|amethyst> that's nicolae_pan_performance_anxiety 14:35:26 <|amethyst> but it's weird because it has an appropriately-placed KPROP that should apply there 14:37:21 <|amethyst> this was a portal destination rather than a shaft 14:38:46 https://crawl.develz.org/mantis/view.php?id=9882 14:39:45 <|amethyst> ah 14:41:26 <|amethyst> same vault too 14:45:38 -!- amalloy_ is now known as amalloy 17:04:04 -!- amalloy is now known as amalloy_ 18:15:38 Unstable branch on underhound.eu updated to: 0.20-a0-983-g35de22d (34) 22:13:15 hellmonk: updating now 22:13:28 kool 22:15:33 johnstein: can I get an update as well, please? I pushed some bugfixes. 22:15:44 also I pushed some spicy mutation related commits 22:22:31 ??rebuild 22:22:31 rebuild[1/2]: http://crawl.akrasiac.org/rebuild/ http://underhound.eu:81/rebuild/ http://crawl.berotato.org/crawl/rebuild/ http://crawl.xtahua.com/rebuild/ https://crawl.jorgrun.rocks/rebuild/ Bug |amethyst or Nap.Kin for CDO. Use your powers wisely. 22:31:42 03advil02 07* 0.20-a0-984-ge8aa303: Tweak WJC wall jump messaging 10(6 minutes ago, 4 files, 43+ 9-) 13https://github.com/crawl/crawl/commit/e8aa30383ec5 22:35:30 so what's the dealeroni, do I need to do something 22:37:10 Experimental (hellcrawl-cbro) branch on crawl.beRotato.org updated to: v1.0-136-g7a863a7 23:02:32 dealeroni, rip in pepperoni 23:08:46 agree 23:09:23 Unstable branch on crawl.jorgrun.rocks updated to: 0.20-a0-984-ge8aa303 (34) 23:25:42 well, my plan to stalk MarvinPA about tombhatches 23:25:52 it has been thwarted this evening...but I shall return! 23:37:53 !vault minivault_13 23:37:53 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/des/variable/mini_monsters.des#L6612 23:38:36 so i get that modifying these vaults is frowned upon but the runed door on this is incredibly pointless if a deep troll earth mage or deep troll elementalist generates in it 23:38:40 or if it generates in abyss 23:42:38 I don't think it even needs a runed door, three 8s on d:9 is chump change 23:42:49 hellmonk: no Puppers? 23:42:57 not yet 23:43:13 coming eventually 23:43:18 can you combine all weapon skills into one 23:43:42 I want to at the very least merge some of the weaponskills yeah 23:43:55 holy poop you play games alex? 23:44:19 only when no other opportunity presents itself 23:44:44 probably shorts into longs and staves into maces for starters, would prob be good to shove uc out and just make transmutation form spellpower control damage when unarmed but that takes more effort 23:45:36 there's at least semi-legitimate differences between m&f, axes, and polearms although you can argue that polearms are degenerate and therefore Bad ofc 23:46:20 you could cut staves perhaps 23:46:32 actually, that might be hard unless you want to cut enhancer staffs 23:47:27 just roll them into maces and flails and rename it maces and staves 23:47:54 will also need to reduce the ridiculous number of weapon base types in the process though 23:48:49 cool 23:49:09 then would also be good to do shorts into longs, remove riposte and let stabbers use a weapon that doesn't suck 23:50:02 stabbing bonus is kind of a lame weapon difference but theres so many weapons that I really can't imagine cutting more than two skills to start with 23:52:03 then on the magic side I want to cut conjurations as a skill (I know I've talked about this one before) 23:57:03 how has nostairs treated you so far alex 23:57:46 watched implojin die in coc 4 earlier, need to nerf the orbrun a lil' more 23:58:11 prob cut orb tele delay 23:58:23 do you still need 3 downstairs 23:59:00 I don't know that I can remove them without screwing up level generation 23:59:01 well, I see the potential benefits, but maybe just two 23:59:09 ah, crawlcode 23:59:18 but in any case I like them because it lets you dive easier if you want/need to