00:00:04 -!- omarax has quit [Remote host closed the connection] 00:00:11 !lg . opsu 00:00:13 11. gammafunk the Demonologist (L24 OpSu of Sif Muna), escaped with the Orb and 3 runes on 2016-08-24 01:42:21, with 1244803 points after 106624 turns and 10:11:38. 00:00:18 !lg . opsu -2 00:00:19 10/11. gammafunk the Caller (L6 OpSu), quit the game on D:6 on 2014-08-30 23:32:06, with 429 points after 2090 turns and 0:15:45. 00:00:33 basically a oneandwon 00:00:56 does ogsu count 00:00:57 for this challenge 00:01:15 I mean, you can, those are kind of melee su 00:01:21 what was your aim, pure su of sif? 00:01:27 well yeah 00:01:33 if you want more hp, maybe just husu 00:01:35 or drsu etc 00:01:40 oh drsu sounds fun 00:01:50 i'll probably just do kosu tho 00:02:09 ally-induced stabbing opportunities sounds fun 00:02:25 musu it up 00:02:37 -!- debo_ has joined ##crawl-dev 00:02:39 that's not quite pure su but honestly we can't control koboldina 00:02:47 hopeless to try 00:02:51 ah, hosu 00:05:57 -!- HellTiger has quit [Read error: Connection reset by peer] 00:08:01 -!- debo_ has quit [Ping timeout: 276 seconds] 00:09:47 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1401-g902f63d (34) 00:16:50 -!- Ladykiller69 has quit [Read error: Connection reset by peer] 00:24:46 -!- MaxFrost has quit [Quit: Going offline, see ya! (www.adiirc.com)] 00:29:28 -!- Bcadren has quit [Ping timeout: 276 seconds] 00:30:07 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.19-a0-1401-g902f63d (34) 00:30:40 -!- Poncheis has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0.2/20160823121617]] 00:31:56 -!- debo_ has joined ##crawl-dev 00:36:11 -!- debo_ has quit [Ping timeout: 255 seconds] 00:36:39 -!- Nomi has quit [Read error: Connection reset by peer] 00:43:44 -!- Harudoku has quit [Ping timeout: 252 seconds] 00:55:43 -!- ontoclasm has joined ##crawl-dev 00:59:22 -!- rossi has quit [Ping timeout: 276 seconds] 01:00:02 -!- omarax has quit [Read error: Connection reset by peer] 01:04:28 CanOfWorms: good to know that instead of oka -> tso i should go oka -> hep for 1 turn -> tso so that I don't have to deal with oka wrath summons 01:04:52 if that works that sounds pretty funny 01:05:38 and you should credit koboldina for that :v 01:05:54 ??challenge[21] 01:05:54 challenge[21/26]: Win a game in which all temple gods (including those in overflow altars) are abandoned before XL 10. Lacertilians are not allowed. 01:06:01 could make this easier 01:08:18 !tell pleasingfungus based on koboldina's game I think hep wrath breaks xp-gated effects, including 01:08:19 CanOfWorms: OK, I'll let pleasingfungus know. 01:08:25 !tell pleasingfungus CanOfWorms: good to know that instead of oka -> tso i should go oka -> hep for 1 turn -> tso so that I don't have to deal with oka wrath summons 01:08:26 CanOfWorms: OK, I'll let pleasingfungus know. 01:09:02 -!- Dracunos has quit [Ping timeout: 252 seconds] 01:19:05 -!- ldf has quit [Ping timeout: 240 seconds] 01:19:57 Unstable branch on crawl.develz.org updated to: 0.19-a0-1401-g902f63d (34) 01:22:51 -!- elliptic has joined ##crawl-dev 01:40:31 -!- Zeor has quit [Quit: Leaving.] 01:41:22 -!- Brickman has quit [Quit: Page closed] 01:47:55 -!- hellmonk has quit [Quit: Page closed] 01:50:34 -!- PleasingFungus has joined ##crawl-dev 01:51:41 CanOfWorms: doesn't that only work until hep wrath ends? 01:51:41 PleasingFungus: You have 2 messages. Use !messages to read them. 01:53:56 is oka's mollification also tied to xp? 01:54:19 i believe it's based on number of wrath waves sent 01:55:04 like most wrath effects 01:55:23 actually 01:55:26 hmm 01:56:10 it looks like penance is reduced first 01:56:10 before the function kicks out of hep wrath? 01:56:21 because hep penance needs to resolve 01:56:36 Windows builds of master branch on crawl.develz.org updated to: 0.19-a0-1401-g902f63d 01:56:37 !source player.cc:2662 01:56:37 https://github.com/crawl/crawl/blob/master/crawl-ref/source/player.cc#L2662 01:57:43 oh wait that's just xp gods 01:57:53 well, it does mean you can like 01:57:57 switch gozag > hep > ??? 01:58:01 and avoid wrath 01:58:18 assuming that you win before hep wrath runs out? 01:59:14 it's not like you're going to be higher level or more skilled after hep wrath ends, and if you may well be worse off (malmuts, etc) 01:59:45 just gotta believe in the gods :v 02:00:04 -!- omarax has quit [Remote host closed the connection] 02:00:29 -!- Shard1697 has quit [Ping timeout: 264 seconds] 02:00:36 -!- destroythecore has quit [Read error: Connection reset by peer] 02:01:48 Incorrect description of Dithmeno's shadow form 13https://crawl.develz.org/mantis/view.php?id=10648 by Lavandula 02:01:48 i guess your piety will probably be full after, which is a plus 02:01:48 still it's basically a way to guarantee no god wrath in exchange for no xp 02:01:48 *no god wrath for a duration of time 02:02:31 in any case that code also has weird interactions with every other xp-gated effect, like abyss exit spawns, temporary malmutations, stat drain, regular drain... 02:02:38 rechargeable evocables 02:02:39 weird is an interesting term 02:02:45 it's a pretty simple and consistent interaction 02:02:52 hmm 02:02:53 which is the reason i'm arguing for it 02:02:55 unintuitive then? 02:03:26 is it? 02:03:44 basically it's not explicitly spelled out and I don't think anyone naturally comes to the conclusion that hep wrath includes things other than XP/skills remain fixed 02:03:50 xp-gating in the first place is weird 02:04:24 the interaction is simple and consistent if you read the code, but probably not if you think of it from a design standpoint 02:04:59 "hep prevents gaining experience and skills, and also stat recovery, abyss exit spawning, temporary malmutations, drain, evocable recharging, god wrath..." 02:05:10 *god wrath for most gods 02:05:26 "hep prevents gaining experience, and all things that depend on gaining experience" 02:05:40 "transfer knowledge, apparently" 02:08:19 one of my main concerns here is that implementing this wrath in a way that supports all those effects is a code nightmare 02:08:35 but if it is a problem, something will have to be done 02:08:43 also quaffing !xp is the only way of gaining xp that doesn't mollify other xp gods 02:08:55 so there's some inconsistency there 02:09:01 -!- VoxSomniator has quit [Quit: Leaving] 02:09:08 ? 02:09:12 rephrase? 02:09:31 if you quaff a potion of xp, the code directly reduces hep's penance 02:09:46 but if you gain xp normally, the code reduces the penance of other xp gods 02:09:56 which are ash and gozag (and pakellas rip) 02:10:12 ah, sounds like an oversight on my part 02:10:55 I think you just want to move the hep check to 02:11:01 !source player.cc:2720 02:11:01 https://github.com/crawl/crawl/blob/master/crawl-ref/source/player.cc#L2720 02:11:24 #fixpakellas 02:11:31 by which I mean wrap that entire block of code that appears to handle xp/skills 02:11:32 we did....r e m o v e 02:11:43 huh? 02:11:45 which block? 02:12:03 oh, this is because I'm looking at an old version, isn't it 02:12:05 uh 02:12:19 2668 02:12:24 i wonder if !xp should just be marked useless and undrinkable for the duration of wrath 02:13:02 !source player.cc:2668 02:13:02 https://github.com/crawl/crawl/blob/master/crawl-ref/source/player.cc#L2668 02:13:02 gammafunk: disabling is not quite removing 02:13:02 but it does have a use, reducing wrath :v 02:13:02 that doesn't work 02:13:24 2645-2648 are probably still problems 02:13:30 you might be able to move those? but maybe not 02:13:56 seems like the code should be moved out into its own functions 02:14:31 could definitely do with a refactoring 02:14:37 scary to touch, though 02:14:51 I call upon the dark forces and summon Brannock to do this refactoring exercise 02:15:16 lol 02:15:20 not nice 02:15:25 like _recharge_xp_evokers(exp_gained); 02:15:31 that's already pulled out 02:15:46 need _reduce_drain(exp_gained), etc 02:16:06 _remove_temp_mutations 02:16:13 _restore_attributes 02:17:08 yeah any time you see 5 consecutive lines of code 02:17:12 there must be a new function 02:17:15 that's how programming works, CanOfWorms 02:19:58 see? gammafunk gets it 02:20:33 I look forward to a series of patches from CanOfWorms replacing every code block in crawl with its own function 02:20:38 patch format? png of course 02:20:57 bool _player_is_in_penance 02:21:05 if _player_is_in_penance { ... 02:21:22 Honestly I would happily do all the refactor stuff but I only started working in C++ a month ago and I barely understand how to convert notes.cc into something not awful 02:21:25 !source player_under_pennance 02:21:27 Can't find player_under_pennance. 02:21:33 I can recognize that it's bad... but not how to make it good. 02:21:35 !source player_under_penance 02:21:35 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/religion.h#L66 02:21:41 that one already exists 02:21:48 CanOfWorms: the joke is that i actually believe this 02:21:52 the other joke is that i'm right 02:21:58 the last joke is gammafunk's play 02:22:02 compartmentalization is good 02:22:08 I wrote a play? 02:22:21 alas, poor Edmund 02:22:23 I knew him well 02:22:25 but gammafunk, redundancy is good 02:22:27 -!- n1k has quit [Read error: Connection reset by peer] 02:22:30 I did write a play, actually 02:22:39 ??doom_hound[2 02:22:40 doom hound[2/3]: alright, so the scene begins with Eresh smoking a cigarette, sitting at her kitchen table, which is made of bones and skulls. Her starcursed hair is twinkling, but frizzled and unkempt, and she's staring blankly out into space in between drags. A doom hound is heard howling in the distant background. 02:22:47 pf: believe what 02:23:21 yeah any time you see 5 consecutive lines of code, there must be a new function. that's how programming works, CanOfWorms 02:23:30 ah 02:27:56 the process of setting up git and actually doing stuff on my end is so tedious but I do have an rough idea on how to reorganize that entire thing 02:28:04 it's probably less effort to just coordinate with brannock :v 02:28:23 It only took like 1 hour of amethyst and gammafunk and geekosaur helping me to get git online 02:28:28 I'd be happyt o repeat it with you 02:28:32 haha no you see 02:28:45 I already installed git once with gammafunk 02:28:51 that was maybe 02:28:53 but I completely forgot how to use it since it was like 02:28:57 the most painful 30 minutes of my life 02:28:59 at least one year ago 02:29:14 30 minutes? who am I kidding, it was like over an hour 02:29:53 it was way longer than an hour :v 02:29:53 and involved error message uploaded in png format 02:29:58 in conclusion, never help artists get into programming 02:29:58 good times 02:30:11 the correct lesson is actually 02:30:15 don't help artists set up git 02:30:36 well you need the source code to program 02:30:48 and you need to commit your changes 02:30:55 no I don't 02:31:09 I can just keep my local copy of dungeon crawl: everything is a spriggan 02:31:12 sometimes the right move is to point them to git desktop on github :) 02:31:22 yeah Brannock started with that 02:31:22 I need to learn how to macro stuff in git because $ git fetch upstream $ git reset --hard upstream/master $ git push --force takes too long... my workflow... 02:31:38 woah 02:31:42 you hard reset every time? 02:31:43 why? 02:31:47 should Inot 02:31:48 I like it better when my projects involve pushing a red button to compile 02:31:53 Brannock: no you shouldn't 02:31:53 which is like everything I work on :v 02:31:59 I like keeping local master exactly the same as crawl/crawl 02:32:00 or rather, you shouldn't need to 02:32:02 brannock's pillow is a nuclear missile 02:32:10 it's usually fine 02:32:11 Brannock: how is it different? 02:32:16 it shouldn't be 02:32:19 maybe you need git stash 02:32:21 you shouldn't need to 02:32:23 which is v. helpful 02:32:25 I always branch off origin/master after updating 02:32:31 that seems excessive 02:32:36 I don't recommend blind hard resets 02:32:50 if you have a local source conflict/uncommited stuff 02:32:52 keep your branch, update upstream/master, rebase your branch 02:32:52 git tells you 02:33:04 and yeah check out git stash 02:33:22 git stash to save your changes to a stash entry, reverting (hard) to HEAD 02:33:32 git stash pop to reapply that stash 02:33:48 and works if you do a pull in between git stash and git stash pop (might have conflicts, but you can fix) 02:34:04 and yeah generally you can do what geekosaur said and commit something to a branch, as well 02:34:23 hey 02:34:26 also git push --force as a default isn't right 02:34:37 that's what you should use when something's messed up, usually 02:34:53 !source mapdef.h:652 02:35:30 https://github.com/crawl/crawl/blob/master/crawl-ref/source/mapdef.h#L652 02:35:30 gammafunk: ^ is this supposed to be COLOUR_UNDEF 02:35:30 anyway yes, local master is good to keep the same as upstream master. you branch off that and fetch/rebase (or you can change pull's default to rebase instead of merge) 02:35:30 force pushing to his local fork of crawl is usually reasonable tbh 02:35:30 you will have to stash uncommitted changes 02:35:30 er, his github fork 02:35:30 hmm I need to remember how to compile 02:35:38 -!- TuxQmoob has quit [Changing host] 02:35:58 PleasingFungus: yeah that's a typo in the comment 02:35:59 i push dumb stuff to my amalloy/master occasionally and it's almost always out of sync when i next want to push there 02:36:18 03PleasingFungus02 {GitHub} 07* 0.19-a0-1402-g0c1e9a7: Comment typo fix 10(17 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/0c1e9a7a2328 02:36:44 CanOfWorms, nice make -j5 TILES=y :) 02:36:44 ...as to teraching artists to program, sometimes that's easier than teaching "programmers" to program 02:36:44 have someone in another channel who apparently can't do anything their ide doesn't do for them 02:36:44 I think I'll actually compile without tiles since I assume it will take less time 02:36:44 o.O 02:37:00 the problem with teaching CanOfWorms was that he proceeded to do 3 wrong things after every instruction I gave 02:37:06 -!- kdrnic has quit [Quit: Leaving] 02:37:09 spontaneously 02:37:14 gotta go fast 02:37:39 git was just a canvas for his experimental art 02:38:04 -!- Kalir has quit [Changing host] 02:38:32 PleasingFungus: At first I thought you were going to make me think about mon-info colour inheretance and I broke out into a cold sweat 02:39:01 "oh thank god it's just about a comment typo" 02:39:11 gammafunk/geekosaur: so git reset upstream/master and git push, won't cause issues with my fork? 02:39:20 i'm trying to figure out if the current dith wrath monster spawning behaviour is a bug or not 02:39:25 it uses COLOUR_UNDEF and I don't know why 02:39:29 -!- hpm_ has quit [Ping timeout: 255 seconds] 02:39:33 not if youre working on a branch like you're supposed to 02:39:47 color undef is usually fo things like ugly things that have weird color changing systems 02:39:51 https://help.github.com/articles/syncing-a-fork/ 02:40:02 what's the line that creates the dith wrath spawns? 02:40:04 I can look 02:40:06 I still think they should find a way to at least semi-automate that... 02:40:07 -!- TuxQmob has quit [Ping timeout: 276 seconds] 02:40:19 they already encourage you to work on forks so you can make pull requests 02:40:23 !source godwrath.cc:1605 02:40:23 https://github.com/crawl/crawl/blob/master/crawl-ref/source/godwrath.cc#L1605 02:40:26 wouldn't 'git merge upstream/master' create an extraneous commit in my history? 02:41:16 geekosaur, I saw that Git 2.10 was released today. some nice changes 02:41:19 ok gammafunk, it's kosu time 02:42:21 merge is not the ideal way to do it, yes, but it's the easy way. the somewhat harder is stash, rebase, stash pop 02:42:21 which changes *under* your local work so that it looks like you were working on current master instead of the older one 02:42:23 without a merge 02:42:26 force reset seems easiest, especially if I'm not working on local master at all, and am just resetting it to upstream so I can branch off it 02:42:34 I'm not sure I understand the problem with forcing hte reset 02:42:43 s/hte/the 02:43:05 it's a good way to lose any work you had forgotten about 02:43:25 does it affect branches, not just master? 02:43:32 no 02:43:32 force reset as part of a workflow is just a bad idea, yeah 02:43:41 I never work on master itself 02:43:42 it only affects the branch you are on. but it does a fair amount of violence to that 02:43:46 well. hrm. i guess it depends what those words mean 02:43:51 listen to gsaur 02:43:54 -!- GauHelldragon has quit [Ping timeout: 250 seconds] 02:44:17 okay looks like I found what I used to run git 02:44:26 looks like that could be COLOUR_INHERIT but I'm not sure about that RANDOM... monster type 02:44:28 now I need to remember what the compile command is 02:44:42 that code is probably not heavily tested 02:44:56 -!- TuxQmoob has quit [Ping timeout: 244 seconds] 02:45:16 and, if you aren't doing any work on the branch, it doesn't actually do anything --- but still, reset --hard is running with scissors 02:45:50 * geekosaur just configures pull to work by rebase instead of merge 02:46:10 means I have to stash first but it will at least warn me to do that if I didn't 02:48:09 same 02:49:21 i don't use pull; i fetch and then either merge or rebase. more typing i guess, but it means i get to see what the changes are before i decide how to apply them 02:49:54 yeah I do fetch a lot as well, but I also use pull a lot 02:50:59 hm. trying to replace monster* params with monster& params where applicable, and do_slow_monster is a bit odd. it feels weird to have a signature like do_slow_monster(monster&, actor*); is that enough reason to leave it as monster*? 02:51:39 and actor* is right because it does actually handle there being no actor 02:52:06 !source mon-place.cc:2915 02:52:07 https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-place.cc#L2915 02:52:21 stray comment? 02:52:32 -!- Zymurgist has quit [Ping timeout: 255 seconds] 02:52:55 mons_place() which calls place_monster() ...grrr 02:53:35 it's been a while since I've read the monster placement code... 02:53:35 amalloy: that is not a good enough reason at all! 02:53:44 monster&, actor* is a perfectly fine signature 02:54:14 Monster database of master branch on crawl.develz.org updated to: 0.19-a0-1402-g0c1e9a7 02:55:42 god, there are a lot of calls to simple_monster_message 02:55:48 canofworms could I get your opinion on an art thing 02:55:52 yes 02:56:04 https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/tiles/title_omndra_zot_demon.png if I put this on a shirt it would look best if I kill all the black around the demon's fire, right? 02:56:11 and make it transparency 02:56:22 probably, but can you actually do that??? 02:56:39 my meager art and Gimp skills are improving slowly 02:56:55 with fuzzy select and shenanigans yes I can do it 02:56:59 well the only issue I see is that the fire is semitransparent or something 02:57:15 yeah it's leaving like 02:57:16 I mean if you manually just lasso it out I don't know if it'll actually look good 02:57:16 red residue 02:57:30 it definitely looks a little wacky but it's hard to tell if it would look decent on a shirt or not 02:57:32 redsidue 02:57:33 ok I managed to re-clone the directory 02:57:39 now I need toremember how to compile 02:58:09 I'm mostly trying to shy away from the "here is a giant square on your shirt" style 02:59:12 PleasingFungus: I'm not sure if you're still puzzling over that, but yeah that looks like it should be COLOUR_INHERIT 02:59:12 would "here is a giant circle" be better? 02:59:12 gammafunk: good! 02:59:12 tyvm 02:59:16 canofworms: absolutely not 02:59:20 i'm poking at mgen-enum stuff 02:59:22 it looks like it would be weird if you set that to undef 02:59:26 mgen_data i gues 02:59:26 ok looks like it's... compiling...??? 03:00:03 -!- omarax has quit [Remote host closed the connection] 03:00:06 you probably have a pretty old msys setup; most current docs are in INSTALL.txt 03:00:28 -!- debo_ has joined ##crawl-dev 03:01:32 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 03:04:49 -!- debo_ has quit [Ping timeout: 240 seconds] 03:05:17 koboldina: I think currently the best you can do is "here is a blog that vaguely outlines the art" 03:05:28 -!- PleasingFungus has quit [Ping timeout: 276 seconds] 03:07:03 I have no idea what you mean by that worms 03:07:10 a blog? 03:07:18 -!- aditya has quit [Ping timeout: 250 seconds] 03:08:18 *blob 03:08:27 https://postimg.org/image/jvqz0464v/ I've been fooling around with different thresholds of fuzzy select and cutting and I think I'm making it look better for shirt purposes... maybe... 03:08:51 unfortunately it's a bit hard to tell w/o putting it on an actual shirt 03:09:00 it looks like it s hould work? 03:09:07 do you need to keep the title 03:09:12 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1402-g0c1e9a7 (34) 03:09:20 yeah I think he wants that, obv I am going to clean up the black in the lettering too 03:10:26 that's a scary monster 03:11:18 -!- ontoclasm has quit [Quit: Leaving.] 03:11:49 gammafunk the scariest monster is the pack of jackals that greeted my kosu at the beginning of this game 03:12:17 but its ok because you could summons bats and quokkas 03:12:23 even rats 03:13:03 -!- jehoesefat has quit [Read error: Connection reset by peer] 03:13:33 I did indeed barely survive 03:13:44 and found an mpregen ammy right next to them, which I feel like is the best item a su could ask for on d:1 03:13:55 yeah that's pretty sick 03:15:25 oh nice 03:16:04 hep wrath also halts evolution 03:16:18 well it makes sense that it would 03:16:48 d:2 book of beasts too gammafunk, are you cheating for me 03:17:08 more reasons why this should be 03:17:11 !lg koboldina kosu 03:17:13 1. koboldina the Caller (L3 KoSu), quit the game on D:2 on 2016-09-04 03:58:37, with 44 points after 1593 turns and 0:04:13. 03:17:17 er 03:17:18 not that one 03:17:24 well, you should win 03:17:25 that was the one you saw me quit out earlier :P 03:17:30 !stalk koboldina 03:17:32 koboldina the L1 KoSu^ in D:1 (cjr tiles), T:0, defenses: 2/15/0, stats: 5/16/15 03:18:24 su are pretty foolproof once you survive the first few floors, if you're experienced with using summons 03:18:30 which I know you are! 03:19:16 I just also found ijyb on d:2 and instead of engaging him, exercised caution and walked away 03:19:17 what's wrong with me 03:19:22 I should be reading immo scrolls and tabbing 03:20:04 -!- CanOfWorms has quit [Ping timeout: 244 seconds] 03:20:17 imagine that I and amalloy are silently watching you from heaven 03:20:24 looking down, judging your gameplay 03:20:27 "imagine" 03:21:42 lol 03:21:42 man, i was worrying about what i'm going to fill my time with until i start at google. it turns out there is a whole month worth of converting monster* to monster& 03:21:42 I'm supposed to go sif to get the full su experience right 03:21:42 Koboldina begins resting. Koboldina's health is restored. gammafunk thunders, "GOOD!" 03:21:58 well, I mean, you can do Su with all kinds of gods 03:22:13 I think for "kills almosts entirely with summons" sif is the most fun, but even then 03:22:38 like if you just want to go up to dcall and mess around with summons off and on, obviously you don't need sif 03:23:38 !lg . su won s=god 03:23:39 3 games for gammafunk (su won): 2x Sif Muna, Jiyva 03:23:45 j i y v a 03:23:50 ug 03:24:02 it was fine, but I'm no jiyva fan 03:24:05 the mpregen ammy makes me wonder if I even want sif 03:24:18 well mp regen ammy is just like less than one mp per turn 03:24:21 which is still a lot 03:24:30 sif is like you can finish nearly any fight with all summons 03:24:57 but yeah if you'd like to do significant melee you'll probably have fun with other choices 03:25:40 sif will also give you more summons spells, but there are things like gozag 03:26:39 Unstable branch on crawl.beRotato.org updated to: 0.19-a0-1402-g0c1e9a7 (34) 03:27:20 gozag seems like a wacky choice on a kobold 03:27:25 because it throws away gourmand 03:27:45 amalloy: getting rid of all those monster pointers sounds good; seems like all that gets us is "easy to handle the case when this function has nothign to do" 03:28:15 what do you mean by easy to handle etc 03:28:32 in that it just has a test for nullptr and can early return 03:28:42 -!- debo_ has joined ##crawl-dev 03:28:56 well, as written most of these functions will segfault if given nullptr 03:29:10 so converting to monster& makes it become impossible to call them 03:29:12 yeah, obviously those are great to convert 03:29:30 but there are certainly many functions that do check for nullptr, but probably those could take refs as well 03:29:52 It's not clear to me that we should ever really be using monster * unless some kind of special copying is going on 03:30:23 well, actor::as_monster() returns monster* for good reason 03:30:35 but you may be right that monster* is a bad parameter type, if not a bad return type 03:30:51 yeah I was kind of wondering if there was a better way for cases like your example 03:32:15 koboldina: basically the reasons I choose sif are having as much MP as I could ever want (within reason, and often I use "faith with new sif) and better spell progression 03:32:57 i'm a little torn about how to handle a large refactor like this. i'd kinda like to change a bunch of functions all at once for consistency, but if i try to do that it'll take a longish time and my changes will doubtless have merge conflicts 03:32:57 alternatively i can push frequently as incremental improvements 03:32:57 gammafunk I'm gonna give it a shot with sif yeah 03:32:59 worst case scenario I will be able to spam hydras super soon 03:33:29 yeah, and you chose the sexiest god, so congrats for that as well 03:33:33 -!- debo_ has quit [Ping timeout: 265 seconds] 03:34:29 amalloy: incremental does sound like a better way 03:34:37 well, so be it 03:35:14 03amalloy02 07* 0.19-a0-1403-ga61c852: Remove the prototype of a removed function (RIP landlubbers) 10(9 minutes ago, 1 file, 0+ 2-) 13https://github.com/crawl/crawl/commit/a61c852f2bc0 03:35:14 03amalloy02 07* 0.19-a0-1404-ge0ce5ce: Make do_slow_monster take monster& 10(36 minutes ago, 6 files, 13+ 13-) 13https://github.com/crawl/crawl/commit/e0ce5ceeb6f1 03:35:14 03amalloy02 07* 0.19-a0-1405-g74687b5: Make simple_monster_message take monster& 10(31 minutes ago, 39 files, 383+ 383-) 13https://github.com/crawl/crawl/commit/74687b5aeb00 03:35:14 03amalloy02 07* 0.19-a0-1406-g1c65f5a: Remove a check that can never fail 10(9 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/1c65f5a62425 03:35:41 gammafunk I killed dowan and duvessa at the exact same time via summons, I feel like this is memoralbe 03:42:38 -!- debo_ has joined ##crawl-dev 03:47:26 -!- debo_ has quit [Ping timeout: 252 seconds] 03:48:12 -!- Shard1697 has joined ##crawl-dev 03:49:55 -!- koboldina has quit [Quit: Page closed] 04:00:04 -!- omarax has quit [Remote host closed the connection] 04:02:55 -!- CanOfWorms has joined ##crawl-dev 04:03:08 okay I managed to compile trunk, so now I need to test all this code 04:03:49 is there a direct wizmode command to give myself a temp mutation 04:05:36 -!- bitcoinbastard has quit [Ping timeout: 250 seconds] 04:06:29 -!- mibert has joined ##crawl-dev 04:09:29 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1406-g1c65f5a (34) 04:17:03 i don't think so, CanOfWorms. &mwretched star is the closest i know of 04:17:10 deng 04:17:33 -!- eb has quit [Ping timeout: 240 seconds] 04:24:57 with the power of elisp and bash combined, i have created some truly hacky automated refactoring tools 04:25:31 good thing I just moved to vim, so now you port it to vimscript 04:26:15 *you can 04:29:42 wow, twitch's irc protocol is all extended to handle emotes and such 04:33:15 -!- omnirizon has quit [Ping timeout: 258 seconds] 04:37:50 http://pastebin.com/n10iRMFr 04:38:02 there's my code to make hep wrath only affect XL/skills 04:38:14 !tell pleasingfungus http://pastebin.com/n10iRMFr code for hep wrath fix 04:38:15 CanOfWorms: OK, I'll let pleasingfungus know. 04:40:45 -!- Blazinghand has quit [Quit: Leaving] 04:50:12 -!- muravey has joined ##crawl-dev 04:50:30 -!- mibert has quit [Ping timeout: 258 seconds] 04:51:18 set your git user and email, then make a commit in a branch 04:51:22 then you can easilly make a patch to share 04:51:39 ha ha ha I'm not touching that with a 10 foot pole 04:51:41 not many extra steps and it will make sharing your work vastly easier 04:52:58 git config user.name "Weird Artist" then git config user.email "weirdguy@worms.com" 04:53:08 two commands, and look, you're like half way there 04:55:13 // update temporary mutations 04:55:17 static void _handle_temp_mutation(int exp) 04:55:19 w h y 04:56:10 * CanOfWorms shrugs 04:56:28 call it _update_temp_mutations() 04:56:35