00:00:03 -!- omarax has quit [Remote host closed the connection] 00:00:08 if (foe == nullptr) { return or something w/e } 00:00:17 -!- qguv has quit [Quit: bye] 00:00:35 calling methods of null objects is... either undefined or a crash 00:01:02 Brannock: monsters/actors pointers to null means that there's no monster/actor there, this can happen for any function taking an argument of monster * or actor * 00:01:11 Should that be fixed for the thorn hunter code as well then? 00:01:13 possibly! 00:01:16 i'd need to see the function 00:01:23 oh 00:01:25 no it does check 00:01:28 if (foe && ....) 00:01:31 on the line after 00:01:35 nullptr is falsy 00:01:43 specifically it's literally the value zero 00:02:50 so if foe is nullptr, that condition will be false 00:04:57 -!- ezyan has quit [Ping timeout: 250 seconds] 00:06:49 PleasingFungus: after you said no a hundred times we invited Kramin 00:06:49 amalloy: You have 1 message. Use !messages to read it. 00:07:01 lol 00:07:04 -!- lobf has quit [Ping timeout: 258 seconds] 00:07:32 that was the message that persuaded me to join - i wasn't clear whether that was settled 00:07:32 does this line of code work the way I think it should? 00:07:37 message = "The dream sheep ruffle%s and sparkling dust floats away.", n == 1 ? "s its wool" : "their wool"; 00:07:45 I'm thinking.. probably not 00:07:52 PleasingFungus: it's signed in blood now 00:08:21 you want that to be inside a make_stringf 00:08:23 amalloy: !!! 00:08:26 Thank you 00:08:32 but he might welcome the opportunity to leave, and help fill out other teams who can't find a third; you can talk to him about it if you are keen to take over 00:09:48 I'm going to talk so much smack about the dieselrobin dev team in my streams that week 00:09:59 -!- lobf has joined ##crawl-dev 00:09:59 have some bot commands that spit out really good insult memes 00:10:04 i don't feel strongly. 00:10:11 kramin is, notionally, in this channel. 00:11:06 indeed 00:11:33 I mean if you really want to have a dev only team, I might be able to find another team 00:11:45 -!- magistern has quit [Quit: magistern] 00:11:47 i'm not gonna kick you off if you got nowhere to go 00:11:51 that'd be messed up. 00:12:04 I'll see what chequers is doing 00:12:22 if I can join an team of cpo players then you can go on amalloy's 00:12:33 ok. absolutely no pressure. 00:13:50 yup 00:18:29 PleasingFungus, what's your opinion: should dream sheep sleep power be adjusted based on herd size for MR check, or should only the *effect* be increased if the base power (equal if there's 3 or 9 dream sheep) passes MR? 00:19:19 whats a dream sheep 00:19:24 new creature I'm attempting to code 00:19:36 think starcursed masses, but their shrieks don't damage you, and they sleep you instead of paralyze you 00:19:40 sounds cruel and unusual 00:20:19 -!- grisha5 has quit [Quit: Page closed] 00:21:41 Natasha Message 13https://crawl.develz.org/mantis/view.php?id=10598 by grisha5 00:25:14 does it need to involve mr at all? 00:25:29 -!- valrus has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 00:26:10 hmm. they're magical creatures, so maybe. the dream dust is an enchantment effect. I think this is reaching into a flavor justification though 00:26:27 sleep is usually a mr-resisted effect, but so's para. 00:26:31 yeah, checking MR or not is more a gameplay concern than a flavor one 00:26:48 most characters won't have high MR by lair. would it be clear to players that wearing a ring of magic resistance does not help against dream sheep? 00:26:48 currently it's just basalisks who check your mr in lair? is this a lair creature? 00:26:53 yes, mid to late lair 00:27:44 I think being able to prevent small numbers with mr sounds nice 00:28:01 so power scaling with number of sheep? 00:28:21 I like that way 00:29:07 as of right now, effect scales. 1-2 sheep no sleep, 3-5 sheep, 1-power sleep, 6+ sheep, 2-power sleep. 00:29:09 numbers pending 00:30:18 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.19-a0-1091-g463c9de (34) 00:30:35 I suppose if it does become a problem (and if it's implemented in the first place!) I can always go back and add in a MR check 00:30:44 probably more important right now to finish pushing commits and start testing 00:31:44 MR exists for a reason, right? better to have these things check mr by default and not checking mr is a special case if you find a good reason why it shouldn't? 00:31:56 harder to balance mr 00:32:15 i don't think it's a clear-cut case one way or the other 00:35:11 -!- nikheizen has joined ##crawl-dev 00:36:20 I wish we just referred to this guy by his real name instead of calling him mister all the time 00:36:39 it's hard to resist! 00:39:03 get more MR! 00:40:48 -!- Zeor has quit [Quit: Leaving.] 00:45:32 -!- ProzacElf has joined ##crawl-dev 00:48:43 hm 00:48:52 gammafunk: can you look at 10589? it seems odd 00:49:02 !bug 10589 00:49:02 https://crawl.develz.org/mantis/view.php?id=10589 00:49:03 i know brannock compiled without issues, though i guess he wasn't under cygwin... 00:49:16 oh, i see, this is very cygwin specific 00:49:39 I am compiling right now with msys2, in fact! 00:49:40 wow, that patch 00:50:00 hrm, yeah this seems to imply that cygwin has changed recently 00:50:17 maybe so that we no longer need that workaround 00:50:26 there was a discussion yesterday about the amount of 'thrash' in cygwin 00:50:46 well that was actually talking about msys2, not cygwin 00:51:04 Ah, right, I remember now 00:51:05 but it was talking about what "we" recommended for compiling crawl on windows 00:51:16 which has indeed changed a bit over time 00:51:37 I can try this with a recent cygwin, I'm not familiar which how cygwin releases 00:52:09 !tell |amethyst 10589 seems to imply that maybe the cygwin std:to_string workaround is not needed in recent Cygwin? 00:52:10 gammafunk: OK, I'll let |amethyst know. 00:53:17 -!- Pacra has quit [Read error: Connection reset by peer] 00:53:27 -!- Pacra has joined ##crawl-dev 00:59:55 -!- debo_ has joined ##crawl-dev 01:00:03 -!- omarax has quit [Remote host closed the connection] 01:00:19 -!- debo_ is now known as Guest67699 01:04:37 -!- Guest67699 has quit [Ping timeout: 258 seconds] 01:12:33 -!- squidcat has quit [Ping timeout: 250 seconds] 01:13:33 Hmm, that's a compile error I don't understand. It threw loads of warnings at me over 'actor *foe = mons->get_foe();', saying that all subsequent instances of that in mon-abil.cc "crossed initialization of 'actor* foe'". Apparently my addition to dream sheep is a shadowed declaration. 01:17:35 sounds like 'foe' is already defined in that scope 01:17:36 give me a diff 01:19:50 Unstable branch on crawl.develz.org updated to: 0.19-a0-1091-g463c9de (34) 01:21:42 I've made a few commits to my branch editing mon-abil.cc; git diff only returns the diff for my latest commit. How do I get a diff between the master version of the file and my version of mon-abil.cc? 01:22:45 git diff origin/master is one way 01:22:48 Oh, hang on, it's probably doable through github web interface 01:22:56 possibly git diff origin/master mon-abil.cc 01:23:10 !add removed distortion daggers 01:23:12 03Kramin ⛐ 0.19-a0-732-g0347705: Add removed distortion daggers 10(in the future, 26 files, 245+ 618-) 13http://s-z.org/neil/git/commit.png?p=crawl.git;a=commitdiff;h=0347705 01:23:42 Brannock: yeah git diff 01:23:56 or just git diff to see differences for all paths 01:25:04 https://github.com/crawl/crawl/compare/master...isloat:dream-sheep#diff-a4dfa7884fb2bb04f338151d99b5636d This should work as well 01:25:05 I am become dev, destroyer of souls 01:25:18 !remove added distortion daggers 01:25:19 03gammafunk ⛐ 0.19-a0-733-gdc2e9a1: Remove added distortion daggers 10(in the future, 36 files, 651+ 568-) 13http://s-z.org/neil/git/commit.png?p=crawl.git;a=commitdiff;h=dc2e9a1 01:25:26 dev priveleges revoked 01:25:39 _will_dream_sheep_sleep 01:25:40 *privileges 01:25:47 this is a tongue-twister if i've ever seen one. 01:26:10 Haha 01:26:21 what would a sleep sheep sleep if a sheep could sleep sheep? 01:26:25 looking at lines 1243-1255, i don't understand what you're doing 01:26:28 you get the monster's foe 01:26:42 and then check to see if the foe can be put to sleep 01:27:01 but you're also checking "beem.target" for sanctuary and for the actual parameter passed to dream_sheep_sleep? 01:27:06 instead of foe 01:27:17 what is beem? do you know? 01:27:27 beem? 01:27:29 similar code to case MONS_STARCURSED_MASS above 01:27:32 gamma's bot 01:27:40 Oh, huhs. 01:27:43 *hush 01:27:57 !source mon-abil.cc 01:27:57 https://github.com/crawl/crawl/blob/master/crawl-ref/source/mon-abil.cc 01:28:20 If the sheep isn't confused, and the target is in a valid position (ie, not in a sanctuary), and the target is vulnerable to sleep, and it passes a coinflip, call the function that triggers the sleep ability 01:28:44 ahh, beem.target is set to foe.pos() earlier 01:28:50 in mon-act 01:29:01 anyway, there's no reason to call actor_at ther 01:29:03 *there 01:29:07 it's very roundabout and backwards 01:29:19 just use foe, since that's either going to be the same thing, or there's a bug 01:29:30 -!- dtsund has quit [Remote host closed the connection] 01:29:36 anyway that's not the compiler error, so let me scroll up. 01:29:53 what line is the error on? 01:30:00 what line in mon-abil.cc 01:30:01 PleasingFungus: looks like my tavern legacy is going to be "the guy who made a fake nude mod" 01:30:01 1244 01:30:11 oh dear 01:30:13 i see it 01:30:34 you need to put a set of opening braces after "case MONS_DREAM_SHEEP: ", and close them after the break; 01:30:36 { } 01:30:41 Oh wow 01:30:47 like with thorn hunter 01:30:58 though ironically i think thorn hunter doesn't have to 01:31:02 starcursed mass doesn't have them either 01:31:05 yes 01:31:23 after or before the break? 01:31:24 that is because it doesn't need 01:31:28 thorn hunter puts it before the break 01:31:30 doesn't matter 01:31:40 i should probably explain what you're doing here 01:32:05 it's a good idea to brace everything if you are a beginner; |amethyst will fix it later anyhow :) 01:32:11 indeed 01:32:29 would be nice if util/unbrace worked on windows 01:32:31 maybe it does 01:32:33 who knows 01:33:33 basically: you can't declare variables inside a switch/case statement unless they're inside braces. that's the short version. the long version goes into the technical details of how switch/case works 01:33:53 you'll notice that the starcursed mass case doesn't declare any variables 01:34:16 And thorn hunter variables are all nested inside its if clauses 01:34:43 yeah 01:34:47 also the thing i said just now is a lie 01:34:57 XOM chuckles. 01:35:04 you can actually declare a variable without braces, but it can't be the first line after the case statement 01:35:54 I changed actor_at(beem.target). Should is_sanctuary(beem_target) also be changed to is_sanctuary(foe)? And what's the problem with beem.target for being roundabout? 01:36:13 it would have to be foe->pos() 01:36:26 it just seems silly to end up doing this dance 01:36:57 actor_at(beem.target) is the same as actor_at(mon->foe->pos()), which, of course, is mon->foe 01:37:04 it's not a big deal 01:37:52 just bothered me, possibly because i'm tired 01:37:54 -!- Pacra has quit [Ping timeout: 250 seconds] 01:39:52 the n > 5 message is very verbose 01:40:42 -!- omnirizon has quit [Ping timeout: 265 seconds] 01:43:31 Removed second sentence from that 01:45:59 -!- Poncheis has quit [Client Quit] 01:46:28 ??ontocrawl 01:46:29 ontocrawl[1/1]: 1/2 level area; ~2x cost of skills over 10, ~4x cost over 20; 1/2 item gen in every branch but D, zero item gen in extended, don't gen "popcorn" monsters anywhere ever 01:47:11 i don't remember why i put the skill cost thing in there 01:47:28 the ash buff 01:47:57 mmm 01:48:47 ontoclasm, are there any unique corpse tiles, or are all corpse tiles just squashed versions of regular montiles? 01:48:47 oka buff, clearly 01:49:06 aside from skelefication 01:49:32 Brannock: the latter 01:49:37 corpse tiles are autogenerated 01:52:54 -!- packet_loss has joined ##crawl-dev 01:53:24 -!- magistern has quit [Quit: magistern] 01:54:49 -!- nikheizen has quit [Quit: leaving] 01:56:01 Windows builds of master branch on crawl.develz.org updated to: 0.19-a0-1091-g463c9de 01:56:20 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]] 01:57:29 -!- packet_loss has quit [Ping timeout: 252 seconds] 02:00:04 -!- omarax has quit [Remote host closed the connection] 02:00:05 -!- zxc has joined ##crawl-dev 02:03:15 -!- aditya has joined ##crawl-dev 02:06:43 -!- squidcat has quit [Ping timeout: 250 seconds] 02:07:39 -!- destroythecore has quit [Read error: Connection reset by peer] 02:08:49 ontoclasm grows pet monsters himself, tends them lovingly, then kills them when they come of age, so he can take a picture to make accurate corpse tiles 02:10:43 I think I've attempted to compile my branch like a dozen times and discovered a missing enum declaration each time. 02:10:55 I'm glad I decided to start writing monster_creation checklist yesterday. 02:14:25 -!- bonghitz has quit [Remote host closed the connection] 02:21:33 -!- simmarine has quit [Read error: Connection reset by peer] 02:26:59 -!- Zekka_ has quit [Read error: Connection reset by peer] 02:27:03 gammafunk: actually the "blood" is just ketchup 02:27:13 no monsters were harmed in the making of crawl tiles 02:35:18 IT COMPILES! 02:35:20 IT WORKS! 02:35:22 MY CREATION LIVES! 02:40:37 compiles = perfect code 02:40:48 several bugs already :o 02:41:00 at least it doesn't crash the game or break the compile 02:41:13 and the sleepcursed_mass effect actually works 02:41:23 funny that the most complicated part of them works properly 02:44:35 Man. This is so basic but so cool to actually see something I wrote (read: stolen and edited code) working 02:46:01 just wait til you see the tvs of players dying to dream sheep 02:46:10 maximum euphoria 02:46:23 can't wait until it's merged 02:46:28 -!- aditya has quit [Ping timeout: 276 seconds] 02:46:33 ...then I can r e m o v e it 02:46:44 ??gammafunk 02:46:44 gammafunk[1/5]: Crawl dev. See {gammafunkrc} and http://twitch.tv/gammafunk 02:46:55 yeah right caustic shrikes are still in 02:47:03 that entry is full of lies, don't believe it 02:47:13 ??gammafunk[2 02:47:13 gammafunk[2/5]: Expose you.attack_delay and autopickup menu options in lua 02:47:23 I honestly don't expect dream sheep to last very long 02:47:35 but ever since PleasingFungus mentioned sheepcursed masses a couple years ago the idea has stuck in my head 02:47:43 so I wanted to actually go and implement them 02:48:33 leave a door open for deep dream sheep 02:48:45 coma sheep? 02:48:53 dream sheep for Lair, checks MR. coma sheep for Depths, ignores MR? 02:49:19 -!- aditya has joined ##crawl-dev 02:49:33 initial testing shows that either I need to adjust cast rate way down or to add in a MR check 02:50:57 -!- MaxFrost has quit [Quit: Going offline, see ya! (www.adiirc.com)] 02:53:56 Monster database of master branch on crawl.develz.org updated to: 0.19-a0-1091-g463c9de 02:59:38 -!- Patashu has quit [Ping timeout: 252 seconds] 03:00:04 -!- omarax has quit [Remote host closed the connection] 03:04:20 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 03:18:53 -!- aditya has quit [Ping timeout: 252 seconds] 03:19:56 -!- Dracunos has quit [Ping timeout: 258 seconds] 03:20:17 -!- bonghitz has quit [Ping timeout: 264 seconds] 03:24:03 Unstable branch on crawl.beRotato.org updated to: 0.19-a0-1091-g463c9de (34) 03:28:44 -!- kdrnic has quit [Quit: Leaving] 03:29:52 what do dream sheep do exactly 03:35:03 -!- mibe has quit [Quit: Page closed] 03:37:59 if there's a lot of them, they try to put you to sleep 03:40:19 that effect may actually be too nasty for lair, I'm finding out 03:40:47 but it's late, so I'm going to go count sheep in bed until I fall asleep 03:42:35 -!- lobf has quit [Ping timeout: 240 seconds] 03:43:36 -!- vede has quit [Quit: Lost terminal] 03:44:41 -!- aditya has joined ##crawl-dev 03:46:10 -!- lobf has joined ##crawl-dev 03:52:47 -!- VoxSomniator has quit [Quit: Leaving] 03:53:42 -!- packet_loss has joined ##crawl-dev 03:57:52 -!- Ququman has joined ##crawl-dev 03:57:56 -!- PElf has joined ##crawl-dev 03:58:05 -!- packet_loss has quit [Ping timeout: 240 seconds] 03:58:51 -!- ProzacElf has quit [Ping timeout: 244 seconds] 04:00:03 -!- omarax has quit [Remote host closed the connection] 04:10:15 -!- GauHelldragon has quit [Ping timeout: 250 seconds] 04:19:21 -!- hellmonk has quit [Quit: Page closed] 04:24:50 -!- sysice has quit [Quit: Page closed] 04:26:45 -!- cait has quit [Ping timeout: 244 seconds] 04:54:49 -!- ontoclasm has quit [Quit: Leaving.] 05:00:04 -!- omarax has quit [Remote host closed the connection] 05:22:26 -!- MaBunny is now known as OtakuSenpai 05:22:35 -!- lobf has quit [Quit: lobf] 05:42:32 -!- Bcadren has quit [Ping timeout: 258 seconds] 05:44:45 -!- PElf has quit [Quit: HydraIRC -> http://www.hydrairc.com <- \o/] 05:48:35 -!- } has quit [Ping timeout: 240 seconds] 05:54:53 -!- packet_loss has joined ##crawl-dev 05:59:11 -!- packet_loss has quit [Ping timeout: 244 seconds] 06:00:02 -!- omarax has quit [Remote host closed the connection] 06:04:05 -!- ac13 has quit [Read error: Connection reset by peer] 06:22:05 -!- Patashu has joined ##crawl-dev 06:26:17 -!- valrus has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 06:26:30 -!- Shard1697 has joined ##crawl-dev 06:33:50 -!- edsrzf has quit [Ping timeout: 250 seconds] 06:38:15 -!- vede has quit [Ping timeout: 264 seconds] 06:41:58 -!- Tux[Qyou] has joined ##crawl-dev 06:43:50 -!- vede has quit [Ping timeout: 258 seconds] 06:44:15 .suspensetv 06:44:21 fuck 06:44:24 -!- doll has left ##crawl-dev 06:44:51 -!- aditya has quit [Ping timeout: 264 seconds] 06:46:03 suspensetv requested for FooTV (telnet://termcast.develz.org or http://termcast.develz.org ). 06:48:21 -!- jefus- has joined ##crawl-dev 06:48:40 !tell pleasingfungus the messaging for 'spell books have been filtered' in x-v is a bit confusing when the monster's filtered list is only one spellbook long 06:48:41 chequers: OK, I'll let pleasingfungus know. 06:52:24 -!- jeefus has quit [Ping timeout: 260 seconds] 07:00:02 -!- omarax has quit [Remote host closed the connection] 07:16:33 -!- sgun_ has quit [Ping timeout: 250 seconds] 07:20:34 -!- Kenran has quit [Quit: leaving] 07:27:37 -!- panicbit has quit [Ping timeout: 260 seconds] 07:47:25 -!- Zxpr2jk has quit [Ping timeout: 250 seconds] 07:51:03 -!- Zekka has quit [Ping timeout: 240 seconds] 07:55:27 -!- packet_loss has joined ##crawl-dev 07:58:06 -!- } has joined ##crawl-dev 07:58:34 -!- doll has quit [Quit: Lost terminal] 07:59:22 <}> :( The makefile in the master branch checks if "lua51" is present but 0.17 only checks for "lua-5.1" and "lua5.1" 07:59:54 * } throws lua51 at Makefile 08:00:02 -!- omarax has quit [Remote host closed the connection] 08:00:27 -!- packet_loss has quit [Ping timeout: 264 seconds] 08:00:52 -!- wheals has joined ##crawl-dev 08:02:53 <}> so I was thinking, wouldnt it be great if you could pass LUA_PACKAGE as an environment variable to the makefile so you can set it yourself in all versions 08:03:08 <}> because right now the makefile doesnt check if LUA_PACKAGE is set before trying to set it 08:04:54 <}> In other words if you have some weird system where pkg-config can only find "lua-5-1" instead of "lua5.1" or "lua-5.1" there's no way to pass that to make right now without editing the makefile 08:05:36 <}> !source Makefile:629 08:05:37 https://github.com/crawl/crawl/blob/master/crawl-ref/source/Makefile#L629 08:05:51 <}> you would have to add ifndef LUA_PACKAGE there, so if you already set it, it skips that part 08:06:57 <}> unless im missing some crucial part here 08:13:55 -!- syllogism has joined ##crawl-dev 08:15:01 -!- mattitk has quit [Ping timeout: 258 seconds] 08:17:35 <|amethyst> probably you could wrap that whole ifndef BUILD_LUA inside ifndef LUA_PACKAGE 08:17:35 |amethyst: You have 1 message. Use !messages to read it. 08:17:49 -!- simmarine has joined ##crawl-dev 08:17:50 <}> |amethyst, yes thats what I meant 08:17:58 <}> by adding ifndef LUA_PACKAGE 08:18:18 <}> i think its great for the weirder systems like mine where pkg-config can trip 08:18:49 <}> especially considering it does trip if I do a git checkout 0.17.0 or older versions 08:19:05 <|amethyst> not much we can do about that 08:19:18 <|amethyst> since 0.17.0 would still have the older makefile 08:19:33 <}> yes but for future versions it would solve the problem for people so they dont need to edit makefile 08:19:35 <|amethyst> could release an 0.17.3 08:19:41 <}> it's just future proofing and making everything more robust 08:20:18 <}> and considering all you need to do is add 2 lines that seems like a good deal 08:20:43 <|amethyst> yes, I'm wondering why you haven't submitted a PR yet :) 08:20:53 <|amethyst> but I can do it 08:20:57 <}> on mantis? 08:21:06 <}> I guess its simple enough that you wouldnt want to bother with a request 08:21:09 <|amethyst> on github, or a bug report and patch on mantis 08:21:18 <}> but sure I can do it 08:21:25 <|amethyst> don't worry about it now, I'm on it 08:21:28 <}> yay 08:21:45 -!- sgun__ has quit [Quit: Leaving] 08:21:47 <|amethyst> but applying a PR from github is even easier than changing two lines of code ourselves :) 08:21:55 <}> ok I'll keep that in mind for next time 08:21:59 -!- OtakuSenpai has quit [Ping timeout: 250 seconds] 08:24:40 -!- mattitk has quit [Ping timeout: 258 seconds] 08:33:12 <|amethyst> !tell gammafunk looks like it, but how to identify whether that's needed? 08:33:12 |amethyst: OK, I'll let gammafunk know. 08:33:33 <|amethyst> !tell gammafunk I guess we can add something to util/configure 08:33:33 |amethyst: OK, I'll let gammafunk know. 08:35:43 <|amethyst> cool, the hyperrogue 9.0 release notes contain a shout out to amalloy 08:38:28 -!- Tiltorax has quit [Quit: Page closed] 08:40:19 -!- Bammboo has quit [Quit: AndroIRC - Android IRC Client ( http://www.androirc.com )] 08:43:47 -!- amalloy is now known as amalloy_ 08:50:02 03|amethyst02 07* 0.19-a0-1092-g52934d3: Allow specifying the Lua package name (bsdbeard) 10(21 minutes ago, 1 file, 24+ 20-) 13https://github.com/crawl/crawl/commit/52934d3359ce 09:00:02 -!- omarax has quit [Remote host closed the connection] 09:08:56 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1092-g52934d3 (34) 09:19:56 -!- Jafet has quit [Quit: Jafet] 09:20:55 -!- mamgar has quit [Client Quit] 09:27:25 -!- bitcoinbastard has quit [Ping timeout: 244 seconds] 09:28:36 -!- miserium has joined ##crawl-dev 09:38:27 -!- magistern has quit [Quit: magistern] 09:44:55 -!- bonghitz has quit [Remote host closed the connection] 09:48:08 -!- Kalir has quit [Changing host] 09:48:41 -!- magistern has quit [Quit: magistern] 09:49:13 hey gang - just a heads up, a commit yesterday has now caused the nightly android build to fail. I'm getting ready to head out the door but figured I'd post the relevant part of the build that failed: http://pastebin.com/DsMvNczd 09:49:56 I'll leave my IRC open but I'll be afk; I'll check in when I get home later 09:50:15 -!- Doesnty has quit [Ping timeout: 276 seconds] 09:54:28 03|amethyst02 07* 0.19-a0-1093-g289af91: Add missing CRs in crawl.vcxproj. 10(34 seconds ago, 1 file, 3+ 3-) 13https://github.com/crawl/crawl/commit/289af9175aec 09:54:28 03|amethyst02 07* 0.19-a0-1094-gb519beb: Add nearby-danger.cc to MSVC and Android builds (miserium) 10(17 seconds ago, 2 files, 2+ 0-) 13https://github.com/crawl/crawl/commit/b519bebee1ae 09:54:34 -!- Patashu has quit [Ping timeout: 240 seconds] 09:54:35 <|amethyst> miserium: fixed, thanks 09:56:19 -!- packet_loss has joined ##crawl-dev 10:00:02 -!- omarax has quit [Remote host closed the connection] 10:01:18 -!- packet_loss has quit [Ping timeout: 276 seconds] 10:08:53 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1094-gb519beb (34) 10:09:10 -!- doll has quit [Quit: Lost terminal] 10:12:26 -!- Nomi has quit [Read error: Connection reset by peer] 10:30:18 -!- cait has quit [Quit: ChatZilla 0.9.92 [Firefox 49.0/20160802125918]] 10:39:11 -!- Patashu has joined ##crawl-dev 10:45:04 -!- Patashu has quit [Ping timeout: 240 seconds] 10:49:04 -!- Shard1697_ has joined ##crawl-dev 10:49:24 -!- Shard1697 has quit [Ping timeout: 276 seconds] 10:49:52 -!- bonghitz has quit [Ping timeout: 240 seconds] 10:56:25 -!- JoeMaro has quit [Read error: Connection reset by peer] 10:57:51 -!- Klaymen has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]] 11:00:02 -!- omarax has quit [Remote host closed the connection] 11:02:13 -!- debo_ has joined ##crawl-dev 11:02:36 -!- debo_ is now known as Guest4177 11:05:03 -!- debo has quit [Ping timeout: 244 seconds] 11:10:32 -!- valrus_ has quit [Ping timeout: 265 seconds] 11:14:27 -!- JoeMaro has quit [Read error: Connection reset by peer] 11:18:26 -!- Kellhus has quit [Quit: Page closed] 11:20:15 -!- magistern has quit [Read error: Connection reset by peer] 11:20:24 -!- wheals has quit [Ping timeout: 244 seconds] 11:28:24 -!- Shard1697_ has quit [Ping timeout: 276 seconds] 11:28:42 -!- } has quit [] 11:31:20 -!- magistern has quit [Quit: magistern] 11:42:28 -!- magistern has quit [Ping timeout: 258 seconds] 11:43:41 -!- _dhm has quit [Ping timeout: 250 seconds] 11:56:18 -!- wheals has joined ##crawl-dev 11:57:17 -!- packet_loss has joined ##crawl-dev 12:00:02 -!- omarax has quit [Remote host closed the connection] 12:00:16 -!- johlstei_ has joined ##crawl-dev 12:02:16 -!- packet_loss has quit [Ping timeout: 264 seconds] 12:02:24 -!- mattitk has quit [Ping timeout: 258 seconds] 12:03:19 -!- johlstei has quit [Ping timeout: 260 seconds] 12:05:30 -!- valrus_ has quit [Ping timeout: 244 seconds] 12:10:31 -!- JoeMaro has quit [Read error: Connection reset by peer] 12:11:52 -!- magistern has quit [Ping timeout: 264 seconds] 12:12:39 -!- Shard1697 has joined ##crawl-dev 12:13:05 -!- _dhm has quit [Ping timeout: 258 seconds] 12:14:59 -!- PleasingFungus has joined ##crawl-dev 12:16:15 when your shadow mimicks your spell, does whether it does "shadow shard" or "shadow bolt" affect its damage? 12:17:35 <|amethyst> it does not 12:18:03 |amethyst: sry for the build messiness 12:18:04 PleasingFungus: You have 1 message. Use !messages to read it. 12:18:07 <|amethyst> the only differences are beam.name and beam.pierce 12:18:10 <|amethyst> no worries 12:18:13 -!- Zekka has quit [Read error: Connection reset by peer] 12:18:24 ok, juuust checking 12:18:37 man, i respect the h*ck out of this cyc guy's spell naming style 12:18:43 Olgreb's Toxic Overdrive (Poison/Charms 5) 12:19:04 tell me that doesn't sound like a spell you want to cast 12:21:22 -!- sjl has quit [Ping timeout: 244 seconds] 12:26:01 -!- ontoclasm has joined ##crawl-dev 12:26:30 -!- JoeMaro has quit [Read error: Connection reset by peer] 12:31:29 -!- destroythecore has quit [Read error: Connection reset by peer] 12:32:27 -!- rossi has quit [Ping timeout: 250 seconds] 12:34:45 -!- MarvinPA has joined ##crawl-dev 12:38:33 -!- Tux[Qyou] has quit [Ping timeout: 250 seconds] 12:39:23 -!- cait has quit [Ping timeout: 250 seconds] 12:44:08 03PleasingFungus02 07* 0.19-a0-1095-g342353f: Rewrite fixup_stone_stairs 10(20 hours ago, 1 file, 230+ 170-) 13https://github.com/crawl/crawl/commit/342353f40036 12:47:11 -!- JoeMaro has quit [Quit: Leaving] 12:49:47 -!- magistern has quit [Quit: magistern] 12:54:28 Can someone explain to me what the point of the special tag for the InventoryTile class is, especially with regards to MemoriseRegion? 12:54:42 For spells it is set to the book id I guess, but I don't see that used anywhere in the interface 12:54:56 !source InventoryTile 12:54:56 1/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/tilereg-grid.cc#L12 12:56:19 looks unused. try removing it and see what breaks 12:57:35 Cool 13:00:03 -!- omarax has quit [Remote host closed the connection] 13:07:22 -!- _dhm has quit [Ping timeout: 252 seconds] 13:08:51 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1095-g342353f (34) 13:11:46 -!- Zxpr1jk has quit [Quit: Leaving] 13:13:09 -!- lobf has joined ##crawl-dev 13:17:06 -!- Shard1697 has quit [Ping timeout: 258 seconds] 13:19:27 -!- magistern has quit [Quit: magistern] 13:26:13 Unstable branch on crawl.akrasiac.org updated to: 0.19-a0-1095-g342353f (34) 13:29:54 -!- jefus has joined ##crawl-dev 13:30:37 03PleasingFungus02 07* 0.19-a0-1096-g8280678: Let Ash ID rods again (Arrhythmia) 10(61 seconds ago, 1 file, 5+ 5-) 13https://github.com/crawl/crawl/commit/82806789e809 13:30:49 -!- bonghitz has quit [Remote host closed the connection] 13:32:52 -!- jefus- has quit [Ping timeout: 264 seconds] 13:33:12 -!- } has quit [Ping timeout: 276 seconds] 13:34:30 -!- Dracunos has quit [Ping timeout: 276 seconds] 13:35:09 -!- } has quit [Client Quit] 13:35:27 -!- kdrnic has joined ##crawl-dev 13:35:55 -!- Dracunos7 has quit [Ping timeout: 244 seconds] 13:38:12 -!- Vektorweg1 has quit [Ping timeout: 240 seconds] 13:39:18 -!- Vektorweg1 has joined ##crawl-dev 13:41:19 -!- cait has quit [Ping timeout: 260 seconds] 13:44:04 -!- ontoclasm has quit [Quit: Leaving.] 13:47:59 -!- amalloy_ is now known as amalloy 13:49:17 -!- MarvinPA has quit [Read error: Connection reset by peer] 13:54:46 !messages 13:54:47 No messages for TZer0. 13:58:06 -!- packet_loss has joined ##crawl-dev 14:00:00 -!- elliptic has joined ##crawl-dev 14:00:03 -!- omarax has quit [Remote host closed the connection] 14:01:02 !seen lasty 14:01:02 I last saw Lasty at Thu Aug 4 11:36:33 2016 UTC (3d 6h 24m 21s ago) quitting, saying 'Ping timeout: 240 seconds'. 14:01:02 <|amethyst> xormask: looks like it's used in tilereg-inv.cc m_buf.add_main_tile(item.special, x, y, 0, 0); 14:01:19 <|amethyst> xormask: and it's set by desc.special = tileidx_known_brand(item); or desc.special = tileidx_corpse_brand(item); 14:01:29 |amethyst yeah I saw that, but I don't think it is used for spells 14:01:35 in MemoriseRegion 14:01:43 <|amethyst> xormask: yeah 14:02:24 <|amethyst> it's used only for weapons, armour, missiles, rods, and corpses 14:02:35 -!- packet_loss has quit [Ping timeout: 250 seconds] 14:03:13 <|amethyst> Hm 14:03:18 |amethyst not setting the special tag for books lets you simplify a lot of things, because the spell to book relationship doesn't need to be passed out in the relationship 14:03:54 It sort of seems like InventoryTile shouldn't be used for MemoriseRegion, but whatever 14:05:24 -!- cait has quit [Ping timeout: 244 seconds] 14:05:27 sorry the above message should have been *doesn't need to be passed out in the api 14:06:26 -!- lobf has quit [Quit: lobf] 14:06:36 Also is there some standard for unordered_set vs set? 14:08:55 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1096-g8280678 (34) 14:09:31 presumably depends on whether a consistent iteration order is important 14:09:50 <|amethyst> we only use unordered_set in a few places currently, because we only started using C++11 relatively recently 14:10:12 Ok I just wanted to be sure there wasn't some internal coding style thing and not just for function 14:12:07 coding style... 14:12:27 D: 14:15:55 interesting and bad. hiding a file in Windows Explorer prevents msys2 from opening it. 14:16:09 All I wanted was to not have to repeatedly scroll past .d and .o files 14:17:00 -!- Pacra has joined ##crawl-dev 14:17:59 Use linux! 14:18:09 I eventually probably will 14:20:48 use os2/warp 14:22:30 I got my branch to successfully compile last night. immediately discovered several bugs during testing 14:23:32 1. screen flash/force-more only pops about half to 3/4 of the time when sleeped. 2. Summon Dream Sheep isn't actually working. (in process of fixing this.) 3. not a bug, but sleep is *nasty* and I'm in the process of nerfing how often they can use it and will probably have to add a MR check. 14:24:39 What will Summon Dream Sheep do Brannock? Sounds funny 14:24:59 dream sheep will summon more dream sheep as an emergency spell 14:25:13 when there are more than a certain number of dream sheep they will attempt to put the player to sleep 14:28:28 -!- eki has quit [Quit: leaving] 14:29:02 Dammit I still can't get Summon Dream Sheep to show up on xv and this probably means they won't actually cast it either. Not sure what I did wrong 14:29:47 Brannock: do you know how to make a patch? 14:29:49 gammafunk: You have 3 messages. Use !messages to read them. 14:29:55 Not yet I do not 14:30:06 Looks like force-more/screen flash doesn't work if you fall asleep but wake up before your next turn would have happened 14:30:09 for the last time Sequell, I do not need male enhancement pills! 14:30:23 Also, interesting: riposte works even if you're asleep. 14:31:02 git format-patch --stdout origin/master > master.patch 14:31:39 sleep disables surprisingly few things 14:31:50 Thank you. What's the purpose/function for making a patch vs. a pull request or commit? 14:31:51 you can dodge while asleep (hence riposte) 14:32:08 i tried to fix this once, but failed 14:32:17 Brannock: patch is a text file you can pastebin/share 14:32:30 certainly you could put your work into a PR as well 14:33:49 I also like to just look at a patch file of all commits I'm about to push to sanity check and spellcheck the messages/contents 14:34:19 but people have different routines they do 14:34:47 Thank you, I'll note that down for when this is ready to be PR'd 14:35:01 well, I mentioned that so you can share your code 14:35:08 in terms of debugging that problem 14:35:16 https://github.com/crawl/crawl/compare/master...isloat:dream-sheep#diff-d1c34e9aaccf962b6ce36db68889a68d This is the current diff of my branch. I'm stumped as to why Summon Dream Sheep isn't working or showing up on xv. I've compared it against a couple of other monster spells and I'm pretty sure I got everything... 14:35:26 But I clearly haven't 14:35:49 Lemme make a text patch file for easier reading, since Github is a bit spread out 14:36:15 oh, this one's easy 14:36:29 hm, nvm 14:36:41 gammafunk, do you prefer gist or pastebin? 14:36:53 or mantis? 14:36:57 no, this github diff is fine 14:37:05 it has a diff for all changes 14:37:16 ya 14:37:39 such a spooky tile... 14:37:47 i'd probably add some dprfs to find out where, exactly, the cast is failing 14:38:00 like, does it get into setup_mons_cast? does it get into mons_cast? 14:38:11 does it get into case spell_summon_dream_sheep in mons cast? 14:38:25 Oh, hang on, I haven't synced a couple commits from this morning 14:38:26 turning off the emergency flag might make testing simpler 14:38:45 It isn't showing up in xv at all, so somewhere it isn't even being read as a spell at all 14:39:02 Or maybe I didn't attribute it to dream sheep properly? 14:39:11 oh 14:39:13 yeah you didn't 14:39:17 + 3, 10, MST_NO_SPELLS, CE_CLEAN, S_BLEAT, 14:39:30 needs to be MST_DREAM_SHEEP 14:39:50 That'd do it. I copied the sheep code and forgot to go back and look at it again 14:40:54 What about the screen flash/force-more when sleeped? After a bunch of testing last night and today I'm guessing that there's no force-more if you wake up before you would have acted. 14:44:07 -!- simmarine has quit [Read error: Connection reset by peer] 14:45:24 ? 14:47:13 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 14:47:39 when you are sleeped, normally the screen flashes a color and there is a force-more to inform you that you are asleep. (aizul is the most common way players will encounter this.) with dream sheep, this occasionally does not happen. I realized that since they're all acting at the same time, there is a high likelihood that you will be attacked and awakened before your next turn would have happened. in this case, you do not get the 14:47:39 screen flash or force-more. 14:48:35 neat 14:48:39 sounds like a pre-existing bug 14:50:18 I'll mantis it today, then 14:51:03 I think that's everything I need to fix then, thank you PleasingFungus and gammafunk 14:51:07 Now to balance this thing 14:51:11 How do I check average XL of players who are at, say, Lair:6? 14:51:39 !lm * recentish lair:6 x=avg(xl) 14:52:01 90348 milestones for * (recentish lair:6): avg(xl)=15.44 14:52:22 I wonder if that works with MR. 14:52:23 !lm * recentish lair:6 x=avg(xl) urune=0 14:52:25 65470 milestones for * (recentish lair:6 urune=0): avg(xl)=13.8 14:52:27 !lm * recentish lair:6 x=avg(MR) 14:52:28 Cannot call avg(mr) (want (Type[ETD;seconds],Type[I])) 14:52:30 Nope! 14:52:36 !lm * recentish lair:6 urune>1 14:52:38 12975. [2016-08-07 18:34:22] jeffwins the Unseen (L27 OpFi of Dithmenos) killed Murray on turn 83361. (Lair:6) 14:52:43 lmao 14:52:47 Poor Murray 14:52:55 !lm * recentish lair:6 urune>1 -tv 14:52:56 12975. jeffwins, XL27 OpFi, T:83361 (milestone) requested for FooTV: telnet://termcast.develz.org or http://termcast.develz.org. 14:52:57 !lm * recentish lair:4 x=avg(xl) 14:53:06 -!- miserium has left ##crawl-dev 14:53:07 noo, cwz 14:53:22 anyway i'd use that urune=0 filter probably, otherwise you're gonna get skewed by weird shenangains 14:53:22 87795 milestones for * (recentish lair:4): avg(xl)=14.35 14:53:29 !lm * recentish lair:4 x=avg(xl) urune=0 14:53:30 68437 milestones for * (recentish lair:4 urune=0): avg(xl)=13.32 14:53:47 !lm * recentish lair:4 urune>0 14:53:48 19358. [2016-08-07 18:26:05] herpmino the Severer (L18 FoFi of Okawaru) left the Snake Pit on turn 14645. (Snake:1) 14:53:52 ahh 14:53:54 hm 14:54:02 Probably best to skew it a bit downwards anyway 14:54:04 well, it's all approximations 14:54:08 Especially since sleep is such a nasty effect 14:54:11 Level 10-13 14:54:34 !lg * recentish lair:4 14:54:35 6062. LordBacon the Fighter (L12 DsCK of Xom), mangled by a death yak on Lair:4 on 2016-08-07 18:24:21, with 20932 points after 14238 turns and 0:51:44. 14:54:39 !lg * recentish lair:4 x=avg(xl) 14:54:40 6062 games for * (recentish lair:4): avg(xl)=12.32 14:54:50 gonna skew a bit downward, since underleveled people are more likely to die 14:54:59 Since sleep is so strong, I don't think there's much need to make dream sheep that much tougher than regular sheep. They're very dangerous when accompanied by other monsters. 14:55:09 I'll adjust their monster stats back downwards. 14:55:13 is sleep really that bad 14:55:39 -!- _dhm has quit [Ping timeout: 250 seconds] 14:55:54 you're sleeping for between 3 to 8-10 turns, being hit when asleep is 2.5x damage (I think), and it basically means any awake monsters on screen are effectively teleported near you 14:55:57 urgh enums don't work as unordered_set keys, how annoying 14:56:11 Part of the problem right now is that dream sheep can sleep you repeatedly, which I'm also going to change 14:56:51 xormask: why not? 14:57:10 Also no MR check (yet), which means your only recourse is to quickly separate them under the threshold for sleep, or to kill as many as you can asap 14:57:23 PleasingFungus, defect in the c++11 standard apparently 14:57:31 baffling 14:57:41 Also spell_type is an enum :) 14:57:59 what is with the TAG_MAJOR_VERSION thing in the spell_type list 14:58:19 save compat 14:58:19 lots of #if TAG_MAJOR_VERSION == 34 14:58:42 So you can build a version for old saves? 14:58:54 so that the current version works for old saves 14:59:18 we build with TAG_MAJOR_VERSION set to 34 14:59:31 whenever we decide to break save compat, we'll increment to 35 and delete all the code in the ==34 ifdefs 14:59:36 Gotcha 15:00:03 -!- omarax has quit [Remote host closed the connection] 15:00:14 wizmode needs a way to alter player's MR values 15:00:18 <|amethyst> for more information, read docs/develop/save_compatibility.txt, expectially the section "Scheduling compatibility code for removal" 15:00:55 would be tricky to support 15:00:57 @ Brannock 15:01:00 that must rack up a ridiculous number of millimarvins 15:01:12 <|amethyst> s/expect/espec/ 15:01:27 you'd need, like, some wizmode-specific attribute that modifies MR? 15:01:29 atm it's either wait for Aizul to defeat my MR at high XL, or repeatedly refuse to die at low XL 15:01:37 to test sleep bug 15:01:54 <|amethyst> Brannock: you can read vulnerability to help 15:01:58 Ooh, good idea 15:02:11 can also mess around with fighting/armour skill at low xl 15:02:13 &S 15:02:17 maybe &A 15:04:46 <|amethyst> if you need to do more MR tweaking, you can make a randart with MR--- or whatever 15:05:06 Successfully reproduced the sleep bug with Aizul and jackals 15:05:18 It's titchy to reproduce though, a lot of things have to go right 15:05:30 -!- Vektorweg1 has quit [Quit: Leaving.] 15:05:46 edit mon-data to increase aizul's speed to 100 or w/e 15:05:59 then surround yourself with aizuls 15:06:00 <|amethyst> take an item you're not currently wearing, &+ to make it a randart, &tcL-3 then put it on 15:06:10 Wouldn't that require a re-compile? re: editing mon-data 15:06:10 -!- Vektorweg1 has joined ##crawl-dev 15:06:19 It takes me several minutes to compile because Windows is bad 15:06:31 <|amethyst> it should only have to recompile one file then relink 15:06:45 This is not my experience 15:06:53 It recompiles everything 15:07:14 <|amethyst> if you compile with the same options, and there aren't problems with your timestamps anyway 15:07:37 <|amethyst> most headers will require more extensive recompilation 15:07:46 <|amethyst> but mon-data.h is only used in mon-util.cc 15:07:54 Wait, if I close msys2, then reopen, will it have to recompile everything if I make again? 15:08:07 <|amethyst> it shouldn't have to, if you haven't changed anything 15:08:09 Hmm 15:08:23 <|amethyst> unless your compilation flags are changing each time 15:08:32 <|amethyst> or your system's timestamps are way wrong 15:10:46 <|amethyst> !learn s millimarvin[1] 16.798 net lines of code removed (as of 2016-08-07) 15:10:46 millimarvin[1/1]: 16.798 net lines of code removed (as of 2016-08-07) 15:11:24 <|amethyst> also congrats to PleasingFungus, author of the month for every month in 2016 so far 15:11:30