00:00:03 -!- omarax has quit [Remote host closed the connection] 00:01:03 -!- wob has quit [Quit: Page closed] 00:04:47 -!- Daekdroom has quit [Quit: Leaving] 00:05:53 -!- Kurshu has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 00:07:21 -!- kdrnic has quit [Quit: Leaving] 00:12:16 -!- Zymurgist has quit [Ping timeout: 276 seconds] 00:20:48 ??faerie dragon armour 00:20:48 faerie dragon armour[1/2]: A randart mottled dragon armour with fixed appearance, worn by the Enchantress. Has between -2 and +8 enchantment, can have some properties not allowed on other randarts. 00:20:55 is it still possible for this to have negative enchantment 00:20:59 great q 00:21:31 item_def doodad; 00:21:51 // On body armour, an enchantment of less than 0 is never viable. 00:21:53 item.plus = max(static_cast(random2(6) + random2(6) - 2), random2(2)); 00:22:05 I'm very curious about that cast 00:22:05 yeah but does fearie dragon enchantment get set later 00:22:19 that is faerie dragon armour specific code 00:22:26 the comment seems to have been copy-pasted 00:22:32 lol 00:22:45 <|amethyst> PleasingFungus: probably at one point the LHS did something that caused it to produce a long or unsigned 00:22:55 plausible 00:23:01 well 00:23:03 probably not unsigned 00:23:07 <|amethyst> and since max is templated to take anything, that would result in an ambiguous overload 00:23:16 <|amethyst> hm 00:23:21 <|amethyst> hm 00:23:27 i'll do some archaeology 00:23:31 since now i'm curious 00:23:33 <|amethyst> actually, maybe the RHS was an unsigned? 00:24:12 !learn e faerie_dragon_armour[1 s/-2/0/ 00:24:12 faerie dragon armour[1/2]: A randart mottled dragon armour with fixed appearance, worn by the Enchantress. Has between 0 and +8 enchantment, can have some properties not allowed on other randarts. 00:26:01 <|amethyst> hm 00:26:08 <|amethyst> added in 00:26:11 <|amethyst> %git dc1e7139 00:26:11 07Lasty02 * 0.17-a0-36-gdc1e713: Don't allow body armour or weapon randarts to have negative enchantment 10(1 year, 5 months ago, 3 files, 13+ 3-) 13https://github.com/crawl/crawl/commit/dc1e71391185 00:26:14 ahh, got it 00:26:16 yeah 00:26:18 it's just copy pasted from the others 00:26:22 <|amethyst> yeah 00:26:24 where it's directly applied to item.plus 00:26:42 <|amethyst> personally 00:26:44 faerie dragon armour should have a shout out to elynae in the description 00:26:46 <|amethyst> I'd rather write 00:26:56 minmay: ? 00:27:18 <|amethyst> max(random2(4), item.plus) 00:27:48 i'm just gonna kill the faerie cast for now 00:28:08 reasonable to change the others separately 00:28:21 PleasingFungus: elynae is a historically important crawl figure and has expressed romantic interest in faeries, so it seems appropriate 00:28:33 ahh 00:28:37 was aware of former (vaguely) but not latter 00:28:46 or possibly i blotted it out of my memory 00:29:49 -!- ProzacElf has joined ##crawl-dev 00:31:03 -!- bonghitz has quit [Ping timeout: 244 seconds] 00:32:13 -!- magistern has quit [Quit: magistern] 00:32:16 03PleasingFungus02 07* 0.19-a0-1072-g3763c35: Remove an unused cast 10(27 seconds ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3763c35f915e 00:32:21 Beogh's Smiting ability can target walls and other useless tiles 13https://crawl.develz.org/mantis/view.php?id=10595 by Ultraviolent4 00:34:08 -!- homsar has quit [Ping timeout: 250 seconds] 00:34:29 -!- Dracunos has quit [Ping timeout: 260 seconds] 00:38:08 -!- nikheizen has quit [Quit: leaving] 00:39:09 <|amethyst> RIP invisible rock worms 00:40:01 ...very nearly a good clan name. 00:42:48 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 00:44:43 clearly, the appropriate clan name would be "Bring Back Invisible Rock Worms" 00:46:33 mm 00:46:42 The Invisible Rock Worm Returns 00:47:14 <|amethyst> Invisible Rock Worm Targeter? 00:47:19 oooh 00:47:22 i quite like that. 00:48:22 <|amethyst> !learn add reserved_clan_names Invisible Rock Worm Targeter 00:48:22 reserved clan names[25/25]: Invisible Rock Worm Targeter 00:48:48 did amalloy get his dieselrobin clan together? 00:48:56 i was literally just typing out that we need one more 00:49:11 wheals joined 00:49:34 Hans Jorgrunsson, Invisible Rock Worm Targeter 00:50:25 ontoclasm: just s/, / and the/ and you've got the name of a rock band 00:50:35 mmm 00:50:47 heh 00:51:02 -!- homsar has quit [Ping timeout: 250 seconds] 00:51:47 -!- zxc has joined ##crawl-dev 00:52:54 you looking to join up, PleasingFungus, or just beating the drum on my behalf? 00:53:40 was gonna nominate |amethyst 00:53:53 he needs to get more hours in if he's gonna be a Crawl Pro. 00:53:57 1000 hours of practice! 00:54:15 also i felt bad about not volunteering myself' 00:56:22 -!- Zekka has quit [Ping timeout: 244 seconds] 00:59:06 -!- cait has quit [Remote host closed the connection] 01:00:02 -!- omarax has quit [Remote host closed the connection] 01:00:45 i fix a disturbing number of problems with my C++ code by adding more { }s. 01:01:01 that wasn't really apropos, sorry. 01:02:09 dieselrobin! 01:02:16 Kramin: you gotta find me one more dev 01:02:27 lasty? 01:02:41 he'll be on awbw team most likely 01:02:42 i would happily take lasty of course. he hasn't been around much afaik 01:02:46 if he's not busy 01:03:06 wheals :P 01:03:13 already got wheals 01:03:22 oh right 01:03:25 um 01:03:45 i wonder if r-i would like to play 01:03:53 i doubt it but i can ask 01:03:55 who is r-i 01:04:04 regret-index, formerly went by a rapidly changing set of nicks 01:04:09 reverse-innovation 01:04:14 rude. 01:04:20 what everyone on tavern wishes we would do: stop changing things 01:04:27 bring back MD 01:04:32 gammafunk? 01:04:39 no? 01:04:44 gf won't play 01:04:47 not streamable enough for him 01:04:49 <|amethyst> rename Deep Dwarf to Mountain Dwarf 01:04:50 oh 01:04:50 ok 01:04:51 doesn't tavern want us to remove bread rations 01:04:55 you're asking about diesel 01:04:56 or something 01:04:58 yeah not for me this time 01:05:11 next DR is mandatory for devs 01:05:13 <|amethyst> if we're going to remove one ration it should be meat rations 01:05:19 otherwise dev license revoked 01:05:19 my no was a general response to the open question of "gammafunk?" 01:05:29 gammafunk? absolutely not. 01:05:32 exactly. 01:05:36 never gammafunk 01:05:39 gammafunk: not even once 01:05:44 gammafunk? i hardly know 'er 01:05:56 thou shalt not gammafunk 01:06:07 wheals is a maybe at *best*, but still not a definite no 01:06:23 <|amethyst> anyone listen to the Misfits? 01:06:34 again speaking of the open question of "wheals?", not DR 01:06:35 <|amethyst> Little gammafunk, it's a shame that trunk is the only branch 01:07:14 r-i is a definite no. 01:07:21 but, only in context of dieselrobin. 01:07:30 remains a mystery in all other aspects. 01:07:38 conscript elliptic :) 01:07:54 secretly get him to do all the missions 01:07:58 win 01:08:03 vote for HESu, his favorite combo 01:08:36 DR does sound cool, but yeah timing and I can't stream it all that well :( 01:09:31 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1072-g3763c35 (34) 01:09:53 demise only wants to play if he can get youtube vidoes out of it 01:09:57 man 01:10:11 just need one more and we can put you all in a team 01:13:09 if new scoring was here and had cheeovos that showed on my player page 01:13:20 I'd be more tempted! 01:13:20 hmm 01:13:34 get cheqdog on the phone 01:13:58 as it is I hate to play on alt accounts since as infrequently as I need every win to make it to 100 01:14:14 *as infrequently as I play 01:14:45 !seen chequers 01:14:45 I last saw chequers at Fri Aug 5 03:02:15 2016 UTC (2h 12m 30s ago) saying 'wacky suggestion for spell fail rate + ER: instead of modifying spell fail rate with ER, use ER to cap the maximum spell level you can cast' on ##crawl-dev. 01:14:48 o 01:14:51 i remember that 01:15:13 yeah I think we all dissagreed with that one 01:15:30 not to discourage innovation :P 01:15:37 you gotta be willing to say dumb shit if you want to think of things no one has already 01:15:44 thus, my posting 01:15:46 xactly 01:15:51 I saw a good image about that recently 01:16:12 saw a good talk relating to that recently 01:16:17 by john cleese 01:16:24 cool 01:16:25 on creativity 01:16:28 something like "Before you think your idea is too dumb to say, remember that someone once said in a meeting 'Let's make a movie about a tornado of sharks'." 01:16:29 look it up 01:16:48 heh 01:19:36 Unstable branch on crawl.develz.org updated to: 0.19-a0-1072-g3763c35 (34) 01:20:30 -!- Krakhan has quit [Ping timeout: 276 seconds] 01:20:46 -!- valrus has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 01:23:07 -!- simmarine_ has quit [Read error: Connection reset by peer] 01:33:04 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 01:35:45 Kramin: i mean, obviously demise *can* get youtube videos out of dieselrobin 01:36:16 i certainly will 01:38:42 at least one, anyway; i suppose nobody can be certain they'll get more than one session out of dieselrobin 01:51:29 yeah, lasty is probably free to be on the dev team 01:51:41 since me walker and morgan are on a team 01:51:55 apparently 01:52:28 apparently 01:55:22 Windows builds of master branch on crawl.develz.org updated to: 0.19-a0-1072-g3763c35 02:00:02 -!- omarax has quit [Remote host closed the connection] 02:04:10 bad ideas: bring back Hellfire, but as a new partially resistible fire damage type. so i guess, uh, that's lava. 02:04:17 this idea didn't even last an entire sentence. 02:07:09 -!- VoxSomniator has quit [Quit: Leaving] 02:08:20 lavastorm 02:08:57 you could have something like dark souls, where lava erupts out of the ground nearby at random. so qazlal's disaster area, or possibly ring of flame, depending on how you want to think about it. 02:09:07 crawl has too many things in it. every time i think of something cool, it already exists. 02:10:37 it might be nice if ring of flames was less niche. it feels a little niche, as a player spell. 02:11:47 I wish ring of flames wasn't an enhancer, didn't affect resists, and was lower level 02:12:40 so you want it to only burn dudes standing next to you? 02:13:01 basically, yeah. I feel like it's a whole lot of things and I don't know what to make of it 02:13:10 admittedly that's how i always use it 02:13:17 but that's because i've only used it as a xom effect 02:13:18 you use it to roleplay being asmodeus, duh 02:13:48 it's true, just using his tile isn't enough 02:13:53 like being surrounded by fire that constantly damages stuff is cool 02:13:55 it would honestly still have to be pretty high level, i think. flame clouds are very high damage, and to add that on top of sticky flame makes a melee fire elementalist's damage output pretty nuts 02:14:15 like at least level 5 02:14:24 I was gonna say 5 myself 02:14:37 well, it covers 9 times the area of cflame 02:14:41 and travels with you 02:14:49 make it level 27 02:14:49 heh 02:14:51 exactly! 02:14:59 not like you're getting 9 enemies to stand in it all the time 02:15:06 I mean pretty much no matter what 02:15:08 FE^Qaz tech 02:15:12 it will be 'worse' than conjure flame 02:15:27 because it's not hard to get things to walk into conjure flame's clouds 02:15:35 and that kills everything thru like 02:15:40 lair and a bit beyond 02:16:19 it'd just be higher level in exchange for being cooler and less of a hassle 02:16:30 (well, and different schools) 02:16:46 i don't think it would be a charm anymore 02:17:03 if it's literally just the conjure flame effect 02:17:05 yeah, if it's not enhancing or giving you a resist profile anymore 02:17:11 sure 02:17:17 it's just mobile 02:17:23 which strikes me as the major advantage 02:17:30 at any rate I just wanna. play an orc, use battleaxe and ring of flames 02:17:37 and cut stuff while burning em 02:20:35 sounds suspiciously like cooking 02:23:12 don't shame my roleplaying 02:24:38 PleasingFungus: hi 02:27:18 -!- Zeor has quit [Quit: Leaving.] 02:28:01 -!- orost has quit [Read error: Connection reset by peer] 02:28:56 -!- Zxpr2jk has quit [Read error: Connection reset by peer] 02:30:34 hello 02:35:20 people were talking about scoring pages 02:38:50 -!- Siegurt has joined ##crawl-dev 02:42:01 -!- Siegurt has quit [Client Quit] 02:45:35 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 02:46:54 -!- Cimanyd has quit [Quit: Page closed] 02:49:20 -!- Azzkikr has quit [Ping timeout: 250 seconds] 02:53:31 Monster database of master branch on crawl.develz.org updated to: 0.19-a0-1072-g3763c35 02:55:49 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]] 02:57:41 -!- Siegurt has joined ##crawl-dev 02:57:44 -!- Siegurt has left ##crawl-dev 02:57:58 -!- Siegurt has joined ##crawl-dev 02:58:31 -!- johlstei has joined ##crawl-dev 03:00:03 -!- omarax has quit [Remote host closed the connection] 03:03:13 -!- vede has quit [Ping timeout: 276 seconds] 03:05:25 -!- hellmonk has quit [Quit: Page closed] 03:11:00 -!- GauHelldragon has quit [Ping timeout: 250 seconds] 03:12:07 Unstable branch on crawl.beRotato.org updated to: 0.19-a0-1072-g3763c35 (34) 03:14:28 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 03:18:03 -!- Siegurt has quit [Ping timeout: 250 seconds] 03:24:28 -!- Pacra_ has quit [Ping timeout: 264 seconds] 03:31:20 -!- Kranix has quit [Quit: Konversation terminated!] 03:48:07 -!- Zekka_ has quit [Ping timeout: 265 seconds] 03:53:06 -!- Dingo has quit [Quit: Leaving] 04:00:03 -!- omarax has quit [Remote host closed the connection] 04:20:17 -!- amalloy is now known as amalloy_ 04:20:27 -!- FunkyGnoll has quit [Ping timeout: 258 seconds] 04:22:40 -!- ontoclasm has quit [Quit: Leaving.] 04:24:40 -!- bonghitz has quit [Remote host closed the connection] 04:29:25 -!- MarvinPA has joined ##crawl-dev 04:32:35 -!- Patashu_ has joined ##crawl-dev 04:42:20 -!- aditya has quit [Ping timeout: 244 seconds] 04:48:41 ah. scoring won't help with dieselrobin since multiple players claim each account 04:48:50 but yes, i would like to knock the project out soon 04:48:59 just need to optimise some db queries before we can expand the reach of it 04:53:24 -!- neunon_ has joined ##crawl-dev 04:53:25 -!- neunon has quit [Ping timeout: 258 seconds] 04:53:53 -!- neunon_ is now known as neunon 04:55:19 -!- PElf has joined ##crawl-dev 04:55:53 -!- lobf has quit [Quit: lobf] 05:00:03 -!- omarax has quit [Remote host closed the connection] 05:05:25 -!- bitcoinbastard has quit [Ping timeout: 276 seconds] 05:22:44 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 05:56:27 -!- PElf has quit [Quit: HydraIRC -> http://www.hydrairc.com <- Chicks dig it] 06:00:02 -!- omarax has quit [Remote host closed the connection] 06:12:59 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 06:17:52 -!- ProzacElf has quit [Ping timeout: 250 seconds] 06:30:32 -!- bonghitz has quit [Ping timeout: 276 seconds] 06:46:06 -!- edsrzf has quit [Ping timeout: 258 seconds] 07:00:02 -!- omarax has quit [Remote host closed the connection] 07:02:23 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 07:02:49 -!- PsyMar has quit [Ping timeout: 244 seconds] 07:33:49 -!- bonghitz has quit [Ping timeout: 244 seconds] 07:36:03 -!- elliptic has quit [Quit: Leaving] 07:39:48 -!- valrus has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 07:50:21 -!- Zxpr1jk has quit [Read error: Connection reset by peer] 07:51:47 -!- tksquared has quit [Ping timeout: 250 seconds] 08:00:01 -!- omarax has quit [Remote host closed the connection] 08:01:32 -!- Shard1697 has quit [Ping timeout: 276 seconds] 08:04:33 kinggod (L10 KoAr) ASSERT(in_non_diamond_int(r.start)) in 'ray.cc' at line 217 failed. (D:9) 08:10:13 -!- Shard1697 has joined ##crawl-dev 08:11:15 -!- fufumann has quit [Ping timeout: 264 seconds] 08:12:58 -!- PsyMar has quit [Ping timeout: 260 seconds] 08:16:14 kinggod (L12 KoAr) ASSERT(in_non_diamond_int(r.start)) in 'ray.cc' at line 217 failed. (Lair:1) 08:17:39 -!- magistern has quit [Quit: magistern] 08:27:18 -!- eb has quit [Ping timeout: 258 seconds] 08:35:21 -!- bonghitz has quit [Ping timeout: 276 seconds] 08:39:55 -!- MaxFrost has quit [Quit: Going offline, see ya! (www.adiirc.com)] 08:44:19 -!- elliptic has joined ##crawl-dev 08:47:23 -!- bonghitz has quit [Remote host closed the connection] 08:57:01 -!- eb_mobile has quit [Ping timeout: 244 seconds] 08:58:39 -!- HolyRage has quit [Quit: ChatZilla 0.9.92 [Firefox 48.0/20160726073904]] 09:00:01 -!- omarax has quit [Remote host closed the connection] 09:01:58 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 09:06:35 -!- debo has quit [Quit: orb spiders :(] 09:11:50 -!- eb has quit [Ping timeout: 244 seconds] 09:14:21 -!- packet_loss has joined ##crawl-dev 09:16:34 -!- jefus- has joined ##crawl-dev 09:20:18 -!- jeefus has quit [Ping timeout: 250 seconds] 09:25:49 -!- tksquared has quit [Ping timeout: 250 seconds] 09:32:32 -!- valrus has quit [Client Quit] 09:42:25 -!- Patashu_ has quit [Ping timeout: 252 seconds] 09:54:34 -!- wheals has joined ##crawl-dev 10:00:02 -!- omarax has quit [Remote host closed the connection] 10:17:38 -!- whig has quit [Ping timeout: 244 seconds] 10:21:13 -!- Tux[Qyou] has joined ##crawl-dev 10:30:32 -!- Dracunos7 has quit [Ping timeout: 240 seconds] 10:35:38 -!- jefus- is now known as jefus 10:39:08 -!- Patashu_ has joined ##crawl-dev 10:39:52 -!- pyrotecnix has quit [Ping timeout: 240 seconds] 10:45:07 -!- Patashu_ has quit [Ping timeout: 252 seconds] 10:50:23 -!- Kursh has quit [Quit: http://www.kiwiirc.com/ - A hand crafted IRC client] 10:54:38 -!- homsar has quit [Ping timeout: 250 seconds] 10:55:02 -!- Kalir has quit [Changing host] 11:00:02 -!- omarax has quit [Remote host closed the connection] 11:04:38 -!- Cerpin_ has joined ##crawl-dev 11:15:11 -!- MaBunny has quit [Quit: Bye guys hav a good time :)] 11:20:51 -!- Shard1697 has quit [Ping timeout: 264 seconds] 11:21:11 -!- Cerpin_ has quit [Ping timeout: 244 seconds] 11:29:12 -!- debo has joined ##crawl-dev 11:29:27 -!- valrus_ has quit [Ping timeout: 244 seconds] 11:43:15 -!- JimmahDean has quit [] 11:45:14 -!- Alcopop_ has quit [Client Quit] 11:52:43 -!- elliptic has quit [Quit: Leaving] 11:54:28 -!- amalloy_ is now known as amalloy 11:57:02 -!- LexAckson has joined ##crawl-dev 11:58:14 -!- Celsitudo has quit [Read error: Connection reset by peer] 12:00:02 -!- omarax has quit [Remote host closed the connection] 12:00:31 -!- ontoclasm has joined ##crawl-dev 12:06:43 -!- kdrnic has joined ##crawl-dev 12:10:04 -!- wheals has quit [Quit: Leaving] 12:10:24 -!- wheals has joined ##crawl-dev 12:16:32 -!- Zxpr1jk has quit [Ping timeout: 250 seconds] 12:19:35 -!- vev has quit [Quit: Leaving] 12:21:53 -!- Daekdroom has quit [Remote host closed the connection] 12:23:39 -!- VoxSomniator has quit [Read error: Connection reset by peer] 12:25:24 -!- aditya has quit [Ping timeout: 258 seconds] 12:32:34 -!- homsar has quit [Ping timeout: 250 seconds] 12:35:36 -!- PsyMar has quit [Ping timeout: 250 seconds] 12:37:02 -!- PleasingFungus has joined ##crawl-dev 12:38:10 -!- Zekka_ has quit [Ping timeout: 244 seconds] 12:43:19 -!- Cacophony has quit [Read error: Connection reset by peer] 12:44:12 -!- Bammboo has quit [Ping timeout: 240 seconds] 12:47:18 -!- MadCoyote has quit [Ping timeout: 250 seconds] 12:49:29 -!- lobf has joined ##crawl-dev 12:51:27 -!- Bammboo has quit [Ping timeout: 264 seconds] 12:52:26 -!- sanka has quit [Ping timeout: 250 seconds] 12:54:40 -!- Pacra_ has joined ##crawl-dev 12:56:32 -!- BlueBeetle has quit [Read error: Connection reset by peer] 12:57:16 -!- kdrnic has quit [Quit: Leaving] 12:59:12 -!- MarvinPA has quit [Ping timeout: 240 seconds] 12:59:52 -!- tksquared has quit [Ping timeout: 250 seconds] 13:00:01 -!- omarax has quit [Remote host closed the connection] 13:00:20 -!- MarvinPA has joined ##crawl-dev 13:04:35 Unstable branch on crawl.akrasiac.org updated to: 0.19-a0-1072-g3763c35 (34) 13:06:56 -!- amalloy is now known as amalloy_ 13:10:16 -!- Bammboo has quit [Ping timeout: 250 seconds] 13:24:03 -!- Ququman has joined ##crawl-dev 13:36:42 -!- Rast-- has quit [Read error: Network is unreachable] 13:36:51 -!- Rast-- has joined ##crawl-dev 13:40:03 -!- bitcoinbastard has quit [Ping timeout: 240 seconds] 13:52:49 @??lightning spire 13:52:50 lightning spire (118) | Spd: 10 (07stationary) | HD: 3 | HP: 17-24 | AC/EV: 13/3 | 11non-living, unbreathing | Res: 13magic(immune), 05fire++, 02cold++, 11elec+++, 09poison+++, 12drown, 04rot+++, 13neg+++, 13torm | XP: 33 | Sp: b.electrical (3d6) [11!AM, 06!sil] | Sz: small | Int: brainless. 13:53:10 @??lightning spire hd:10 13:53:10 lightning spire (118) | Spd: 10 (07stationary) | HD: 10 | HP: 57-79 | AC/EV: 13/3 | 11non-living, unbreathing | Res: 13magic(immune), 05fire++, 02cold++, 11elec+++, 09poison+++, 12drown, 04rot+++, 13neg+++, 13torm | XP: 669 | Sp: b.electrical (3d13) [11!AM, 06!sil] | Sz: small | Int: brainless. 13:55:23 -!- zxc has quit [Read error: Connection reset by peer] 13:58:52 -!- PsyMar has quit [Ping timeout: 240 seconds] 14:00:02 -!- omarax has quit [Remote host closed the connection] 14:04:54 -!- ontoclasm has quit [Quit: Leaving.] 14:07:02 -!- elliptic has joined ##crawl-dev 14:07:11 -!- amalloy_ is now known as amalloy 14:23:44 PleasingFungus: it was very kind of you to offer to be the permanent ideas-validator for tavern's new fork 14:23:53 oh nooo 14:24:20 i was just really curious about the super in-depth ally management mechanics 14:24:32 the more in depth a thing is the better 14:24:40 that's why they're putting D back to 27 14:25:00 failure odds by monster intelligence! sound levels! who even knows that ambient sound exists in crawl? 14:25:16 -!- simmarine has joined ##crawl-dev 14:25:21 it's very powerful, imo 14:43:48 -!- Wye has quit [Quit: Leaving] 14:44:21 -!- fufumann is now known as ludd 14:45:05 -!- Kellhus has quit [Quit: Page closed] 14:46:53 -!- nikheizen has joined ##crawl-dev 14:50:25 -!- Jafet has quit [Ping timeout: 252 seconds] 14:51:40 -!- homsar has quit [Ping timeout: 250 seconds] 14:57:03 -!- PsyMar has quit [Ping timeout: 240 seconds] 14:57:08 -!- ZiBuDo has joined ##crawl-dev 14:57:15 After reading through coding_conventions.txt is there any other thing I should read or know before writing patches? 14:57:23 You know, aside from this big codebase 15:00:02 -!- omarax has quit [Remote host closed the connection] 15:00:35 -!- homsar has quit [] 15:02:25 nothing too essential hopefully 15:07:58 -!- AltReality has quit [Quit: Shame on us, doomed from the start, May God have mercy on our dirty little hearts. Shame on us, for what we've done, and all we ever were, just zeros and ones.] 15:08:15 whatcha thinkin bout? 15:09:45 I had some minor text tweaks I was thinking of doing, but the big one I wanted to do was to tackle the draconian tail-slap thing that I made a thread about a few weeks back 15:09:56 adding it to the A-list? 15:09:59 yes 15:10:08 didn't i remove grey drac tail slaps like two years ago 15:10:48 after that, I wanted to see if I could make the existence of auxiliary attacks clearer on the character sheet 15:11:04 you don't know that your horns can be used to attack unless you're watching the combat log 15:11:09 -!- JimmahDean has quit [] 15:11:14 maybe i only thought about it very loudly 15:12:05 I was working on showing what mutations are supressed by items in A at some point 15:12:14 but never finished that one :( 15:12:36 ohh 15:12:39 %git 8e077e5b3dbaf6d8c18e8ab30cf8f8300dd664c8 15:12:39 07PleasingFungus02 * 0.15-a0-2137-g8e077e5: Remove (grey) draconic trampling 10(2 years, 1 month ago, 1 file, 0+ 7-) 13https://github.com/crawl/crawl/commit/8e077e5b3dba 15:12:54 Medar: imo toss a WIP up as a branch, if you still have it around 15:13:47 i guess it might be rotted 15:14:22 I think it was mostly I realized I should have had a different approach or something 15:15:52 ahh 15:16:54 one thing that wasn't covered in coding_conventions.txt was patch conventions. for instance if I make multiple small changes to text to unrelated things, should I submit each as a separate patch or all together? 15:17:37 Capitalization fixes should probably be all-together, but capitalization fixes and wording changes? 15:18:17 !source files.cc 15:18:17 https://github.com/crawl/crawl/blob/master/crawl-ref/source/files.cc 15:18:36 probably not a big deal either way, as long as it's not a ton of small patches 15:18:43 Brannock: doesn't matter really. it's technically tidier to do them separately but it's slightly more of a pain, so it balances out 15:18:46 what medar said. 15:18:54 Thank you 15:19:12 I have a bunch of time to kill while I'm up here waiting for the wedding so I might as well start reading through the codebase 15:19:24 you can have two commits and one push request for example 15:19:24 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 15:19:45 *pull request 15:20:13 -!- ontoclasm has joined ##crawl-dev 15:24:02 -!- ig0rbit has quit [Ping timeout: 252 seconds] 15:24:03 -!- qguv has quit [Ping timeout: 240 seconds] 15:29:56 -!- Alcopop has quit [Quit: Page closed] 15:30:02 roctavian's new executioner tile looks good 15:30:32 i don't understand why he doesn't commit his own tiles 15:30:40 -!- HellTiger has quit [Ping timeout: 250 seconds] 15:30:41 iirc he has permissions? 15:30:42 approval process? 15:30:47 ontoclasm, what do you think of the new tiles? 15:31:03 -!- ludd has quit [Quit: Leaving] 15:31:19 -!- PleasingFungus is now known as ontoclasrn 15:31:32 they're terrible. i hate them. the worst 15:31:36 -!- ontoclasrn is now known as PleasingFungus 15:31:41 is this the work of a Mara?? 15:31:53 <|amethyst> We should name roctavian assistant art director 15:32:27 <|amethyst> s/assistant/associate/ 15:34:13 03PleasingFungus02 07[oubliette] * 0.19-a0-1103-gecc5d12: Merge branch 'master' into oubliette 10(27 seconds ago, 0 files, 0+ 0-) 13https://github.com/crawl/crawl/commit/ecc5d1244ad6 15:34:48 03PleasingFungus02 07[oubliette] * 0.19-a0-1104-g3322a26: Checkwhite. 10(12 seconds ago, 1 file, 22+ 22-) 13https://github.com/crawl/crawl/commit/3322a26c9f4e 15:35:34 I wonder how that new exec tile looks on dark floor tiles 15:35:34 messy merge commit. really needs a rebase one of these days 15:35:50 would only worry that it blends in too much 15:36:09 could brighten up the blades a bit 15:36:13 to give it a clear outline 15:36:34 Yeah, I might be wrong and it has great contrast 15:38:36 also, i don't understand the point of the minor tag in that branch. are we saving place info for NUM_BRANCHES? 15:39:12 PleasingFungus: there was deffo some save compat issues with making a new branch 15:39:16 ahh, i see 15:39:19 but it's been a while, so I forget... 15:39:25 global branch info is saved as NUM_BRANCHES 15:39:27 *saved for 15:40:02 did dpeg ask you about this branch, or you just happened to notice it and wanted to update? 15:40:16 tangential thought 15:40:17 I know he's still working on it as he has time, but I haven't heard anything recently 15:40:25 was thinking about portal vaults 15:41:14 -!- ig0rb1t has quit [Ping timeout: 258 seconds] 15:42:15 -!- AltReality has quit [Quit: Shame on us, doomed from the start, May God have mercy on our dirty little hearts. Shame on us, for what we've done, and all we ever were, just zeros and ones.] 15:44:42 03PleasingFungus02 07* 0.19-a0-1073-g541410e: Deduplicate a check 10(59 seconds ago, 1 file, 1+ 2-) 13https://github.com/crawl/crawl/commit/541410edeee8 15:45:36 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.92 [Firefox 47.0/20160604131506]] 15:47:22 Brannock: which ones? 15:47:34 https://crawl.develz.org/mantis/view.php?id=9951 15:47:58 oh, at the bottom 15:48:34 those look pretty good in general 15:48:47 i feel like maybe some of them won't read very well 15:49:07 -!- lobf has quit [Quit: lobf] 15:49:54 and yeah roc has commit rights so idk 15:50:32 -!- Kenran has quit [Quit: leaving] 15:51:33 -!- kdrnic has joined ##crawl-dev 15:57:42 -!- lobf has joined ##crawl-dev 16:00:09 -!- omarax has quit [Remote host closed the connection] 16:00:42 are the naga tiles in? 16:00:57 I don't think the ritualist/gnaga ones are 16:04:04 -!- lobf has quit [Quit: lobf] 16:04:34 Brannock: well, i made a set of nagas 16:04:51 so the ones on that issue aren't, no 16:05:05 i think i'll use his trolls though, i just need to edit them a bit 16:05:27 -!- lobf has joined ##crawl-dev 16:06:05 the moon trool looks too grey 16:06:12 *troll 16:06:14 I prefer the current version 16:06:42 i think that's a ghost troll 16:06:46 for that one wizlab 16:06:59 i'd have to make a moon troll to match 16:07:02 + purgy and snorg 16:07:10 ah, I forgot about the monk wizlab 16:07:39 looking at current tiles now. your naga look much more dynamic than his. I like the hood on his ritualist though 16:09:39 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1073-g541410e (34) 16:10:09 -!- ZiBuDo has quit [Ping timeout: 260 seconds] 16:10:36 -!- ZiBuDo has joined ##crawl-dev 16:14:36 -!- lobf has quit [Quit: lobf] 16:16:35 -!- lobf has joined ##crawl-dev 16:21:38 -!- travis-ci has joined ##crawl-dev 16:21:39 The build passed. (oubliette - 3322a26 #6263 : Nicholas Feinberg): https://travis-ci.org/crawl/crawl/builds/150140670 16:21:39 -!- travis-ci has left ##crawl-dev 16:26:34 -!- lobf has quit [Quit: lobf] 16:30:15 -!- wheals has quit [Quit: Leaving] 16:44:45 -!- PleasingFungus has joined ##crawl-dev 16:45:43 -!- ProzacElf has joined ##crawl-dev 16:47:14 -!- home has quit [Remote host closed the connection] 16:47:24 -!- qguv has quit [Ping timeout: 276 seconds] 16:48:01 gammafunk: wow, you hunted that guy down in webtileschat? 16:48:05 or did he find you? 16:48:17 PleasingFungus: just spectated 16:48:25 he had a few viewers 16:48:54 initially he asked about making vaults while we were both spectating someone elses gma 16:48:57 *game 16:49:01 but yeah I saw him playing online 16:49:06 *on cbro 16:49:43 -!- parabolic has joined ##crawl-dev 16:49:49 cool 16:50:33 standard spiel about "I'll only accept these vaults if you make a twitch donation of $50 or less", of course 16:50:58 everyone gets the same rate, because I'm fair! 16:51:40 a bargain 16:52:56 -!- cait has quit [Ping timeout: 258 seconds] 16:52:56 -!- elliptic has quit [Ping timeout: 258 seconds] 16:53:15 -!- parabolic is now known as elliptic 16:53:24 wow, $50 or less. high bar 16:53:54 -!- ZiBuDo has quit [Ping timeout: 260 seconds] 16:54:04 haha 16:54:33 oh 16:54:44 inequalities are hard 16:54:52 -!- ZiBuDo has joined ##crawl-dev 16:55:25 funny thing is I've been going through parts of Rudin recently and I made that mistake 16:57:58 that reminds me of stuff like "Make up to $50/hour or more working from home!" 16:57:58 Lamia's tile was kept around for players to use as their own tiles. How about keeping the old Serpent of Hell tiles for the same reasons? 16:58:04 <|amethyst> any thoughts on letting Bcadren back into ##crawl-dev? it's been a year or two 16:59:10 -!- cait has quit [Remote host closed the connection] 16:59:15 if you really want to 16:59:23 Brannock: sure, why not 16:59:53 may I ask why he was banned? 16:59:58 <|amethyst> I don't remember the events that led up to the ban very well 17:00:01 -!- omarax has quit [Remote host closed the connection] 17:00:10 iirc he was just an enormous pest for years 17:00:15 <|amethyst> which is why I was asking (that, and he asked me about lifting it) 17:00:24 yeah that's the brief summary of the ban 17:00:33 i think it happened before i joined 17:00:36 eah 17:00:49 no outright maliciousness aside from some instances of trying to get around people ignoring him through bot hijinks 17:00:53 ohh yeah 17:00:55 i remember that 17:00:56 he changed nicks a lot 17:01:00 oh and didn't he use weird nicks 17:01:11 right, doing that to also get around people ignoring him 17:01:48 now that you are talking about it, I remember him harassing me re: his mental disorder(s) 17:01:52 oh god right that too 17:01:58 he gave me his life story at one point 17:02:07 paragraphs and paragraphs that i did not read 17:02:31 trying to decide what directory to store the old-serpent-placename tiles in. rltiles\mon\unique seems to be the default, but serpent_of_hell-placename tiles already reside there. undecided if the name difference will be enough to prevent confusion 17:02:44 could add a new playertiles directory 17:02:54 |amethyst: i was going to say 'i guess unban him if you think he's really changed his ways' but i'm leaning toward no now 17:02:57 old serpent placename tiles? 17:02:58 <|amethyst> but banning presumably involved explicitly not following requests to change some behaviour 17:03:21 old-serpent-gehenna and so on 17:03:35 well, are you replacing those tiles? 17:03:38 no 17:03:40 gammafunk: he's talking about re-adding the old single-height serpent of hell tiles for player use 17:03:44 ah, ok 17:03:46 like the giaggustuono 17:03:49 (sp) 17:04:15 yeah, they have to have new enum names already 17:04:34 so you're going to give them new filename and a new enum in the tiledef txt file 17:04:42 <|amethyst> I would say let him in with a warning that any future bad will be permanent 17:04:55 <|amethyst> but my judgment has been poor on similar matters before 17:04:55 Giaggostuono and Lamia are in mon\unique right now. Probably make a unique_tiles under \rltiles\player for better organization? 17:04:59 PERMANENT bad 17:05:04 gammafunk, yes 17:05:25 yeah I suppose putting player-specific tiles in a dir would be nice 17:05:44 <|amethyst> nikheizen: It's an 80s band, but could be just about any genre with that name 17:05:46 well, it will complicate the statements in the txt file 17:06:03 since those require setting a working relative dir to load the tiles 17:06:20 -!- travis-ci has joined ##crawl-dev 17:06:21 The build passed. (oubliette - ecc5d12 #6263 : Nicholas Feinberg): https://travis-ci.org/crawl/crawl/builds/150140773 17:06:21 -!- travis-ci has left ##crawl-dev 17:08:11 gammafunk: how would it be a different problem from existing subdirectories? 17:08:17 i mean, assuming this is like rltiles/mon/player 17:08:32 not rltiles/playermon, which maybe is what you were thinking of? 17:08:54 |amethyst: Is it now? Pretty good band name. 17:09:17 <|amethyst> nikheizen: I don't know if it *really* is, but the 80s can be, like, anything you want, man 17:09:21 |amethyst: looking around the logs at the time of the ban, bcadren doesn't seem to have been doing anything notable at the time. possible there was something in direct messages, or another channel 17:09:43 PleasingFungus: I guess what I'm saying is, the definition statements for all the player-only monster tiles would need to be moved to a dedicated section 17:09:49 <|amethyst> PleasingFungus: what's the date? 17:09:51 of that txt definition file 17:10:08 so it's just a little work to do that, definitely fine to do 17:10:09 I can do that 17:10:17 can you?! CAN YOU?!?! 17:10:20 we'll find out!! 17:10:39 Tune in next time on ##crawl-dev, for the exciting finale! 17:12:05 -!- Krakhan has quit [Changing host] 17:12:05 |amethyst: Like... woah. 17:12:06 there's nothing about it on rym, so learn add reserved_band_names 17:12:22 20150405 seems to have been the last time he was active (so about 16 months ago) 17:12:31 so my wifi went out for a little while, and i got those last seven messages between gammafunk and Brannock all at once 17:12:37 it was very intense 17:12:42 |amethyst: the date of what? 17:13:02 the date i'm going on with sonja? because i have to warn ##-dev, you guys are NOT invited 17:13:15 -!- aredel has quit [Quit: Page closed] 17:13:24 |amethyst: i find bcadren annoying myself, but i support giving him another chance. i don't like assuming people never change 17:13:52 <|amethyst> I guess dpeg is the person to ask 17:13:55 -!- ontoclasm has quit [Quit: Leaving.] 17:13:57 <|amethyst> since he is the one who banned 17:14:11 <|amethyst> he might or might not have intended that to be permanent 17:14:27 <|amethyst> s/banned/kicked/ 17:14:47 -!- e25 has quit [Quit: Page closed] 17:15:04 hm. some of the tiles are listed under monster categories, like Giaggostuono is listed under Drakes. If I move his entry to ## Custom player tiles will this break anything wrt code detection for tiles finding? 17:15:12 <|amethyst> also, needs someone who has ##crawl-dev ops and knows this stuff 17:15:23 generally no 17:15:36 I do believe it was intentional, since bcadren had been considered a problem for some time, but if several people would like the ban lifted then that's ok 17:16:04 I'm doubtfull unbanning would lead to anything productive. Obviously I'm not really around, so my opinion isn't too important. 17:16:08 -!- lobf has joined ##crawl-dev 17:16:10 i wouldn't expect anything productive to come from unbanning personally 17:16:18 yeah i'd lean toward keeping him banned, since he has plenty of other channels to communicate through (e.g. tavern) 17:16:24 judging from their recent tavern posts which seem to be about the same as the old ones 17:16:42 and ##crawl behaviour of spamming those tavern links 17:16:52 since he has plenty of other channels to be ignored through*? 17:17:02 as you like it 17:17:11 :) 17:17:54 Do we have any other removed uniques? I think there's Maud and... 17:18:03 adolf 17:18:05 Might as well move them into mon\player 17:18:08 hm, doesn't really count 17:18:11 I mean currently existing in mon\unique 17:18:23 i expect we generally remove those as we go 17:18:32 you'd have to hunt through old commits to find others 17:18:34 was wiglaf's tile removed? 17:18:54 it's not in \unique, at the least 17:19:06 lamia is in there still 17:19:21 i suspect lamia was re-added 17:19:27 %git a3cd88f795e759b799125f541b0db1989ea58fce 17:19:27 07regret-index02 * 0.19-a0-967-ga3cd88f: Combine Wiglaf and Donald 10(4 weeks ago, 32 files, 99+ 332-) 13https://github.com/crawl/crawl/commit/a3cd88f795e7 17:19:33 I'm moving lamia into mon\player 17:19:40 as a sort of preservatory for old tiles 17:19:43 i think that was deliberately kept around because of people wanting to use it for player glyphs yeah 17:19:49 ah, unused 17:19:53 can stuff in UNUSED not be used for that? 17:19:55 player glyphs... 17:19:58 it cannot 17:20:04 no, unused isn't put on a tilesheet 17:20:10 well, it has to have an entry in dc-mon, anyway 17:20:18 we've talked about just removing UNUSDED and moving that stuff to the crawl-tiles repo 17:20:24 i suppose there's not really much point of unused 17:20:24 *UNUSED 17:20:45 since yeah, and it's around in git history if it's really needed for something 17:21:04 unborn, I forgot about these 17:21:25 okay, I guess I'll rescue wiglaf from there into mon\player 17:21:27 they were the ones with haunt, right 17:21:30 he's sufficiently unique-looking 17:21:36 fact: the player is the real monster 17:21:53 last question before I commit this 17:22:00 is it necessary to tag them as MONS_LAMIA and all? 17:22:09 I'm not sure what exactly that does 17:22:18 in dc-mon.txt 17:22:18 did they have haunt? i know they were damage mirrorers but i forget what else they even did 17:22:23 ??unborn 17:22:23 unborn[1/1]: A brown L that worships Yred and casts agony, dispel undead, injury mirror, animate dead, and haunt. 17:22:32 aha 17:22:54 -!- Tux[Qyou] has quit [Read error: Connection reset by peer] 17:23:06 Brannock: that's used to generate enums for them, which is how the rest of crawl's code (including the player tile picker) is able to reference them 17:23:11 once they're baked into the tilesheet 17:23:11 that entry should probably note their removal 17:23:46 !learn e unborn[1 s/$/Except not anymore, since they were merged into death knights in 0.17! 17:23:46 unborn[1/1]: A brown L that worships Yred and casts agony, dispel undead, injury mirror, animate dead, and haunt.Except not anymore, since they were merged into death knights in 0.17! 17:23:49 oops 17:23:54 excellently done 17:23:58 !learn e unborn[1 s/Exce/ Exce/ 17:23:59 unborn[1/1]: A brown L that worships Yred and casts agony, dispel undead, injury mirror, animate dead, and haunt. Except not anymore, since they were merged into death knights in 0.17! 17:24:03 hm, how does stuff like the giaggostuono work then? 17:24:16 sort of a weird entry, since almost all of that is just @?? stuff 17:24:26 MarvinPA: i'm nearly sure that has a dc-mon entry 17:24:32 PleasingFungus, so I'll just create a new enum for MONS_OLD_SERPENT so it doesn't conflict with MONS_SERPENT_OF_HELL_GEHENNA? 17:24:47 giaggostuono MONS_GIAGGOSTUONO 17:25:10 !source rltiles/dc-mon.txt:608 17:25:11 https://github.com/crawl/crawl/blob/master/crawl-ref/source/rltiles/dc-mon.txt#L608 17:25:16 Brannock: yes 17:25:21 i was going to say didn't unborn basically become death knight 17:25:28 alternately PLAYER_SERPENT, w/e 17:25:28 but i see you edited the entry since the last time i looked 17:25:45 that's a better prefix 17:26:12 ah i see, i was thinking it needed to be a real mon-data enum 17:26:13 -!- aditya has quit [Quit: Bye] 17:26:23 no, it has no relation 17:26:34 we use MONS_WHATEVER by convention, usually 17:26:38 but it could be anything more or less 17:27:13 there are a very few that are out of sync with the monster enum names, along with some special cases like MONS_MERFOLK_WATER and MONS_DEFORMED_ORC and so on 17:27:25 so it coudl be PLAYER_WIGLAF? 17:28:02 p r o b a b l y but i'd be worried about name collisions maybe? i don't recall if they share a tilesheet 17:28:06 PLAYER_WIGGLES 17:28:18 I'll leave it at MONS_FOO to be safe 17:28:33 update: they do share a tilesheet 17:28:47 -!- edsrzf has joined ##crawl-dev 17:28:52 though player stuff is prefixed TILEP_ 17:29:03 oh nvm that's the same as monsters, sorry 17:29:27 TILEP_HAND_BOROMIR vs TILEP_MONS_FIRE_VORTEX or w/e 17:30:39 -!- PsyMar has quit [Ping timeout: 260 seconds] 17:31:09 -!- Brannock_ has joined ##crawl-dev 17:31:13 -!- aditya has quit [Ping timeout: 265 seconds] 17:32:01 https://github.com/crawl/crawl/blob/a947d7ce778fcc80588cefe8423ce5c5ce410428/crawl-ref/source/rltiles/dc-mon/unique/jozef.png another old unique, if you like 17:32:21 man, zero color contrast on that tile 17:33:04 Jormungandr isn't used anywhere, right? 17:33:22 wow yes i had forgotten tiles called boromir and legolas were things 17:33:23 only player tiles 17:33:30 MarvinPA: there's a full LOTR set! 17:33:34 also "pipin" 17:33:37 haha 17:33:40 I don't know if Jozef is interesting-looking enough to be preserved. I'm on the fence about Maud 17:33:43 -!- Brannock has quit [Ping timeout: 244 seconds] 17:34:05 operate on a basis of whim and whimsy 17:34:21 this is too trivial a matter for serious thought 17:34:50 mm, equip tiles for bone lanterns 17:35:01 I suppose we care about the size of the player tilesheet to some degree, but we could have a policy that all uniques retain their tiles for tile_player_tile purposes 17:35:04 I just wanted to make sure that the old Serpent of Hell tiles were saved in some way 17:35:06 Since they look amazing 17:35:24 Brannock_: well, the crawl-tiles repo exists for that reason, and there's git history 17:35:26 -!- Celsitudo has quit [Read error: Connection reset by peer] 17:35:36 Pull request submitted 17:36:03 but I'd be ok with always preserving unique tiles for player use; extending that policy to all monster tiles is probably unecessary 17:36:31 and/or a bad idea, but I'm not sure how much we should care about the size of the player tilesheet 17:36:36 Maybe depends on if the tile is "unique enough", operating entirely on personal judgement 17:36:38 it does affect load time for webtiles 17:36:45 Phoenix look sweet. Old rat tile? Probably not 17:36:58 Brannock_: that's basically exactly what we do now for all tiles, yeah 17:37:23 wow, this is some real anti-rat prejudice 17:37:26 probably that's fine, since if we have a policy of "always preserve unique tiles for tile_player_tile", the next time someone removes a unique they'll forget to do it 17:37:37 New branch created: pull/317 (1 commit) 13https://github.com/crawl/crawl/pull/317 17:37:37 03Isaac Sloat02 07https://github.com/crawl/crawl/pull/317 * 0.19-a0-1073-gba14dd4: Preserve old uniques for tile_player_tile 10(3 minutes ago, 14 files, 4+ 6-) 13https://github.com/crawl/crawl/commit/ba14dd439c75 17:37:41 so maybe it's best if we require someone to care enough to make the effort 17:38:10 i'm just in the habit of always putting everything into unused whenever i remove anything with a tile but there's probably room for a better approach! 17:38:24 yeah, I think the unused folder is probably a thing that should not be 17:38:33 oops I messed up the pull request 17:38:36 forgot some lines 17:38:47 Brannock_: just force-push on the branch, and PR will update 17:38:57 maybe I can take some time to clean that tile situation a bit 17:39:00 wrt UNUSED 17:39:17 exciting directory management, thrilling file movement, wow 17:39:41 very folder, much rm -rf 17:39:47 I'm using desktop github 17:39:53 I don't know how to force_push on that thing 17:40:01 it should have a way to do that 17:41:15 ooh can we also get rid of docs/obsolete and all the ancient config file things along with the fun directory management 17:41:35 docs/obsolete! noooo 17:41:46 heh, are the old ugly thing tiles that look kind of like a plush stuffed cthulhu still on the player tilesheet? 17:41:48 how will our players read about summon scorpions accidentally summoning vampires 17:41:56 that sounds amazing 17:41:58 ProzacElf: no, but they should be 17:42:00 i always had a soft spot for them, even if the new ones look way better 17:42:01 how did that happen? 17:42:10 MarvinPA: i fixed up the old config files things a few months ago 17:42:35 Brannock_: no idea, this was twenty years ago. however, it's worth noting that this was before linley had discovered enums 17:42:44 03Isaac Sloat02 {GitHub} 07https://github.com/crawl/crawl/pull/317 * 0.19-a0-1074-gba95ab4: Some missing lines. 10(87 seconds ago, 1 file, 9+ 1-) 13https://github.com/crawl/crawl/commit/ba95ab47f998 17:42:47 yeah, i think possibly at the time i was arguing for their nonexistence? don't really feel strongly about it but they seem sort of silly 17:42:47 so i assume he just typed "45" instead of "44" or something 17:42:47 heh 17:43:25 Brannock_: maybe the desktop thing can't really force push, does it have any kind of "git command line" thing? 17:43:37 but whoever merges can squash those commits if they like 17:44:11 Um, maybe. I'm more comfortable with sourcetree myself. I guess I should learn how to actually use the command line interface eventually 17:44:18 the INSTALL.txt instructions cover setting up git under windows so you can have a proper command-line and dev environ 17:44:25 assuming you're on windows 17:44:31 Thanks 17:46:07 -!- Brannock_ is now known as Brannock 17:53:04 -!- valrus has quit [Quit: My iMac has gone to sleep. ZZZzzz…] 17:53:19 Okay, found the command line interface from the desktop program. Good to know for the future 17:55:00 -!- bitcoinbastard has quit [Ping timeout: 276 seconds] 17:55:19 hrm, I should try that thing out, see how they set that up 17:55:44 Brannock: can you build crawl from that? 17:56:00 yeah, you'll want to be able to build crawl if you want to submit patches 17:56:03 Like I said, I prefer SourceTree. The Github client feels unnecessarily opaque to me. As for building... let me see 17:56:06 for anything other than vaults or description edits 17:56:47 install.txt is outdated (last updated v0.16) but I'm sure the guide still works fine 17:56:57 er 17:57:01 it's not outdated 17:57:12 it was changed very recently 17:57:21 It may use 0.16 as an example though 17:57:22 oh I was looking at some text at the start 17:57:23 yeah 17:57:24 that 17:58:09 yeah that just mentions where crawl is known to build 17:58:09 -!- Gruud has quit [Quit: Page closed] 17:58:12 I overextrapolated, my mistake 18:00:02 -!- omarax has quit [Remote host closed the connection] 18:01:10 -!- elliptic has quit [Quit: Leaving] 18:03:09 Unstable branch on underhound.eu updated to: 0.19-a0-1073-g541410e (34) 18:03:19 -!- Kranix has quit [Ping timeout: 260 seconds] 18:06:49 -!- qguv has quit [Ping timeout: 260 seconds] 18:07:33 -!- dolemite99 has quit [Quit: Page closed] 18:13:56 -!- dtsund has joined ##crawl-dev 18:13:59 'make: command not found' 18:14:30 I've cd'd to crawl/crawl-ref/source and am trying to run 'make TILES=y'. I think I may have done something wrong 18:14:36 msys is installed and updated 18:16:01 did you install the right msys? it has to be a very specific installer and they tend to move around where the link to the right installer is, but if you downloaded the first link on the page i'm pretty sure that won't work 18:16:07 it only has git, no build tools or anything 18:16:38 x86_64, the second link for 64-bit windows 18:16:50 I already had git installed on this computer, maybe that's causing a problem? 18:16:55 it looks like "Git for Windows SDK" might be the right link now https://github.com/git-for-windows/build-extra/releases/tag/git-sdk-1.0.3 18:17:14 not sure what install.txt says 18:17:19 !source install.txt 18:17:20 https://github.com/crawl/crawl/blob/master/crawl-ref/source/contrib/sdl2/INSTALL.txt 18:17:40 huh 18:18:24 -!- LexAckson has quit [Ping timeout: 276 seconds] 18:18:26 -!- kdrnic has quit [Quit: Leaving] 18:18:39 -!- debo has quit [Ping timeout: 265 seconds] 18:18:39 oh maybe everything on windows has changed since i used it last, the install.txt links to something i've never seen before 18:19:03 so disregard my previous link, possibly 18:19:36 there's been a fair amount of thrash in suitable msys2 installations over the past year or so 18:19:38 MarvinPA: yeah, I updated the instructions to use a direct MSYS2 install 18:19:54 I think I'm missing mingw-get 18:20:09 No, that shoudl have been included in the msys2 updates 18:20:15 old msys2 had an ancient pre-C++11 g++, then it was switched to iirc msysgit, then msys2 was updated to something newer than msysgit 18:21:39 well msysgit+winbuilds was what we recommended at the switch to C++11 initially, then it was msys2 through git for windows sdk 18:22:24 so even more thrash >.> 18:23:02 there have been two msys2 installs we've recommended, which is not a lot of thrash 18:23:10 but I won't claim we really know what we're doing 18:23:59 cygwin was fixed by |amethyst and others recently, and there was some incomplete work on MSVC recently 18:24:04 recently 18:24:49 i ended up finding cygwin easier than msys back when i was still compiling on windows, but i've been told i'm crazy for thinking that :P 18:25:13 cygwin is probably a bit easier still 18:26:02 once msys2 fixes the installation issues with menu shortcuts, it'll be as easy as cygwin, but it's still pretty easy. It seems kind of slow though 18:26:10 maybe cygwin is faster compilation wise 18:27:09 i think cygwin it was possible to use ccache at least 18:27:35 that would be very nice, yeah 18:27:39 i don't recall how it compared generally 18:29:39 looks like cygwin has gcc 5.3 and 5.4 even 18:30:23 and mingw, so you can probably cross-compile to a native windows binary 18:36:20 -!- MarvinPA has quit [Quit: Leaving] 18:48:56 -!- lobf has quit [Quit: lobf] 18:50:59 -!- AltReality has quit [Read error: Connection reset by peer] 18:51:03 -!- Shard1697 has joined ##crawl-dev 18:52:06 -!- MarvinPA has joined ##crawl-dev 18:55:48 -!- Patashu_ has joined ##crawl-dev 18:55:55 Brannock: for the old soh tiles, were you interested in using those for tile_player_tile, or did you just want to make sure they're preserved? 18:56:54 former 18:56:58 cool 18:57:15 going to change these enum names though 18:58:28 sounds good. what was wrong with them? 18:58:43 I had a brief discussion on what enum names to use but I'm not sure I understood it 18:59:01 Brannock: you had PLAYER_ in front, which is not a naming scheme we otherwise use for monster tiles 18:59:07 it'd be weird to have that prefix just for those tiles 18:59:17 so I'm using OLD_ (which is the same prefix used in the name of the images) 18:59:37 this is relevant since you have to specify the tile enum name when using tile_player_tile 19:00:02 -!- omarax has quit [Remote host closed the connection] 19:00:08 shouldn't it be MONS_PLAYER_SERPENT_COC? 19:00:09 specifically it'll be tile_player_tile = tile:mons_old_serpent_coc 19:00:11 that I had listed 19:00:15 Ah, okay 19:00:22 yes, I'm saying it shouldn't have PLAYER_ 19:00:25 Gotcha 19:01:28 Annnd I got make to work 19:01:35 turns out I forgot to install mingw-w64 19:02:11 well, are you following the instructions? 19:02:16 those have you install the toolchain package 19:02:27 namely mingw-w64-x86_64-toolchain 19:02:46 you can install the packages individually, of course 19:02:56 Yes, I accidentally skipped over that part in the instructions 19:03:08 Got confused, went back and carefully reread it, realized my mistake 19:03:44 Confused? When reading my instructions?! I..I...*trails off* 19:03:53 kinggod (L12 KoAr) ASSERT(in_non_diamond_int(r.start)) in 'ray.cc' at line 217 failed. (Lair:1) 19:03:55 No, nothing wrong with your instructions 19:04:08 I'm skipping between several different tasks right now and lost my place in your instructions 19:04:37 is this the end of gammafunk? 19:04:48 god willing. 19:05:11 the fun part will be when I get back home and have to redo everything on my desktop 19:05:24 Just toss me into the tornado-shatterstorm-lightning-glaciate, I'm done for 19:06:22 Brannock: don't worry, by the time you get home, we'll have brand new windows installation instructions 19:06:31 newnewnewwindows 19:07:03 -!- Pacra_ has quit [Ping timeout: 250 seconds] 19:07:39 shatterstorm... 19:08:50 how long do builds generally take? 19:08:54 to compile 19:08:55 -!- Dracunos has quit [] 19:09:01 this one has been grinding away for a while 19:09:02 depends on your computer 19:09:06 i remember wheals saying it took a while 19:09:10 on windows 19:09:12 they can take quite some time on windows, yeah 19:09:18 30 mins sometimes on my VM 19:09:19 I'm going to have to learn linux eventually aren't I 19:09:27 buy a mac... 19:09:29 ; ) 19:09:40 that winky-face means "ha ha only serious" 19:09:57 -!- Kellhus has quit [Quit: Page closed] 19:09:57 -!- magistern has quit [Quit: magistern] 19:10:00 yeah, we all know that macs have the best build process ever 19:10:24 and yeah, I'm on a windows 10 machine with an i5-3570 19:10:27 it's been fine for years. 19:11:11 -!- Ququman has quit [Read error: Connection reset by peer] 19:11:34 Brannock: it shouldn't be too bad, but might take 15 minutes from scratch. Cygwin might be faster 19:11:55 that conversation about cygwin made me think maybe we can even recommend that method, especially if it can cross-compile 19:12:00 'from scratch'? so if I make further changes and compile again, it'll go faster? 19:12:19 Brannock: well contribs for one, those will never rebuild after your first build 19:12:40 but yes it will only build files that have 'changed', but changed headers can affect a lot of tiles 19:12:45 yeah, unless you're editing enum.h, you should only have to rebuild whatever files depend on what you changed 19:12:51 well 19:12:56 Good to know 19:12:57 that's also true for enum.h, but everything depends on that. 19:13:02 roughly. 19:13:29 the codebase is pretty big. where should I start reading the code to best understand it? 19:13:52 probably with a specific aim in mind: fixing a bug, making a new feature 19:14:59 it's 400k lines of code, and while there are several classes you need to get familiar with (actor, player, monster, bolt), most people start with something specific they want to change and read what they need as they go 19:15:17 I had a couple changes in mind I wanted to take a shot at. One would be fixing up the auxiliary attacks/mutations thing. I took a look at it earlier and it seems that some of it might be hard-coded on a racial basis. I want to display all auxiliary-attack muts on 'A', deriving from noticing that draconian tailslaps aren't listed anywhere 19:15:42 that seems a big project though, so the other two are just fixing up some language, and to code up a new monster 19:16:00 any monster in particular? 19:16:06 you might remember this one 19:16:08 dream sheep 19:16:22 pack sheep that put you to sleep, checking MR, if enough are on screen 19:16:25 ahh 19:16:31 i assumed those would be replacing sheep 19:16:43 i guess that's moot 19:16:55 I don't have an opinion on whether sheep need to be replaced 19:17:12 I figured they coudl be moved earlier into the dungeon (I frequently encounter yaks long before I find any sheep) and to put dream sheep later on in Lair 19:17:24 and then once that's done, probably look at creating a few vaults? monster layouts? 19:17:36 that's assuming the monster even gets approved 19:17:44 vaults are simpler 19:18:11 wrt sheepers, i'd start by looking at _starcursed_scream() and related functions 19:18:22 that was my thought as well. In fact thats' where I got the inspiration 19:18:24 oh right, sheepcursed masses, that's what i was calling these 19:18:47 i'm like 73% sure i came up with this idea. 19:18:58 You can have the credit if you want 19:18:58 for sheep, one thing to think about is that cyclops get sheep in their bands 19:19:16 this is mostly for flavor right now, but if you buff sheep that will change 19:19:42 could keep regular sheep with cyclopses, and dream sheep with Polyphemus. that might be more interesting than death yaks 19:19:42 I forget if they only get that in shoals or if it's also in D 19:19:50 not in d 19:19:52 ??cyclops 19:19:52 cyclops[1/2]: They throw large rocks. Slow. 19:19:55 ??cyclops[2 19:19:55 cyclops[2/2]: they love sheep. There are no cycsheep though. 19:19:58 lol 19:20:07 lots of sheep posting in CYC imo!!! 19:20:27 oh, PleasingFungus, what'd you think of crypt -> orc 19:20:35 put sheepers in lair 19:20:44 just so both sheep and yaks have a same-branch upgrade 19:20:56 then remove all monsters that aren't sheep, yak or hydra 19:21:00 I'm not sure plain sheep would really need to exist if we had newsheep 19:21:01 replace shadow creac with summon sheep in the book of dreams 19:21:11 you have jackals and yaks to establish pack behavior 19:21:25 ebering: you're a dangerous threat to the natural order of things, I'm keeping my eye on you 19:21:37 does crypt -> orc also involve a elf/crypt roulette 19:21:48 Brannock: seemed reasonable in principle. i feel like there's not much room in orc for more branch entrances, so making elf & crypt alternate would be good, but i think you'd want to have more loot in crypt if that was the case. 19:21:50 gammafunk: a c i d c r a b s 19:22:15 i wonder what the relative danger of crypt and elf is 19:22:27 it's always been odd to me that crypt is as late as it is. 19:22:33 I feel like stats on these would be skewed a lot because of the vault entry requirements 19:22:52 crypt is easier for undead, but that's probably not a balance problem you can do much about 19:23:05 is it a problem 19:23:18 characters having different places to go depending on their build is a good thing imo 19:23:33 imo elf/dwarf roulette 19:23:39 -!- elan has quit [Quit: Page closed] 19:23:45 imo dwarf/sokoban 19:23:50 i saw that thread also lit up the dpeg-signal by suggesting having an elf/crypt->vault staircase 19:24:13 i saw someone say he was either for or against that 19:24:13 randomly opens a telnet connection to a nethack or dwarf fortress server and puts you in that game instead 19:24:56 to allow the player to have fun instead of playing crawl 19:24:58 PleasingFungus: that exact thing is a long-standing dpeg suggestion 19:25:02 haha 19:25:14 i wonder if having loops in the branch graph would cause any bugs 19:25:14 i bet it would 19:25:23 people would be mad at us if we put elf/crypt on a roulette 19:25:25 they like elf more 19:25:28 good 19:25:34 do they like elf more because of the loot? 19:25:38 but they would complain in my stream!!! 19:25:40 i bet you could fix that by just like doubling the loot, yeah 19:25:45 though this comes back to what i said at the very start of this discussion, yeah 19:25:53 yeah 19:26:05 anyway my proposal is just because I think it's a big waste to have crypt sit there dusty and unplayed like that 19:26:26 crypt.. dusty.. heh 19:26:33 most players only see crypt as piety farm or when they powergame through it on a 15-rune run 19:26:58 especially with dracoomega's work that transformed it from something really boring into something that could have genuinely interesting situations 19:27:07 A lot of that choice probably boils down to the fact that crypt ends have a less massive onslought but with fewer loot items 19:27:11 compared to elf 19:27:18 I don't think it's so much about stair location 19:27:23 maybe it has something to do with fighting undead monsters in DCSS is kind of terrible 19:27:27 ? 19:27:29 s:1-3, s:1-3, elf, s:4 19:27:34 you can't do crypt before you clear a s:4 19:27:45 i don't think many people do elf before their first rune 19:27:46 crypt monsters aren't too bad to fight these days 19:27:47 hm 19:27:50 I do, but I'm weird 19:27:57 !lm * elf:3 urune=0 recentish 19:28:03 oh, that's wrong 19:28:09 you want br.end=elf yeah 19:28:27 i was thinking x=count(gid) 19:28:30 yours is simpler 19:28:31 15066. [2016-08-05 21:14:25] clown the Destroyer (L18 NaVM of Cheibriados) killed Donald on turn 31206. (Elf:3) 19:28:36 !lm * br.end=elf urune=0 recentish 19:28:39 -!- debo has joined ##crawl-dev 19:28:43 9373. [2016-08-05 21:13:56] clown the Spear-Bearer (L18 NaVM of Cheibriados) reached level 3 of the Elven Halls on turn 31071. (Elf:3) 19:28:44 !lm * br.end=elf recentish 19:28:45 39929. [2016-08-05 22:20:45] Zukt the Unseen (L19 NaSk of Xom) reached level 3 of the Elven Halls on turn 39033. (Elf:3) 19:28:54 as recent as today 19:29:00 !lg * elf:3 recentish 19:29:01 3794. deafmute420 the Slayer (L20 MiBe of Trog), blasted by a deep elf high priest (divine providence) on Elf:3 (minmay_elf_hall_not_hex) on 2016-08-05 22:17:20, with 308736 points after 42276 turns and 6:21:13. 19:29:04 !lg * elf:3 recentish urune=0 19:29:05 1733. clown the Destroyer (L18 NaVM of Cheibriados), shot by a ghostly deep elf master archer (arrow) (kmap: elf_hall) on Elf:3 on 2016-08-05 21:18:16, with 180246 points after 31831 turns and 2:32:38. 19:29:15 odds are much better for dying there if you go earlier, ofc 19:29:20 and that's not even counting abysses 19:29:24 but yeah point taken 19:29:40 for certain builds I don't think elf 3 is that much more dangerous than a nasty snake or shoals ending 19:29:52 25% of elf entries being 0-rune is not trivial 19:30:03 hm 19:30:06 !lm. br.end=elf s=urune 19:30:13 yeah it's cool to allow that by having elf not require a rune 19:30:14 !lm . br.end=elf s=urune 19:30:21 49 milestones for PleasingFungus (br.end=elf): 30x 2, 11x 3, 4x 1, 2x 4, 2x 0 19:30:36 mine are completely backwards 19:30:37 !lm . br.end=elf s=urune 19:30:38 hence the advantage of the crypt elf roulette 19:30:38 94 milestones for Brannock (br.end=elf): 39x 0, 36x 2, 14x 1, 4x 3, 4 19:30:44 ha 19:30:51 !lg . elf 19:30:52 2. PleasingFungus the Conjurer (L20 GrAE of Ashenzari), shot by a deep elf master archer (arrow) on Elf:3 (elf_hall) on 2014-04-12 05:01:58, with 280612 points after 62510 turns and 4:07:14. 19:30:55 ohh 19:30:58 i remember that guy 19:30:58 crypt/elf roulette in orc could be cool, I guess 19:31:00 -!- Pacra_ has joined ##crawl-dev 19:31:03 that was shooting past one of my allies, iirc 19:31:16 having tomb be a sub-sub-branch would be sort of weird but it could just move to depths somewhere 19:31:22 yeah 19:31:28 -!- Suga_H has quit [Ping timeout: 252 seconds] 19:31:28 -!- staplegun has quit [Ping timeout: 252 seconds] 19:31:31 why not move it to vaults 19:31:39 is tomb not already a sub-sub-branch? 19:31:40 it is 19:31:44 V>C>W? 19:31:48 it would be a sub sub sub branch i guess 19:31:54 or hm 19:31:55 oh i guess so, vaults seems more like a real thing though 19:31:56 no i'm wrong 19:31:58 O>C>W? 19:32:00 ouch 19:32:19 kind of analogous to slime being in lair 19:32:22 rekt 19:32:42 anyway moving it to vaults seems simplest 19:32:42 plus then there's a nice landmark? on your way down vaults 19:32:42 something to add some interest, you know. a local attraction 19:32:42 depths feels pretty crowded with that stuff already 19:32:42 hells, pan, abyss, zig 19:32:48 sure 19:33:22 one thing would be to adapt all those crypt entries into tomb entries 19:33:27 which might include changing monsters 19:33:35 depths does have a lot of portals, especially since you tend to get multiple entries for hell/pan/abyss 19:33:35 lair, 5 sub-branches (3 in any given game). orc, 2 subs (1 iagg). vaults, 1 sub. 19:33:46 maybe there should be one entrance for each of those things on a fixed level 19:33:58 tomb monsters showing up on a vaults floor would be nasty and surprising. challenging. 19:34:04 i wonder if we have any of the old crypt tomb entries from before the tomb entry was moved into the crypt endings 19:34:08 atm crypt monsters showing up on a crypt entrance is shrug-tab 19:34:16 re-using those would be reasonable 19:34:23 just having one of each for hell/pan/abyss portals in depths sounds maybe good yeah 19:34:26 or adapting them 19:34:26 Brannock: killing a few crypt monsters not too hard, and even a single greater is doable 19:34:40 In vaults it's real easy to escape monsters, as well 19:34:45 given all the walls 19:34:53 er 19:34:56 killing a few tomb monsters 19:35:02 random thought: does the occasional hell entrance in lair count as a graph loop 19:35:12 this is a nerd-free zone ok 19:35:42 hell entrances cause weird friggin bugs all the time 19:35:56 well not all the time. but it's known. i think there's at least one standing bug with them reported. 19:35:58 those also end up placing in weird places in vaults 19:36:00 -!- debo_ has joined ##crawl-dev 19:36:09 in what way are graph loops causing bugs? 19:36:11 vaults of the des kind, I mean 19:36:24 -!- debo_ is now known as Guest39433 19:36:29 i suppose even with them only generating once they would still have to be able to show up in weird places in encompass vaults 19:36:48 yeah that's true actually 19:37:15 unless depths encompasses all got specially designated hell/pan entry bits for the case that they generate on that floor or whatever 19:37:17 Brannock: i would be concerned about autotravel 19:37:19 so is this what people are thinking of for the new branch hierarchy http://dpaste.com/0BVQ08J 19:37:37 i bet i missed an obvious branch... 19:37:41 MarvinPA: I think those are certainly all fixable, but I think the code can place them in e.g. random float vaults 19:37:47 so if a vault is bad and has some kind of closet 19:37:48 that looks like what i was thinking 19:38:20 ofc that doesn't have dpeg's legendary elfcrypt-vaults passage 19:38:21 -!- Shard1697 has quit [Ping timeout: 276 seconds] 19:38:27 but that's sort of a different question 19:38:40 just wait until the oubliette is finished... 19:38:54 we do have lab->abyss! 19:38:59 lol 19:40:11 hmm, travis failed on my pull request. not sure I understand the error log but it looks like it had trouble with perl? 19:40:38 -!- Guest39433 has quit [Ping timeout: 244 seconds] 19:41:24 sometimes travis just fails at random, to lull you into a false sense of security 19:41:32 constant vigilance! 19:41:38 my local compile went through no problem 19:42:20 how do I change player tiles on local? 19:42:31 so moving tomb into vaults is probably easy. you might be able to just rename the crypt entrances and replace their monster sets 19:42:35 you need to edit your rcfile 19:42:44 there's a list of places to put an rcfile 19:42:46 somewhere 19:42:56 chequers: that's what gamma was saying 19:42:58 and moving crypt into orc should similarly be simple, since elf traditionally has no entrance vault except the stairs 19:43:15 it might be nice to give crypt entrance ambushes, like elf has 19:43:22 to warn players YO, YOU SHOULD NOT BE HERE 19:43:37 though i guess that's less true now that orc is later? idk 19:43:38 elf does have entrance vaults in orc 19:43:42 -!- lobf has joined ##crawl-dev 19:43:54 btw, a related niggle is that 'crypt' and 'tomb' are really similar names 19:44:00 it's not supposed to place elf monsters in entrance vaults though 19:44:04 what about ossuary 19:44:18 technically similar but nobody knows what ossuary means so it's alright 19:44:22 lol 19:44:31 i don't think i've seen people getting confused, though i wouldn't be shocked if they were 19:44:34 hrm 19:44:36 but if this rework does go through, maybe crypt could be renamed 19:44:40 the fundamental problem is that their theme isn't very strongly separated, i think 19:44:40 mausoleum. sepulcher. catacombs. 19:44:44 I remember when I was new I never remembered which was which 19:44:51 strongly differentiated 19:44:54 maybe crypt could be more about negative energy than about deadness 19:45:02 tomb is the egyptian one and crypt is the generic undead one 19:45:06 like that hell branch i forget 19:45:08 i guess generic is european maybe. look at me be racist 19:45:09 tartarus 19:45:19 the coffin 19:45:24 what's that thing from LOTR 19:45:26 the burial piles 19:45:28 barrows 19:45:43 dwarf fortress should have those 19:45:43 just to cause more confusion 19:45:57 should let you designate a barrow burrow 19:47:30 tomb is clearly themed after the pyramids, but it's not a pyramid 19:47:32 so that's sort of tough 19:47:46 The Barrows. Where champions of old are laid to rest. There you will find skeletons, zombies, ghosts, and various other mortal remnants. 19:48:18 i think barrows is better, for similar reasons as ossuary above 19:48:34 -!- adibis has quit [Ping timeout: 240 seconds] 19:48:47 Halls of the Dead 19:48:51 but I would prefer a reflavour away from "tomb" 19:48:54 Elven Halls of the Dead 19:49:07 chequers: to? 19:49:23 i dunno, i have been trying to think of a negative energy flavour 19:49:35 heh.. Abandoned [Dwarf] Fortress 19:49:39 -!- Pacra_ has quit [Read error: Connection reset by peer] 19:49:47 that would give excuse for an entrance ambush 19:50:02 just move the sphinx ambush to right by the entry stairs, then it won't matter what the name is 19:50:09 people will definitely remember not to go in there again 19:50:26 :) although sphinx is suuuuper tomb-flavoured 19:50:29 PleasingFungus: The multi-floor layout of tomb compared to the more straightforward layouts of most other areas in DCSS is fairly pyramid-y 19:50:41 actual pyramid burial chambers have you going down, up, down again 19:50:50 these things are convoluted 19:50:56 precisely 19:50:56 one of the big problems with pyramid theming is: zigs exist 19:51:14 I wouldn't be to worried about how inconsistent the crawl universe is 19:51:16 i m o 19:51:26 who was talking about inconsistency? 19:51:42 the zig is the pyramid but the tomb is the egypt thing 19:51:44 i unno 19:52:11 it's not inconsistency, it's overlapping themes 19:52:18 Tomb is very, very strongly flavored and themed. I think it's easier and less work to adjust Crypt 19:52:35 having both a Ziggurat and a Pyramid is just as confusing as having a Tomb and a Crypt, if not moreso 19:52:48 yeah if people think crypt->barrow or w/e would help, that's fine by me 19:52:53 PleasingFungus: It's a tomb, not a pyramid. 19:53:01 yeah.. if Zigs didn't exist I would +100 a rename to Pyramid... it's pretty much perfect 19:53:13 and I'd love to see the complaint threads about geometry 19:53:17 i'm not really committed to tomb as a name but it's just really tightly hemmed in by other themes 19:53:29 nikheizen: [16:47] PleasingFungus tomb is clearly themed after the pyramids, but it's not a pyramid 19:53:47 I think it's good that crawl is putting its own twists on references 19:53:48 -!- debo__ has joined ##crawl-dev 19:53:56 instead of making an exact parallel 19:54:03 sure, it's not literally a pyramid, it's just evocative of one 19:54:03 bring back MD 19:54:26 not to be confused with zigfigs, which are evocative of - 19:54:36 spear of botono...? 19:54:54 rename and reflavor ziggurats to Arena 19:54:58 the joke is that you evoke them 19:55:10 prove your champion's might in front of a larger and larger audience! 19:55:14 oh sry 19:55:49 -!- lobf has quit [Quit: lobf] 19:56:46 hm, sounds familiar 19:57:02 yeah, r-i has claim on that theme 19:57:03 unfortunately there is already an arena portal vault wip! so that would have to be renamed too in order to maximize the size of this pile of bikesheds 19:57:15 i hope this ends with renaming every branch 19:57:21 you know, depths and dungeon sound very similar. 19:57:27 (imo crypt and tomb are fine names and bikeshedding forever is bad) 19:57:34 PleasingFungus, I don't know if this was removed, but years ago when playing local tiles I was able to edit player paperdoll directly ingame 19:57:37 eventually... "does dungeon need an entrance ambush?" 19:57:39 Is that still in? 19:57:40 still true afaik 19:57:52 totally unmaintained 19:58:01 chequers: that's what jackal packs are for 19:58:28 -!- debo__ has quit [Ping timeout: 250 seconds] 19:58:29 -!- lobf has joined ##crawl-dev 19:59:15 well I've discovered a crash with the paperdoll menu. 19:59:37 cool! 19:59:49 looks like it crashes if you try to go past boundaries of the list 19:59:55 I'll mantis this 19:59:59 -!- ZiBuDo has quit [Ping timeout: 260 seconds] 20:00:00 go past? 20:00:03 -!- omarax has quit [Remote host closed the connection] 20:00:11 I'm at category 0, press up, game immediately crashes 20:00:20 I go to category n-1, press down, game crashes 20:00:22 -!- ZiBuDo has joined ##crawl-dev 20:01:28 remind me how to get to this menu 20:01:44 -!- MarvinPA has quit [Quit: Leaving] 20:01:52 hang on, testing a non-changed branch to make sure it's not my commit breaking it 20:02:07 but you press - 20:02:24 okay, either 0.19 trunk or my commit breaks it 20:02:29 this might be related to that travis failure I had 20:02:34 wow, | is something 20:02:41 -!- Zekka has quit [Ping timeout: 258 seconds] 20:02:41 -!- kdrnic has joined ##crawl-dev 20:02:45 something to unbind 20:02:47 it almost certainly was not related to the travis bug 20:02:58 crash reproduced 20:03:00 neat 20:03:09 18.1 is stable 20:04:32 hm 20:05:19 should I mantis this for recording purposes? or do you have a handle no it? 20:05:31 i'm looking at it 20:05:37 i don't understand how this code ever worked 20:05:43 as of right now? 20:05:44 it doesn't 20:05:49 -!- ProzacElf has quit [Ping timeout: 260 seconds] 20:06:40 -!- mamgar has quit [Read error: Connection reset by peer] 20:08:32 -!- Kalir has quit [Changing host] 20:08:36 no, as of 0.18. 20:09:06 saying "ever" to mean "right now" would not be very useufl 20:10:49 well, this code is incomprehensibly bad, so feel free to mantis it. 20:11:23 is there a better phrasing than "try to go past boundaries of the list"? 20:12:10 'press the down arrow once' 20:12:14 'etc' 20:12:14 -!- MarvinPA has joined ##crawl-dev 20:12:17 KISS 20:16:27 Paperdoll menu crashes on attempted cursor wraparound. 13https://crawl.develz.org/mantis/view.php?id=10596 by Brannock 20:16:47 well I've had a good day. 1 pull request, 1 bug found 20:16:52 :) 20:16:52 lots of programs installed 20:17:01 What led you to the tiledoll editor, anyway? 20:17:12 Trying to see if I could pull lamia tiles onto the player from there 20:17:19 ahh 20:17:23 instead of through the rcfile? 20:17:26 tile_player_tile = tile:MONS_LAMIA isn't working 20:17:48 oh i need the parentheses 20:17:49 let's do that 20:18:02 no you don't 20:18:06 well then 20:18:10 "tile_player_tile = tile:mons_lamia" this works for me 20:18:18 -!- magistern has quit [Quit: magistern] 20:18:20 try lower case 20:18:31 barring that, i assume your branch broke something 20:18:42 oh, is this on your branch? 20:18:47 yes 20:18:52 one sec 20:19:10 -!- lobf has quit [Ping timeout: 258 seconds] 20:19:13 another dev encouraged me to run a build and see if it worked, and that's what I spent the last few hours doing, installing msys2, etc, compiling, testing... 20:19:15 hm, should work, assuming the recompile finished successfully 20:19:27 i'll test on your branch. 20:21:07 -!- whig has joined ##crawl-dev 20:21:35 works for me 20:21:51 i assume your rcfile isn't being recognized 20:21:57 try setting a fakelang or something else obvious 20:22:05 *something that will be obvious in-game 20:22:11 e.g. pizza option 20:22:37 oh 20:22:39 I found the problem 20:22:42 init.txt.txt 20:23:00 lol 20:23:17 hm, these new tiles could use some weapon offsets, maybe. my axe is covering up my serpent of hell's face 20:23:19 lame 20:23:32 pizza option? a-la nethack fruit? 20:23:37 iirc weapon & shield offsets are in tilemcache.cc 20:23:45 i guess you want to turn them off entirely? 20:23:51 nikheizen: probably, though i haven't played nethack 20:24:26 what is the option line like? 20:24:57 pizza = chicago-style, deep dish, blood 20:25:21 it used to be a command line option 20:25:23 many years ago 20:25:29 okay, good to know my stuff works 20:25:34 time to look at other stuff and maybe break more stuff 20:25:44 cute 20:26:04 -!- lobf has joined ##crawl-dev 20:26:07 i'm fond of it 20:26:42 what are the differences between a CC, D, H, and O file? 20:27:13 d and o are both generated by compilation and not really intended to be touched by humans 20:27:26 especially o 20:27:30 woo, yeah 20:27:34 just opened that one 20:27:37 haha 20:27:40 binary, baby 20:27:45 CC is the code, H is a listing of all the "exported" functions in the corresponding CC file 20:27:47 cc is a source file, h is a header file. there's no actual difference between them, just conventions 20:27:58 what chequers said is the convention 20:28:15 but you can put whatever in either 20:28:27 although it would be rude 20:28:34 enh 20:28:52 i wonder if there are any really good explanations of c's #include anywhere 20:29:08 i could give the whole spiel, it's fun, but i'd hate to duplicate effort 20:29:09 cplusplus.com maybe? 20:29:13 plausible! 20:29:21 all I know is java and a smattering of python 20:29:36 so diving into a C++ codebase is a big jump for me 20:29:40 what do people think of the silent spectre race idea 20:29:51 i'm not sure i saw that 20:29:55 was that the one in cyc? 20:30:03 yes 20:30:05 Brannock: #include serves a similar role to java or python's import 20:30:10 from bcadren 20:30:14 it's called import in java, right? it's been ages 20:30:19 oh, bcadren thread, i wouldn't have read that. 20:30:24 it is 20:30:29 note that crawl doesn't have a namespace for all its files 20:30:40 oh please don't bring namespaces into this, let's try to keep this simple 20:31:02 well, if Brannock has a python/java background, importing adds a namespace 20:31:03 -!- debo_ has joined ##crawl-dev 20:31:05 -!- Shard1697 has joined ##crawl-dev 20:31:14 so #include foo.h is like `from foo import *` 20:31:15 yeah, #include is much simpler than that 20:31:26 -!- debo_ is now known as Guest78566 20:31:32 it simply says, "replace this line with the entire contents of the given file" 20:31:35 I'm looking at (randomly chosen) describe-spells.cc and describe-spells.h and they don't seem to share any code at all. so the purpose of separating them is ... 20:31:49 ? 20:32:07 great file choice, btw. top notch. that file is probably the best-written file in all of crawl, written by the handsomest coder 20:32:20 a tremendous person 20:32:23 oh yeah. 20:32:28 Brannock: the way you 'export' a function is you copy the function's header into the H file 20:32:49 so you will see this line in the H spellset item_spellset(const item_def &item); 20:32:51 chequers: i don't want to be rude, but can i handle this? you keep making up terms 20:32:52 but the full function in the CC 20:32:57 :) ok 20:33:19 Brannock: do you know the difference between declaring something and defining it, in code? 20:33:26 java has that concept, i'm like 99% sure 20:33:27 I am not a very experienced programmer 20:33:33 (no) 20:33:41 ok. 20:34:17 declaring something is laying out the outlines of it. like, take chequers' example (great guy, chequers. wonderful. the best.) "spellset item_spellset(const item_def &item);" 20:35:37 uh oh... i detect some computer science coming on... i'm outta here! 20:35:40 this is saying "a function exists called item_spellset. To call it, pass in a value of type 'const item_def &', and you'll get a value of type 'spellset' out." 20:35:40 or you could have a function called "int random2(int max)", which takes an int and returns another int. 20:35:40 Does that make sense so far? 20:35:41 lmao 20:35:48 go make a scoring page!!! 20:36:07 fine 20:36:09 -!- Alcopop has quit [Quit: Page closed] 20:36:10 :P 20:36:41 -!- Guest78566 has quit [Ping timeout: 244 seconds] 20:36:41 I follow 20:37:14 OK. So that's the declaration, the outline. The definition is saying what the function (or class, whatever) actually does - the full body of it. 20:37:20 !source item_spellset 20:37:20 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/describe-spells.cc#L36 20:37:56 That's the definition for item_spellset(). You'll note it's in the .cc, while its declaration is in the .h. 20:38:06 so item_spellset is declared in describe-spells.h, defined in describe-spells.cc 20:38:13 Yes. 20:38:20 There's a couple of reasons we do things this way. 20:38:22 should probably mention that in cpp a function must be declared(not defined) in the code before it can be called 20:38:24 So, judging from the relative size of each file, .h is the "summary"? 20:38:35 you could think of it that way, sure. 20:38:40 no jumping ahead in the book! 20:38:45 It's a bad habit of mine 20:38:49 :P 20:39:00 the .h is what the outside world knows about the code, whereas the .cc is the details. 20:39:54 One reason we do that way is for capsulization, so we can simplify things. The world doesn't need to know exactly *how* we produce our results; we just give them our 'signature', the required inputs and the output, and they can operate based on that. 20:40:03 so if I wanted to call a function (or its equivalent in C++), I'd point at the .h file, and let the .h file handle the .cc details 20:40:21 That's basically right. 20:40:51 There's a similar concept in Java but it escapes me right now. (I slept through most of my CS classes) 20:40:58 lol 20:41:07 yeah, i was trying to phrase things in a java cs class sort of way there 20:41:12 though it's been a long time now. 20:41:44 The other reason we do things this way is to avoid circular reference issues. We can end up in situations where two files, or even two functions, both want to call the other. 20:42:47 Separating the declaration from the definition lets that work; otherwise, you'd end up in a situation where A needs to be defined so B can call it, but A needs B to be defined first... 20:43:12 what is the declaration/definition distinction in java that you alluded to 20:43:26 i thought it existed but it's been a while 20:43:40 probably, uh, the better part of a decade since i've done anything in java 20:43:43 i don't remember ever seeing it but i am a great fool so you may well be right 20:43:56 http://stackoverflow.com/questions/11715485/what-is-the-difference-between-declaration-and-definition-in-java BOOM headshot 20:44:15 oh apparently it doesn't really exist 20:44:19 BOOM self headshot 20:44:22 hah 20:44:47 man, i wonder where i learned about it, then? maybe in some other college class 20:46:06 fwiw i contribute code to crawl without knowing this and the code even works after several code reviews where I ask |amethyst repeatedly for the solution 20:46:17 03Isaac Sloat02 {gammafunk} 07* 0.19-a0-1074-gc7f35b9: Preserve old uniques for tile_player_tile 10(3 hours ago, 14 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/c7f35b930a46 20:46:17 03gammafunk02 07* 0.19-a0-1075-g8bc95f2: Move a tile to the right directory and rename tile enums 10(46 minutes ago, 3 files, 6+ 6-) 13https://github.com/crawl/crawl/commit/8bc95f2911e1 20:46:17 03gammafunk02 07* 0.19-a0-1076-g86538d7: Clean up wording in the install instructions 10(13 minutes ago, 1 file, 20+ 21-) 13https://github.com/crawl/crawl/commit/86538d7e981a 20:46:22 fundamentals are important! 20:46:42 hm, do we need to add Brannock to CREDITS.TXT 20:46:43 need to add Brannock to the mailmap 20:46:45 and that 20:46:48 :p 20:46:49 yeah, please go ahead 20:46:54 -!- zeroDivisible has quit [Quit: ZNC - http://znc.in] 20:46:55 I might already be on there 20:47:14 no, i'm off to make dinner 20:47:18 thank you for the explanation PF 20:47:21 It was very helpful 20:47:23 it's gonna be some real good curry. i'm excited already 20:47:41 I'm not even being flattering, it made sense and now I understand the setup better 20:49:16 -!- contrafett has quit [Quit: Page closed] 20:49:17 -!- elliptic has joined ##crawl-dev 20:50:09 elliptic: silence spectre race? 20:50:45 chequers confirmed for Bcadren 20:51:29 i'm not sure i'm going into bat for the idea myself but i am looking for something to implement 20:51:29 Brannock: Do you prefer credit as Brannock or your real name? 20:51:31 My real name 20:51:36 cool 20:51:54 Thanks for the cleanup on my commit message and code, by the way, gammafunk 20:52:26 -!- aditya has quit [Read error: Connection reset by peer] 20:54:06 np, standard procedure 20:54:31 03gammafunk02 07* 0.19-a0-1077-g1ea189a: Add Brannock to mailmap and CREDITS.txt 10(84 seconds ago, 2 files, 2+ 0-) 13https://github.com/crawl/crawl/commit/1ea189ace982 20:54:39 %git :/Preserve 20:54:39 07Brannock02 {gammafunk} * 0.19-a0-1074-gc7f35b9: Preserve old uniques for tile_player_tile 10(3 hours ago, 14 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/c7f35b930a46 20:54:42 there we go 20:55:04 -!- lobf has quit [Ping timeout: 264 seconds] 20:55:06 -!- lobf_ has joined ##crawl-dev 20:56:36 Brannock: no prob, i love talking about this stuff 20:56:42 very glad i helped! 20:56:44 You know, I've been playing this game for nearly a decade now 20:56:52 It feels good to actually contribute to it now. Even in such a minor way 20:57:18 -!- xormask has quit [Disconnected by services] 20:57:21 -!- xorxor is now known as xormask 20:57:49 -!- xormask has joined ##crawl-dev 20:58:43 awww 20:59:02 +1 21:00:02 -!- omarax has quit [Remote host closed the connection] 21:00:39 -!- zeia has quit [Ping timeout: 260 seconds] 21:00:54 -!- cait has quit [Ping timeout: 276 seconds] 21:01:41 -!- MaxFrosty has quit [Remote host closed the connection] 21:01:44 -!- MaxFrost has quit [Ping timeout: 250 seconds] 21:04:34 -!- magistern has quit [Quit: magistern] 21:07:49 Hi guys I was working on a patch that allows you to pick up books, add them to your "library" and then memorize spells from them using the M key without having the book in your inventory 21:08:02 but I almost feel like it winds up losing something 21:08:14 since the optimal thing to do is just pick up book, add to library, drop book 21:08:25 Does anyone have thoughts? 21:08:54 probably you'd want to allow skipping the 'pick up' part 21:09:05 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1077-g1ea189a (34) 21:09:30 well that sort of clashes with the whole, need to pick up the book to id it 21:09:34 you don't\ 21:09:42 you don't need to pick up a book to id it. 21:09:43 you can read it from the ground 21:09:49 how do I do that? 21:09:58 once you memorise the book the book is destroyed 21:09:58 r, 21:10:19 btw if you submit a patch that makes books that you stand on be auto-ID'd, we would accept that 21:10:33 we want to do that but it's not immediately obvious how, technically 21:10:38 and we're very lazy 21:10:45 Ok I was just about to say that I wasn't sure how to do that 21:10:48 :) 21:10:58 I'll take a look 21:11:14 anyway at the least your patch should allow adding stuff to the library when (r)eading a book from anywhere (inv or floor), and probably should automatically do so 21:11:20 unless your library is limited in some way? 21:11:27 but then it seems redundant with spell limits 21:11:32 I wasn't planning on making the library limited 21:11:37 could all books just be always identified? 21:11:56 My plan was to just have a key in the read screen 21:12:00 you could hit to add it to your library 21:12:01 maybe 21:12:13 maybe an option that autoadded to the library would be good 21:12:22 but I think always adding to the library would be bad because of clutter 21:12:52 chequers: think of the dynamic tension on seeing a book in a pan lord vault! 21:13:48 I think books shouldn't be auto id'd personally since there are some low level vault situations where you don't know if you want to dash for the book or not 21:14:36 -!- debo__ has joined ##crawl-dev 21:14:49 -!- } has quit [] 21:16:22 Also when I said "losing something" I more meant from the importance of books. With this patch books sorta just become boring... but maybe I'm still clinging to my newbieness 21:17:01 why are you making this patch? 21:17:08 Because I hate drowning in books 21:17:11 especially with sif 21:17:16 lol 21:17:20 (which brings up the question should this just be a sif change) 21:17:56 PleasingFungus: dynamic tension is a good band name 21:18:34 -!- debo__ has quit [Ping timeout: 240 seconds] 21:19:06 it's apparently a 1920s fitness fad 21:19:33 which is similar 21:25:21 -!- debo_ has joined ##crawl-dev 21:25:40 -!- debo_ is now known as Guest63242 21:26:37 -!- bitcoinbastard has quit [Ping timeout: 265 seconds] 21:27:22 -!- ophanim has quit [Quit: Leaving.] 21:29:26 should all instances of 'the dungeon' be 'the Dungeon'? Does 'the dungeon' contain 'Dungeon' along with 'Depths' and 'Zot', or does Dungeon encompass itself as well as U/Z? 21:30:17 these are great questions. i nominate that someone create a crawl style guide that answers them 21:30:29 -!- Guest63242 has quit [Ping timeout: 260 seconds] 21:30:47 other style issues: the proper capitalization of the orb of zot, or as i like to call it, the ORB 21:30:53 there isn't one? I'm surprised dpeg hasn't written one 21:30:57 i guess MarvinPA ruined that tho :( 21:31:54 i don't believe there is one 21:36:10 what is a HUP? Looking at player-stats.cc 21:36:21 https://en.wikipedia.org/wiki/SIGHUP 21:36:29 Thank you 21:37:43 np 21:37:58 -!- Patashu_ has quit [Ping timeout: 252 seconds] 21:38:01 they're an edge-case thing 21:39:14 I can find mpr.h but not mpr.cc 21:40:32 Brannock: not all headers have cc files 21:40:53 some define data or collect function declarations that may be spread across various files 21:40:54 I suppose it isn't important that I know exactly what mprf() does 21:40:59 I can deduce most of it 21:41:00 haha, there's a note here about the historical accuracy of Summon Greater Demon 21:41:06 Brannock: message.cc iirc 21:41:12 but it's hugely complex 21:41:14 what do you want to know? 21:41:31 was curious after looking at player-stats 21:41:37 Brannock: if you want to see/look up functions, you can use a system like ctags 21:41:42 the message for leveling up your stats is the same as for Human as it is for Demigod 21:41:46 Even though Demigod get 2x the boost 21:41:49 mprf is defined in message.cc 21:41:51 So a totally unspoiled player 21:41:56 has no warning that he's going to get a double investment 21:42:03 so I was thinking of changing that 21:42:34 what to? 21:42:47 also i'm nearly sure that the description of demigod should mention that somewhere 21:42:52 current message is: "Your experience leads to an increase in your attributes!" 21:43:01 It does, let me look up the specifics 21:43:10 the manual is clearly spoilers 21:43:15 no normal player has access to the information therein! 21:43:22 Do we have statistics on how many people read the manual? 21:43:29 No, I suppose that couldn't be tracked 21:44:02 We have yet to implement total surveillance, but it's on the TODO 21:44:26 Big Brother Zot 21:44:54 -!- sysice has quit [Quit: Page closed] 21:45:57 from the manual: 21:45:58 Demigods 21:45:58 Demigods are mortals with some divine or angelic ancestry, however 21:45:58 distant; they can be created by a number of processes, including magical 21:45:58 experiments and the time-honoured practice of interplanar miscegenation. 21:45:58 Demigods look more or less like members of their mortal part's species, 21:45:59 but have excellent attributes (Str, Int, Dex) and are extremely robust; 21:46:01 they can also draw on great supplies of magical energy. On the downside, 21:46:03 they advance more slowly in experience than any other race, gain skills 21:46:05 slightly less quickly than Humans and, due to their status, cannot 21:46:08 worship the various gods and powers available to other races. 21:46:21 recommended: pastebin or source links 21:46:25 good idea 21:46:37 what is the syntax for linking source? 21:46:52 !source dat/descript.species.cc:55 21:46:53 Can't find dat/descript.species.cc. 21:46:55 fuck 21:47:01 !source dat/descript/species.txt:55 21:47:01 https://github.com/crawl/crawl/blob/master/crawl-ref/source/dat/descript/species.txt#L55 21:47:04 i'm so cool 21:47:06 !source crawl_manual.txt:1648 21:47:07 https://github.com/crawl/crawl/blob/master/crawl-ref/docs/crawl_manual.txt#L1648 21:47:17 hey... 21:47:28 oh 21:47:30 is that generated? 21:47:35 no 21:47:37 well, sort of 21:47:40 -!- MaxFrost has quit [Ping timeout: 250 seconds] 21:47:43 but not really 21:47:50 !gitgrep [Mm]anual 21:47:51 %git HEAD^{/} 21:47:51 07gammafunk02 * 0.19-a0-1077-g1ea189a: Add Brannock to mailmap and CREDITS.txt 10(55 minutes ago, 2 files, 2+ 0-) 13https://github.com/crawl/crawl/commit/1ea189ace982 21:47:53 !gitgrep [Mm]anual 1 21:47:54 %git HEAD^{/1} 21:47:54 07Brannock02 {gammafunk} * 0.19-a0-1074-gc7f35b9: Preserve old uniques for tile_player_tile 10(4 hours ago, 14 files, 12+ 6-) 13https://github.com/crawl/crawl/commit/c7f35b930a46 21:47:56 !source crawl_manual.reST:1558 21:47:56 https://github.com/crawl/crawl/blob/master/crawl-ref/docs/crawl_manual.reST#L1558 21:47:58 !gitgrep 1 [Mm]anual 21:47:58 %git HEAD^{/[Mm]anual} 21:47:58 07MarvinPA02 * 0.19-a0-1044-gf355b5f: Sync manual from wiki 10(6 days ago, 1 file, 6+ 13-) 13https://github.com/crawl/crawl/commit/f355b5fa022a 21:48:02 there we go 21:48:11 yeah, that's it above 21:48:16 just have to link to the reST file 21:48:36 the txt file is generated from that, so it's not in the repo 21:48:40 ah 21:48:55 -!- Pacra has joined ##crawl-dev 21:49:17 -!- MaxFrosty has quit [Ping timeout: 244 seconds] 21:49:20 thanks for the explanation. okay, so the manual and species.txt both refer to divine/excellent attributes, but not directly to the levelup mechanic. 21:50:05 possibly because i forgot to update them after changing it 21:50:14 or possibly because someone was being cute and coy 21:50:26 i'd bet option a for the manual and option b for species.txt 21:50:29 I don't think those blurbs are meant for specifics of how stats level op 21:50:31 yeah 21:50:37 should specific mechanics be directly explained in concise summaries? 21:50:38 *level up 21:50:39 the species.txt thing, anyway 21:50:49 i mean, i'm not sure it's much of a spoiler 21:50:58 you find out the first time you get a dg to xl 3 21:51:02 I suppose it doesn't matter in the grand scale of things 21:51:14 if you have a good message change in mind, i think that'd be fine 21:51:35 "... leads to a {great | divine} increase in your attributes", something along these lines? 21:51:44 Nothing esoteric 21:55:49 oh 21:55:54 i meant in player-stats 21:56:51 yes 21:57:12 current message is simply "an increase", I propose demigods get "a great increase" or "a divine increase" 21:57:19 to signify that the upcoming decision is extra demigoddy 21:57:21 -!- cait has quit [Ping timeout: 250 seconds] 21:58:25 sure 22:00:03 -!- omarax has quit [Remote host closed the connection] 22:01:59 -!- eb has quit [] 22:02:02 coding formatting looks different for #ifdef TOUCH_UI. I take it this is for the Android version. Will if-elses work fine there? Should the statements inside the clause be indented? coding_convention.txt doesn't cover this. 22:02:33 ?/ball ligh 22:02:34 Matching terms (2): ball_lightning, conjure_ball_lightning; entries (19): aerie_vault[1] | air_miscast[1] | Allahu_ackbar[1] | b0rsuk[4] | ball_lightning[1] | ball_lightning[2] | ball_python[2] | book_of_the_sky[1] | chris[5] | disc_of_storms[1] | list_of_spells_by_school[1] | list_of_spells_by_spell_level[6] | lom_lobon[1] | sacrifice_love[1] | sacrifice_love[2] | sleepwalking[3] | trivia[1] | ve... 22:02:39 ??ball lightning 22:02:39 ball lightning[1/3]: Like a giant spore, but zappier; explodes for 3d20 elec damage. They don't exist naturally, but Conjure Ball Lightning (L6 C/A in Sky) can make them, and are also in rare abyss, swamp, and aerie vaults. Cannot be conjured over water or lava. Remember that ones conjured will explode when they time out! 22:02:43 conjure 22:02:53 couldn't remember if it was that or call 22:03:36 Brannock: that ifdef just means "this code is only included if the game is compiled with specific options set" 22:03:41 in this case, yes, android 22:04:00 we don't indent code inside ifdefs 22:04:01 It's not like racial stat gain is noted for any other species 22:04:05 (possibly that should be in the guide?) 22:04:18 basically, your code needs to work both if the code in the ifdef exists, and if it doesn't 22:04:21 -!- gressup has quit [Read error: Connection reset by peer] 22:04:31 minmay: yeah, i think i'm persuaded on that one 22:04:31 minmay, racial stat gain is automatic though 22:04:44 wrt manual & species.txt descriptions 22:05:30 so inside an ifdef, if I write an if-else, the code inside the if statement should be on the same indentation level as the if? 22:06:02 what 22:06:21 pastebin inc 22:06:21 hit me with a pastebin 22:06:51 http://pastebin.com/H55BLGrb 22:07:24 by "not indented", i meant "no extra layer of indentation" 22:07:36 code formatting is unaffected by existence of ifdefs 22:07:40 Gotcha 22:07:52 also there's a much cleaner way to do that 22:08:15 Lay knowledge upon me 22:08:26 at the start of the function, create a const string using makestringf 22:08:59 makestringf("Your experience leads to a%s increase in your attributes", you.species == SP_DEMIGOD ? " divine" : "n") 22:09:25 That is much cleaner, yes 22:09:35 use that for the bottom mprf. for the android menu entry, you'll want to tack "Increase: " onto the end 22:09:51 concatenate with a + or with another make_stringf 22:10:34 the mprf might end up giving you warnings; i can explain how to fix those if they show up 22:13:01 -!- Bammboo has quit [Ping timeout: 265 seconds] 22:13:35 03PleasingFungus02 07* 0.19-a0-1078-gf9017aa: Update the spell schools guide 10(75 seconds ago, 1 file, 40+ 34-) 13https://github.com/crawl/crawl/commit/f9017aa3e8ff 22:14:30 -!- CanOfWorms has joined ##crawl-dev 22:14:48 ^ i really love the careful description of "indirect movement via magic" 22:15:08 That is good 22:15:18 Or, was 22:16:30 a lot of good stuff in that doc 22:16:45 i like the careful description of why transmutations doesn't cover weapon brand spells 22:16:52 or the historical notes on demon summoning 22:18:18 You have a floating ) 22:18:25 fucked up 22:18:28 in Translocations. portal to the Abyss) 22:19:36 got it. anything else? 22:19:48 doing a second-over 22:20:34 -!- ZiBuDo has quit [Ping timeout: 260 seconds] 22:21:06 I think you're good to go 22:21:11 sweet 22:21:32 -!- linc186 has quit [Client Quit] 22:22:06 03PleasingFungus02 07* 0.19-a0-1079-g88a7474: Spell school guideline tweaks (Brannock) 10(49 seconds ago, 1 file, 7+ 3-) 13https://github.com/crawl/crawl/commit/88a7474ef903 22:24:34 -!- dtsund has quit [Ping timeout: 258 seconds] 22:25:22 I'm getting a compile error: 'MGSCH_INTRINSIC_GAIN' was not declared in this scope 22:25:48 throw your diff at me 22:25:55 i don't know anything but is it MSGCH rather than MGSCH 22:26:01 haha 22:26:03 whig got it 22:26:17 or, at least, you're using both in your pastebin 22:26:21 which is a little suspicious 22:26:22 now how did that happen 22:26:23 -!- debo_ has joined ##crawl-dev 22:26:29 late-onset dyslexia 22:26:31 v sad 22:26:47 -!- debo_ is now known as Guest75238 22:28:24 -!- valrus_ has quit [Ping timeout: 250 seconds] 22:30:06 if conjurations are always damage spells how do you explain meph????? 22:30:38 an abomination 22:30:40 also 22:30:42 meph does damage 22:31:50 -!- amalloy is now known as amalloy_ 22:32:04 -!- fufumann has quit [Quit: Leaving] 22:32:43 PleasingFungus, how do I show a diff to you? 22:32:51 push commit and link? 22:33:01 I can't get this to compile. something about no known conversion 22:33:08 this would be a lot simpler if you were on a real os 22:33:18 I have a suspicion I eventually will 22:33:32 -!- Guest75238 has quit [Ping timeout: 240 seconds] 22:33:37 do something with your silly gui client, or run git diff on the command line and then copy-paste the result into a pastebin 22:33:54 if you're allowed to copy-paste from Windows' terrible command line 22:34:59 I did git diff player-stats.cc and it threw the *entire* file at me. 22:35:06 -!- neizenel has joined ##crawl-dev 22:35:17 you should just be able to type, literally, git diff 22:35:17 All I want to do is change the text a littl :< 22:35:25 it sounds like you changed line endings 22:35:39 your editor might be screwing you, if so 22:35:53 using Sublime Text 22:36:01 WRT the line for ice magic "can produce direct damage (with a focus on 22:36:01 +damage that partially ignores elemental resistances)"-isn't it just icicle and glaciate that do this? 22:36:30 that's more partially-ignore-resists spells than any other school has 22:36:33 i think 22:37:08 bolt of magma and venom do, don't they 22:37:10 "threw the entire file" - probably changed the line endings from unix to dos 22:37:19 parrow definitely does 22:37:22 bolt of magma does yeah 22:37:33 so that's 2 for fire as well 22:37:36 ??venom bolt 22:37:36 venom bolt[1/2]: A level 5 conjuration/poison spell - it is a penetrating punch of pure poisonous power. Please perceive that pests partially protected from poison (as opposed to prohibitively protected; includes most living and demonic creatures) will proceed to procure piddling punishment. To-hit:8+power/20. 22:37:38 venom does not 22:38:06 http://pastebin.com/Ev8hJfSL 22:38:10 and level 9 spells are kinda different, imo... in that they all do at least some damage to everything 22:38:17 not sure if that's understandable, but that's what git shell gave me when I ran git diff 22:38:22 -!- nikheizen has quit [Ping timeout: 250 seconds] 22:38:25 minus tornado vs. air elementals for whatever reason 22:38:42 fire storm does no damage to that little vortex monster 22:38:45 fire vortex 22:39:01 ah well 22:39:08 yeah, that diff looks fine, Brannock 22:39:15 in terms of it being a proper diff 22:39:23 that's probably to make it less annoying targeting, yeah? 22:40:07 yep 22:41:41 !source MenuEntry 22:41:42 1/2. https://github.com/crawl/crawl/blob/master/crawl-ref/source/menu.h#L110 22:42:14 -!- nikheizen has joined ##crawl-dev 22:44:00 -!- Dracunos-m has quit [Ping timeout: 250 seconds] 22:45:36 -!- neizenel has quit [Ping timeout: 244 seconds] 22:46:57 the old text about transmutations excluding weapon brands is funny now that people are talking about how transmutations should include things besides unarmed 22:47:31 maybe in an alternate universe, brand spells would have stayed in, but become tmut spells as a charms nerf... 22:47:50 well, I guess there are a couple still. 22:49:12 ya 22:50:25 honestly now that I've said it that doesn't seem crazy to me 22:50:51 PleasingFungus, there's the diff. (turns out git shell works better for this stuff than msys, who knew) 22:50:51 but there's not huge incentive for that either 22:55:34 -!- ig0rbit has quit [Ping timeout: 258 seconds] 22:57:48 -!- Cimanyd has quit [Quit: Page closed] 23:00:02 -!- omarax has quit [Remote host closed the connection] 23:00:03 -!- cojitoo has quit [Quit: Leaving] 23:08:55 Unstable branch on crawl.jorgrun.rocks updated to: 0.19-a0-1079-g88a7474 (34) 23:10:48 -!- squidcat has quit [Ping timeout: 250 seconds] 23:14:55 -!- Jafet has quit [Ping timeout: 250 seconds] 23:19:55 -!- amalloy_ is now known as amalloy 23:36:52 -!- neizenel has joined ##crawl-dev 23:39:31 -!- nikheizen has quit [Ping timeout: 252 seconds] 23:50:11 -!- rossi has quit [Ping timeout: 244 seconds] 23:59:09 -!- zeia has quit [Ping timeout: 260 seconds]