00:00:02 -!- omarax has quit [Remote host closed the connection] 00:00:25 Naruni: yeah, I don't think you really want to be using gitk for making patches in general, I guess 00:00:33 probably just use the cli tools for patch making/applying 00:01:01 it does make those diffs for you, but don't work with all your changes only in the working dir and uncommited 00:01:04 Unstable branch on CRAWL.XTAHUA.COM updated to: 0.19-a0-36-g4a0968a (34) 00:01:14 for short changes that's fine but for any serious work that's going to lead to trouble 00:02:24 -!- grobolom has quit [Quit: Page closed] 00:03:54 Stable (0.18) branch on CRAWL.XTAHUA.COM updated to: 0.18-b1-22-ge198996 00:06:55 gammafunk, so if i am rewriting a function, how frequently should i be making commits? 00:07:45 i just made a couple lines of change which i KNOW are good and simple, but i'm about to cut a whole block and move it out 00:07:56 should i commit before or after? 00:08:02 Naruni: well, you can make as many or as few as you like really, but if you're stopping work for a while or hit some important milestone, that's a good time 00:08:07 -!- AreBrandon has quit [Quit: Leaving] 00:08:42 better to commit more rather than less. it's easy to erase a commit, but harder to insert one in the middle of history 00:08:43 typical things is something really fast like git commit -m 'refactor foo() some more' 00:09:08 I often use git commit -a as well, but you have to watch pulling in changes you didn't want 00:09:28 if you don't use -a you can add only the changes you want with git add -p 00:10:20 yeah squashing/deleting/moving is easier than making a new commit represnting a partial change you'd like to have as its own commit 00:10:24 but all can be done 00:10:46 `git add -A -p` ftw 00:11:37 you don't get your full guru medal until you've edited a chunk successfully with git -p 00:11:50 and it has to be right the first time you edit it! 00:12:31 dang. gammafunk must have in his bashrc `alias git='git add'` 00:13:03 I did but then neil forbade me to use bash aliases because they're degenerate 00:14:42 -!- thrig has quit [Ping timeout: 246 seconds] 00:14:51 -!- geekosaur has quit [Ping timeout: 250 seconds] 00:16:17 my favourite alias which I only occasionally use is called `git definitelypush`: !git stash && git fetch && git rebase && git stash apply && git push -f 00:16:21 you're all welcome 00:18:43 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 00:19:09 -!- debo__ has joined ##crawl-dev 00:19:29 huh i just learned something - variables can be used across a whole switch statement in different cases 00:21:07 chequers: as of a recent version of git, there's a rebase.autostash option now 00:21:07 doy: You have 1 message. Use !messages to read it. 00:21:08 -!- geekosaur has joined ##crawl-dev 00:21:44 doy: woooooah 00:21:53 it's pretty great 00:29:59 just need to wait 3yrs for osx to update 00:31:26 brew install git? 00:32:57 -!- Dracunos has quit [Read error: Connection reset by peer] 00:37:00 -!- Lightli has joined ##crawl-dev 00:37:15 -!- debo__ has quit [Ping timeout: 260 seconds] 00:37:37 -!- Shasbat has quit [Ping timeout: 250 seconds] 00:42:05 static_cast is amazing 00:42:29 then i found const_cast 00:42:32 mind blown 00:44:06 -!- LordSloth has quit [Quit: Leaving] 00:47:35 -!- namelastname112 has quit [Ping timeout: 250 seconds] 00:48:27 -!- codecimal has quit [Ping timeout: 250 seconds] 00:54:21 FUUUCK 00:54:53 *rocking back and forth* read_scroll doesn't take item_def&... read_scroll doesn't take item_def&... read_scroll doesn't take item_def&... read_scroll doesn't take item_def&... 00:55:23 ??crawlcode 00:55:23 crawlcode[1/2]: Come get some. ~ https://twitter.com/crawlcode 01:00:03 -!- omarax has quit [Read error: Connection reset by peer] 01:01:34 dude those are funny 01:02:50 its ok though, NOTHING else calls read_scroll so i think i can safely change it to take an item_def& instead of an int 01:02:56 (famous last words) 01:07:03 -!- home has quit [Remote host closed the connection] 01:09:35 Pre-release branch on crawl.develz.org updated to: 0.18-b1-22-ge198996 (34) 01:13:59 -!- CanOfWorms has quit [Quit: ChatZilla 0.9.92 [Firefox 3.6.28/20120306064154]] 01:16:05 -!- Daekdroom has quit [Quit: Leaving] 01:16:51 hrmm, so void read(int slot) does a bunch of logic then calls read_scroll(slot); which sucks because read_scroll is expecting an inventory item via slot but ive modified read() to change slot to be a floor item... 01:17:16 any ideas on how to get read_scroll(int slot) to identify if the slot is actually in the inventory? 01:17:28 it seems very circular and bug-filled 01:23:19 maybe il have to make a function read_scroll_from_ground if the bool dictates 01:24:05 !source start_delay 01:24:05 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/delay.cc#l155 01:24:24 -!- elliptic has quit [Quit: Leaving] 01:25:48 -!- hellmonk has quit [Quit: Page closed] 01:26:58 -!- Zeor has quit [Quit: Leaving.] 01:27:03 -!- elliptic has joined ##crawl-dev 01:32:06 -!- Zxpr1jk has quit [Remote host closed the connection] 01:32:50 -!- amalloy is now known as amalloy_ 01:36:31 amalloy_, could i tap your brain for a minute? 01:48:22 -!- eb has quit [] 01:50:52 -!- Blazinghand has joined ##crawl-dev 01:52:46 -!- filthy has quit [Quit: please don't look for me] 02:00:03 -!- omarax has quit [Remote host closed the connection] 02:00:20 it appeasr &f crashes in current crawl 02:00:23 something about a bad mid 02:03:28 @??snorg 02:03:28 Snorg (09T) | Spd: 10 | HD: 8 | HP: 78-111 | AC/EV: 0/10 | Dam: 20, 1509(claw), 1509(claw) | 10doors, regen | Res: 06magic(60) | XP: 1135 | Sp: berserker rage [11!AM, 06!sil] | Sz: Large | Int: human. 02:03:32 @??troll 02:03:32 troll (07T) | Spd: 10 | HD: 7 | HP: 33-44 | AC/EV: 3/10 | Dam: 20, 1509(claw), 1509(claw) | 10doors, regen | Res: 06magic(20) | XP: 304 | Sz: Large | Int: human. 02:04:19 @??ettin 02:04:19 ettin (07C) | Spd: 10 | HD: 12 | HP: 55-77 | AC/EV: 9/4 | Dam: 45, 45 | 10items, 10doors, two-weapon | Res: 06magic(40), 12drown | XP: 1132 | Sz: Giant | Int: human. 02:05:35 -!- Lightli has quit [Ping timeout: 250 seconds] 02:07:04 -!- ystael has quit [Ping timeout: 240 seconds] 02:08:52 -!- WalkerBoh has quit [Remote host closed the connection] 02:09:16 -!- Lightli has joined ##crawl-dev 02:09:39 -!- jehoesefat has quit [Read error: Connection reset by peer] 02:14:05 Stable (0.18) branch on underhound.eu updated to: 0.18-b1-22-ge198996 02:17:03 -!- ursan_ has quit [Ping timeout: 250 seconds] 02:18:00 -!- Krakhan has quit [Ping timeout: 276 seconds] 02:20:04 -!- Zibudo has quit [Ping timeout: 240 seconds] 02:21:49 -!- GauHelldragon has quit [Ping timeout: 250 seconds] 02:24:00 -!- zxc has joined ##crawl-dev 02:29:03 -!- Kalir has quit [Changing host] 02:37:28 -!- FireSight has quit [] 02:44:23 -!- amalloy_ is now known as amalloy 02:46:40 -!- scummos__ has quit [Remote host closed the connection] 02:48:33 -!- siepu has quit [Read error: Connection reset by peer] 02:56:24 -!- ProzacElf has quit [Ping timeout: 246 seconds] 03:00:03 -!- omarax has quit [Remote host closed the connection] 03:04:57 -!- WhiteShark has quit [Ping timeout: 250 seconds] 03:05:14 -!- jeefus has joined ##crawl-dev 03:05:33 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 03:09:02 -!- dtsund has quit [Quit: Reality is an illusion, the universe is a hologram, buy gold, BYE] 03:09:14 -!- jefus has quit [Ping timeout: 252 seconds] 03:10:09 -!- lobf has joined ##crawl-dev 03:11:26 -!- infrashortfoo has quit [Client Quit] 03:14:18 -!- infrashortfoo has quit [Remote host closed the connection] 03:16:23 -!- grisha5 has quit [Quit: Page closed] 03:21:05 Stable (0.18) branch on crawl.beRotato.org updated to: 0.18-b1-22-ge198996 03:23:21 -!- bitcoinbastard has quit [Ping timeout: 250 seconds] 03:25:17 -!- Blazinghand has quit [Read error: Connection reset by peer] 03:31:42 Unstable branch on crawl.beRotato.org updated to: 0.19-a0-36-g4a0968a (34) 03:32:17 -!- jeefus is now known as jefus 03:32:27 -!- DaneiNINE has quit [Ping timeout: 250 seconds] 03:34:32 -!- lordfrikk has quit [Ping timeout: 252 seconds] 03:44:04 -!- Furril has quit [Ping timeout: 240 seconds] 03:44:40 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 03:46:49 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.2/20160407164938]] 03:51:19 -!- Xenobreeder has quit [Ping timeout: 250 seconds] 03:51:19 -!- infrashortfoo has quit [Read error: Connection reset by peer] 03:56:10 -!- glaas has quit [Ping timeout: 260 seconds] 03:56:12 -!- Lasty1 has joined ##crawl-dev 03:58:16 -!- lobf has quit [Ping timeout: 276 seconds] 03:58:16 -!- infrashortfoo_ has quit [Ping timeout: 276 seconds] 03:58:17 -!- dustinm` has quit [Ping timeout: 276 seconds] 03:58:18 -!- Lasty has quit [Ping timeout: 276 seconds] 03:58:18 -!- Weretaco has quit [Ping timeout: 276 seconds] 03:58:19 -!- the_assboy has quit [Ping timeout: 276 seconds] 03:58:19 -!- paulr_ has quit [Read error: Connection reset by peer] 03:58:21 -!- lobf_ has joined ##crawl-dev 03:58:25 -!- tswett has quit [Read error: Connection reset by peer] 03:58:46 -!- geekosaur has quit [Ping timeout: 276 seconds] 03:58:46 -!- Twinge has quit [Ping timeout: 276 seconds] 03:58:46 -!- fazisi_ has quit [Ping timeout: 276 seconds] 03:58:47 -!- flappity has quit [Ping timeout: 276 seconds] 03:58:47 -!- atrodo has quit [Ping timeout: 276 seconds] 03:58:47 -!- tksquared has quit [Ping timeout: 276 seconds] 03:58:55 -!- Twinge has joined ##crawl-dev 03:58:59 -!- Weretaco has joined ##crawl-dev 03:59:16 -!- ekix has quit [Read error: Connection reset by peer] 03:59:51 -!- Warrigal has joined ##crawl-dev 04:00:03 -!- omarax has quit [Remote host closed the connection] 04:00:04 -!- dustinm` has joined ##crawl-dev 04:00:15 -!- geekosaur has joined ##crawl-dev 04:04:45 -!- rchandra has left ##crawl-dev 04:05:38 -!- flappity_ has quit [Read error: Network is unreachable] 04:16:33 -!- ByronJohnson has quit [Ping timeout: 244 seconds] 04:19:08 -!- ystael has quit [Ping timeout: 260 seconds] 04:22:03 -!- vale_ has quit [Ping timeout: 260 seconds] 04:23:48 -!- tealeaves has quit [Ping timeout: 260 seconds] 04:23:54 -!- ByronJohnson has quit [Changing host] 04:30:03 -!- Naruni has quit [Remote host closed the connection] 04:32:06 -!- ontoclasm1 has joined ##crawl-dev 04:34:29 -!- ontoclasm has quit [Ping timeout: 252 seconds] 04:34:42 -!- Patashu has joined ##crawl-dev 04:35:07 -!- ontoclasm1 has quit [Client Quit] 04:42:22 -!- Marvin is now known as Guest81490 04:54:43 -!- infrashortfoo has quit [Remote host closed the connection] 04:58:15 -!- iFurril has quit [Ping timeout: 250 seconds] 05:00:02 -!- omarax has quit [Remote host closed the connection] 05:04:07 -!- infrashortfoo has quit [Remote host closed the connection] 05:11:07 -!- lobf_ has quit [Quit: lobf_] 05:12:05 -!- MgDark has quit [Ping timeout: 240 seconds] 05:23:43 -!- waat has quit [Ping timeout: 244 seconds] 05:25:58 -!- rossi has quit [Ping timeout: 276 seconds] 05:31:08 -!- iFurril has quit [Ping timeout: 252 seconds] 05:43:22 -!- amalloy is now known as amalloy_ 05:52:12 -!- lordfrikk has quit [Quit: Quitting] 06:00:02 -!- omarax has quit [Remote host closed the connection] 06:02:38 -!- infrashortfoo has quit [Read error: Connection reset by peer] 06:03:17 -!- Guest81490 has quit [Remote host closed the connection] 06:05:02 -!- edsrzf has quit [Ping timeout: 244 seconds] 06:29:30 -!- Arivia has quit [Quit: Textual IRC Client: www.textualapp.com] 06:31:19 -!- ystael has quit [Ping timeout: 260 seconds] 06:32:51 -!- Mandevil has quit [Ping timeout: 264 seconds] 06:34:15 -!- Mandevil_ has joined ##crawl-dev 06:34:58 -!- MarvinPA has joined ##crawl-dev 06:40:17 -!- Mandevil_ has quit [Ping timeout: 260 seconds] 06:40:59 -!- vale_ has quit [Remote host closed the connection] 06:42:37 -!- techieAgnostic has quit [Client Quit] 06:45:33 -!- Fandango_ has quit [Quit: Page closed] 06:47:05 -!- Mandevil_ has joined ##crawl-dev 07:00:02 -!- omarax has quit [Remote host closed the connection] 07:02:24 -!- serq has quit [Changing host] 07:02:31 -!- serq has quit [Client Quit] 07:05:16 -!- Doll has quit [Quit: Lost terminal] 07:05:22 -!- Warrigal has quit [Quit: No Ping reply in 180 seconds.] 07:07:28 -!- Marvin is now known as Guest87113 07:07:30 -!- Warrigal has joined ##crawl-dev 07:08:37 -!- wheals has joined ##crawl-dev 07:10:40 -!- debo has quit [Ping timeout: 252 seconds] 07:17:13 -!- MarvinPA has quit [Quit: Leaving] 07:18:04 -!- Kat_ has quit [Quit: Page closed] 07:18:12 -!- techieAgnostic has quit [Quit: WeeChat 1.4-dev] 07:18:16 -!- Guest87113 has quit [Remote host closed the connection] 07:24:30 -!- barb4r1an has quit [Ping timeout: 250 seconds] 07:25:38 -!- rossi has quit [Ping timeout: 244 seconds] 07:36:12 -!- Lightli has quit [Ping timeout: 250 seconds] 07:38:16 -!- techieAgnostic has quit [Quit: WeeChat 1.4-dev] 07:40:06 -!- grisha5 has quit [Ping timeout: 250 seconds] 07:42:40 -!- techieAgnostic has quit [Client Quit] 07:43:03 -!- AreBrandon has joined ##crawl-dev 07:47:11 -!- techieAgnostic has quit [Client Quit] 07:52:53 -!- techieAgnostic has quit [Quit: WeeChat 1.4-dev] 07:53:31 -!- elliptic has quit [Quit: Leaving] 07:53:41 -!- techieAgnostic has quit [Client Quit] 07:59:33 -!- techieAgnostic has quit [Quit: WeeChat 1.4-dev] 08:00:02 -!- omarax has quit [Remote host closed the connection] 08:03:51 -!- infrashortfoo has quit [Remote host closed the connection] 08:06:29 -!- Tilogour has quit [Quit: Page closed] 08:07:20 -!- Lasty1 has quit [Quit: Leaving.] 08:08:19 -!- Lasty has joined ##crawl-dev 08:09:29 -!- infrashortfoo has quit [Remote host closed the connection] 08:13:37 -!- debo has joined ##crawl-dev 08:15:34 -!- wheals has quit [Ping timeout: 252 seconds] 08:20:28 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 08:24:52 -!- MarvinPA has joined ##crawl-dev 08:28:27 -!- mopl has quit [Quit: Page closed] 08:30:05 -!- MarvinPA has quit [Read error: Connection reset by peer] 08:30:05 -!- techieAgnostic has quit [Read error: No route to host] 08:31:02 -!- tollymain has joined ##crawl-dev 08:32:16 -!- MarvinPA has joined ##crawl-dev 08:34:24 -!- Insomniak` has quit [Ping timeout: 260 seconds] 08:49:34 -!- MarvinPA has quit [Ping timeout: 260 seconds] 08:56:50 -!- techieAgnostic has quit [Quit: WeeChat 1.4-dev] 09:00:03 -!- omarax has quit [Remote host closed the connection] 09:02:44 -!- Marvin is now known as Guest37676 09:05:21 -!- Patashu has quit [Ping timeout: 244 seconds] 09:07:11 -!- debo_ has joined ##crawl-dev 09:07:35 -!- debo_ is now known as Guest23721 09:12:13 -!- Guest23721 has quit [Ping timeout: 252 seconds] 09:12:30 -!- Dracunos has quit [Read error: Connection reset by peer] 09:21:15 -!- infrashortfoo has quit [Remote host closed the connection] 09:24:27 -!- svendre has joined ##crawl-dev 09:25:40 -!- Guest37676 has quit [Remote host closed the connection] 09:25:57 -!- rossi has quit [Ping timeout: 246 seconds] 09:31:46 -!- wheals has joined ##crawl-dev 09:35:57 got a quick question if anyone is around.. 09:36:16 I noticed in the code statements such as: # include 09:36:35 while the actual path is: source/contrib/sdl2/include/SDL_opengl.h 09:37:36 I'm not quite sure, how is it working at all 09:38:40 I can either 1) add the directory to the list of folders to include, or 2) correct the path name in code 09:39:06 but even if I add the folder to the list of include folders, it still wouldn't work if left alone, as SDL2/SDL_opengl.h 09:39:41 for option #1, I would need to change it to just #include 09:39:47 which would be the preferred method? 09:40:04 -!- tealeaves has quit [Quit: Bye] 09:44:05 -!- Nattefrost has quit [Quit: Leaving.] 09:45:00 -!- jefus has quit [Read error: Connection reset by peer] 09:45:01 <|amethyst> svendre: building contrib/sdl2 is supposed to put the files into contrib/install//include/SDL2 09:45:53 <|amethyst> and the Makefile adds contrib/install//include to the include path 09:46:04 <|amethyst> s/the Makefile/the crawl Makefile/ 09:46:43 -!- LexAckson has joined ##crawl-dev 09:46:48 okay, I see - thanks.. I will try to make it work the same way then 09:46:55 !seen vible 09:46:55 I last saw vible at Fri Apr 29 22:28:12 2016 UTC (3d 15h 18m 43s ago) saying 'twelwe: vible, my name is vible' on ##crawl-dev. 09:47:05 do you know how vible is doing? 09:47:22 <|amethyst> I don't 09:48:34 -!- Diabl0658 has quit [Ping timeout: 240 seconds] 09:52:09 -!- Rust3dCor3 has quit [Ping timeout: 276 seconds] 09:55:14 -!- LexAckson_ has joined ##crawl-dev 09:57:54 -!- Wolpertinger has quit [Ping timeout: 250 seconds] 09:58:25 -!- LexAckson has quit [Ping timeout: 252 seconds] 09:58:34 -!- johlstei has quit [Ping timeout: 240 seconds] 10:00:02 -!- omarax has quit [Remote host closed the connection] 10:04:23 i wouldn't be surprised if it's messed up a little since MSVC was last used before we switched to sdl2 10:04:37 -!- ursan_ has quit [Ping timeout: 250 seconds] 10:05:41 <|amethyst> wheals: I also see that our crawl.vcxproj uses the source directories for libraries rather than the contrib/install/ directory 10:06:27 what version of GCC are you using to compile? 10:06:49 <|amethyst> how do contribs even get built with MSVC? 10:06:52 I've read 3.3 (at least) will throw all sorts of ambiguous overload errors (which is currently the majority of problems I'm facing) 10:07:09 <|amethyst> 4.8 at least 10:07:13 <|amethyst> 3.3 is ancient 10:07:25 <|amethyst> and definitely pre-C++11 10:07:36 the contribs are not currently being built with MSVC, well there is a seperate solution which perhaps used to build them, but it does not come close to working currently 10:08:07 and since I've manually added new lib files to the linker include directory, this is why I was seeing pathing problems with the .h files 10:08:45 vible was working on adding the contribs to the solution so it's all one, and I'm going through other compile errors with my short-cutted setup, but I don't know where he's at with that 10:09:38 contribs aren't currently a problem for me, and that pathing error was simple to work-around in the meanwhile, it's ambiguous overload issues galore, and it's a bit tough to resolve some of them... things need to be more explicit I guess 10:10:05 make_unique is one culprit 10:10:16 !source I_global.cc:30 10:10:17 Can't find I_global.cc. 10:10:25 !source l_global.cc:30 10:10:25 https://github.com/crawl/crawl/blob/master/crawl-ref/source/l_global.cc#l30 10:11:00 <|amethyst> what's the error exactly? 10:11:14 -!- lukano has quit [Ping timeout: 260 seconds] 10:11:16 -!- Nattefrost1 has quit [Read error: Connection reset by peer] 10:11:17 <|amethyst> oh 10:11:22 more than one instance of overloaded function "make_unique" matches.. 10:11:24 <|amethyst> we define our own make_unique in libutil.h 10:11:47 <|amethyst> if you're building with C++14 you'll have to #ifdef that out 10:14:56 the whole block? lines 178-182? 10:15:57 <|amethyst> yes, that whole function, put it in #ifndef TARGET_COMPILER_VC ... #endif 10:16:08 <|amethyst> or 10:16:22 k I'll give it a try 10:16:24 <|amethyst> figure out how to tell msvc we want only C++11, not C++14 10:16:41 mmkay 10:16:50 <|amethyst> we do that with gcc by using --std=c++11 10:17:16 <|amethyst> ah 10:17:26 <|amethyst> apparently MSVC does not have anything similar 10:17:41 <|amethyst> you're expected to build with an older toolchain if that's what you want 10:17:43 really? can't throw something on the command line 10:17:50 then access it? well 10:18:08 <|amethyst> I mean, can't tell it to disable newer language features 10:18:35 this is already a project 2015 solution file, I don't think it needs to be compat back to c++11 ?? 10:18:41 <|amethyst> right 10:18:53 <|amethyst> so you will need the #ifdef 10:18:57 <|amethyst> or ifndef 10:19:11 <|amethyst> But we have to be C++11 compatible for other compilers 10:19:25 <|amethyst> since we support old-ish gcc and clang 10:19:42 but TARGET_COMPILE_VC means, visual c right? 10:19:42 <|amethyst> hence not just removing the thing entirely 10:20:09 if we go with that, it'll compile in c++14, just won't work if MSVC earlier version is used correct? 10:20:16 <|amethyst> right 10:20:17 but other compilers would be fine? 10:20:20 <|amethyst> yeah 10:20:37 <|amethyst> what would be nice 10:20:47 I'll just do that for now, but I'll add a note to research obtaining the version, I'm sure it can be done - I already read somewhere something about it 10:20:52 <|amethyst> would be if we could say in a more generic wal #if COMPILER_SUPPORTS_C++14 10:21:00 why not 10:21:01 <|amethyst> but I'm not sure if there's a standard way 10:21:09 COMPILER_VC_VERSION getting assigned 10:21:36 <|amethyst> well, I think probably we won't support older MSVC anymore 10:21:37 and that value can be c++14, c++11, c++15........ 10:21:43 !source make_unique 10:21:43 1/1. https://github.com/crawl/crawl/blob/master/crawl-ref/source/libutil.h#l179 10:21:45 so it could be useful going forward as well 10:22:00 <|amethyst> svendre: I meant as a non-microsoft specific thing 10:22:08 does it cause issues on other compilers with C++14? 10:22:13 <|amethyst> svendre: we'd have to write logic to set it for every compiler out there 10:22:21 <|amethyst> wheals: with gcc and clang we build with --std=c++11 10:22:32 oh yeah 10:22:40 <|amethyst> wheals: presumably it would cause problems with --std=c++14 10:22:51 hm 10:22:53 they are perfectly interchangable without any checks of anything between gcc and clang, currently? 10:22:53 -!- Nattefrost has quit [Read error: Connection reset by peer] 10:22:59 the other alternative would be not using namespace std 10:23:34 clang compiles? 10:23:41 <|amethyst> wheals: well, the whole point of that function is to implement the C++14 version in pre-C++14 10:24:00 -!- Dracunos has quit [Ping timeout: 276 seconds] 10:24:10 svendre: yes clang compiles, I think current os x uses it 10:24:10 <|amethyst> wheals: and re no 'using namespace std'... 10:24:24 oh yeah 10:24:25 <|amethyst> wheals: you should have been around, and said something, when that happened :) 10:24:46 <|amethyst> wheals: (joking since it was a few years before your time in ##crawl-dev) 10:24:58 if we didn't use it, we'd have to have an #ifdef for C++14 anyway to specifically use std::make_unique 10:25:20 YOU should have been around :P 10:25:38 <|amethyst> I don't remember how much I complained 10:25:42 <|amethyst> I think it was only weakly 10:26:18 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 10:26:54 I just realized what i need to do 10:26:54 -!- tealeaves has quit [Quit: Bye] 10:27:03 Make a hack of beem that watches cwz for when hong plays 10:27:16 there's something called: _MSC_VER 10:27:26 and then plays a cute youtube video in the background 10:27:31 <|amethyst> aha 10:27:32 http://stackoverflow.com/questions/70013/how-to-detect-if-im-compiling-code-with-visual-studio-2008 10:28:06 -!- MarvinPA has joined ##crawl-dev 10:28:19 !lg hong 10:28:20 2777. hong the Skirmisher (L1 DsCK of Xom), slain by a hobgoblin (a +0 club) on D:2 (grunt_ministairs_10) on 2016-05-03 10:31:46, with 4 points after 219 turns and 0:00:29. 10:28:21 <|amethyst> svendre: even better: https://sourceforge.net/p/predef/wiki/Standards/ 10:28:51 <|amethyst> svendre: so you can put it in an: #if __cplusplus < 201402 10:29:52 ..then run code, else don't 10:30:14 <|amethyst> #if __cplusplus < 201402 define our make_unique function 10:30:24 <|amethyst> around the whole template, not just the body 10:30:35 [03 14:23] clang compiles? 10:30:42 <|amethyst> so if it's >= that won't be defined and you'll get the standard version 10:30:43 <|amethyst> hm 10:31:18 os x from xcode 4.0 on uses clang, not gcc. also freebsd 10.x, and I've been doing local linux builds with clang 3.6 10:31:33 <|amethyst> ... this assumes that MSVC declares itself to be a C++14 compiler, which I *think* it would 10:31:58 I'll try it, and you think that will resolve the overload issue? 10:32:19 <|amethyst> it should, at least for make_unique 10:32:45 wouldn't it be easier to adjust these things to be more explicit rather than these compiler version checks? 10:33:00 -!- tealeaves has quit [Quit: Bye] 10:33:03 <|amethyst> That's why I suggested #if __cplusplus < 201402 10:33:15 <|amethyst> that means "if the C++ standard being used is less than C++14" 10:33:34 I meant one set of code which compiles on all without version checks 10:33:49 -!- Tux[Qyou] has quit [Quit: Excess flood] 10:34:23 <|amethyst> probably a little difficult to make that work on such disparate systems 10:34:28 -!- Tux[Qyou] has joined ##crawl-dev 10:34:40 <|amethyst> unless you put all the version checks into a library like Qt 10:34:46 we're leaving it ambiguous, but letting some compilers do their assuming they did before and adding more logic to steer around it? 10:35:01 <|amethyst> Leaving what ambiguous? 10:35:13 the set of overloads 10:35:27 <|amethyst> the entire reason that function is there in libutil.h 10:35:35 we'll see if I get lucky and catch a live hong 10:35:36 <|amethyst> is because it's a very nice function from C++14 10:35:44 <|amethyst> but it isn't supported in C++11 10:36:05 <|amethyst> and we have to support C++11 compilers for the time being 10:36:07 make_unique is an existing standard function in C++14? is that what you mean? 10:36:10 <|amethyst> yes 10:36:18 ahhh *lightbulb*, okay. 10:36:50 -!- SurpriseTRex has quit [Read error: Connection reset by peer] 10:36:52 let's see what happens then :) I understand why this may work now 10:37:50 <|amethyst> there are likely to be similar problems related to our definition of some Posix functions in Windows 10:38:04 <|amethyst> if those got added to the MSVC headers between 2010 and 2015 10:38:13 <|amethyst> s/those/any of those/ 10:38:29 -!- serq has quit [Quit: suddenly gone...] 10:39:12 <|amethyst> I guess you encountered some of that in msvc.h already 10:39:13 first test, I hard-coded commenting it out, errors went way down - so now I'll add the version logic around it and make sure the results exactly match 10:39:43 <|amethyst> and if it doesn't work, double-check what the value of __cplusplus is in MSVC 10:39:56 <|amethyst> it might be that they don't claim C++14 yet in that version 10:40:06 <|amethyst> which makes things a little harder 10:43:32 #if __cplusplus < 201402 appears to not have worked 10:44:38 -!- dpeg has joined ##crawl-dev 10:48:24 <|amethyst> then possibly #if __cplusplus < 201402 && _MSVC_VER < 1900 10:48:46 <|amethyst> err 10:48:57 <|amethyst> #if __cplusplus < 201402 && _MSC_VER < 1900 // MSC not MSVC 10:49:23 <|amethyst> no wait 10:49:31 <|amethyst> that won't work elsewhere 10:49:57 -!- PsyMar has quit [Ping timeout: 260 seconds] 10:50:19 chequers: I have a modified version of beem stalking hong on cwz that will give him a message about contacting me, should have thought of it sooner 10:51:13 <|amethyst> #if __cplusplus < 201402 && !(TARGET_COMPILER_VC && _MSC_VER >= 1900) 10:52:16 well first one worked, second version didn't 10:52:23 -!- MarvinPA has quit [Remote host closed the connection] 10:52:33 it doesn't like the syntax at the second && 10:54:34 -!- MarvinPA has joined ##crawl-dev 10:57:29 -!- bsdbeard has quit [] 10:58:36 -!- Dracunos7 is now known as Dracunos 10:59:15 <|amethyst> oh 10:59:25 <|amethyst> #if __cplusplus < 201402 && !(defined(TARGET_COMPILER_VC) && _MSC_VER >= 1900) 11:00:02 -!- omarax has quit [Remote host closed the connection] 11:02:29 ok on that one 11:02:56 got to get rid of some more .h file probs now, might be getting close though 11:03:09 -!- Kalir has quit [Changing host] 11:03:20 most of the errors are fixedvector.h 11:04:07 actually, almost all of them are: fill(::begin(mData), ::end(mData), def); 11:04:33 but I think that may be because of a missing include file it can't find, if that's the case, then not many errors left!! 11:05:13 <|amethyst> for fill 11:06:19 it's already included, that's not the problem 11:06:34 -!- debo_ has joined ##crawl-dev 11:06:44 -!- ahriman has quit [Quit: leaving] 11:06:57 -!- debo_ is now known as Guest91104 11:07:16 it's a crap load of cannot convert argument1 from X to 'int' 11:07:52 <|amethyst> what is X? 11:07:54 and expects 3 arguments, but 2 provided 11:08:07 X is a bunch of different types across multiple errors 11:08:17 <|amethyst> oh 11:08:19 bool[3], map+cell[70] 11:08:28 unsigned int, etc. etc. 11:09:15 it's about 50 errors all on fixedvector.h line 112 11:11:04 -!- Guest91104 has quit [Ping timeout: 240 seconds] 11:11:15 most recent output: http://pastebin.com/ms5jxFbt 11:11:37 <|amethyst> I don't suppose changing those ::begin and ::end to std::begin and std::end helps? 11:12:50 <|amethyst> ah, yes, it's finding the wrong "end" function 11:13:37 <|amethyst> if std::end doesn't help, then maybe #include at the top (but that really shouldn't be necessary, because is guaranteed to pull in the std::begin and std::end templates) 11:14:32 <|amethyst> oh, FixedVector doesn't use 11:14:38 <|amethyst> so yeah, maybe is needed 11:14:48 <|amethyst> but try changing :: to std:: first 11:15:25 <|amethyst> I'm pretty sure our AppHdr.h pulls in (indirectly) and maybe even 11:15:42 <|amethyst> must be going for a bit, later 11:16:03 changing it where... 11:16:25 on 112? 11:16:59 ok np I'll try all :) 11:19:18 it's much, MUCH happier with: fill(std::begin(mData), std::end(mData), def); 11:19:26 only 7 errors total now! 11:19:40 two of which are can't find file, easy ones 11:26:25 -!- rossi has quit [Ping timeout: 244 seconds] 11:28:48 is zotdef.cc something that was deleted? 11:29:49 !source zotdef.cc:1 11:29:50 Can't find zotdef.cc. 11:29:56 guess so.. 11:33:03 svendre: yes, zotdef was removed in 0.16 11:33:10 -!- PleasingFungus has joined ##crawl-dev 11:33:19 we also removed fungi in 0.16 11:34:44 noo 11:35:40 PleasingFungus: hi 11:35:45 hello! 11:36:20 do you have any shorter nicknames, like pf, fungus, 'shroom? 11:36:50 the first of those works! 11:37:08 I'm down to *4* errors! 11:37:12 woo woo 11:39:11 -!- Daekdroom has quit [Quit: Leaving] 11:42:30 hmm looks like mkstemp is being called outside of a CRAWL_HAVE_MKSTEMP check (thus is undefined) here: 11:42:37 !source package.cc:138 11:42:37 https://github.com/crawl/crawl/blob/master/crawl-ref/source/package.cc#l138 11:42:48 any suggested resolutions? 11:45:13 -!- jefus has joined ##crawl-dev 11:45:18 include syscalls.h 11:45:39 hrm 11:46:05 -!- infrashortfoo has quit [Remote host closed the connection] 11:46:08 if you grep CRAWL_HAVE_MKSTEMP, syscalls.h is supposed to define its own mkstemp when the environment doesn't provide one 11:48:10 package.cc already includes it, so that implies that CRAWL_HAVE_MKSTEMP is true but mkstemp still isn't defined 11:48:18 or your compiler is doing something weird 11:48:42 probably it doesn't make mkstemp in the msvc buildchain 11:49:01 or rather 11:49:05 it doesn't set CRAWL_HAVE_MKSTEMP 11:49:12 (my guess) 11:49:51 ooh, that's *both* of my suggestions! 11:52:00 alright! (decoding answer.... progress 1%...... 2%......) 11:53:08 PleasingFungus: ok, it's your guess too 11:53:25 i should be less possessive of my guesses 11:53:29 <3 11:53:53 svendre: is your build process running util/configure? 11:53:58 when you say "it doesn't set CRAWL_HAVE_MKSTEMP" which is my conclusion as well, what do you mean by "it" 11:54:13 is that supposed to be a flag set somewhere on the compile command line 11:55:14 -!- dtsund has joined ##crawl-dev 11:55:38 pf: no, I don't think so 11:55:51 that is your problem, then 11:56:08 util/configure normally sets it in config.h 11:56:15 pf: I think I can confirm that, particularly because configure looks like a shell command in a format the OS doesn't have natively 11:56:32 wheals: be my guess! 11:56:32 dpeg: You have 2 messages. Use !messages to read them. 11:57:01 I can probably do something like, run a cygwin shell on that or something, as a pre-build requirement in the project.. humm I'll look into that 11:58:30 erm, if it's run once, that's sufficient right 12:00:02 -!- omarax has quit [Remote host closed the connection] 12:00:21 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 12:05:12 -!- LexAckson_ has quit [Ping timeout: 260 seconds] 12:08:51 -!- Dracunos has quit [Ping timeout: 276 seconds] 12:10:39 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 12:12:04 -!- Dracunos7 has quit [Ping timeout: 240 seconds] 12:14:49 -!- jbenedetto has quit [Ping timeout: 252 seconds] 12:17:53 -!- molotove has quit [Quit: Leaving.] 12:20:11 -!- tealeaves has quit [Quit: Bye] 12:25:35 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 12:25:47 the real problem will be that, even if MSVC becomes working, who on the dev team will use it?! 12:25:59 We'd have to convert wheals or Lasty 12:26:05 or two windows devs 12:26:11 *our 12:26:38 -!- Nattefrost has quit [Ping timeout: 240 seconds] 12:28:00 -!- Blazinghand has joined ##crawl-dev 12:29:38 I can run configure now, but not sure what it's expecting as the command line parameter, it doesn't say - a filename I am guessing 12:29:41 -!- serq has quit [Quit: suddenly gone...] 12:31:08 gammafunk: I was going to try and use it, though I suspect you mean someone who can commit changes.. I could at least write code, debug, test, etc. and then submit code changes even if only pull requests, right? 12:31:53 if I test compiling it on gcc as well before doing that, it would avoid introducing some platform specific bugs 12:32:16 but, in general - it seems more picky.. not less 12:33:17 I wasn't planning on major stuff, but I will get up to speed more or less, eventually - having the environment with a working compile to start from is very helpful in that 12:34:10 -!- Xenobreeder has joined ##crawl-dev 12:34:14 anyhow - looks like I can safely say that the logic in syscall.h is there to add CRAWL_HAVE_MKSTEMP, but it's failing for some reason, so I'm just going to work on that 12:34:38 svendre: no I meant for the dev team, it's good if a toolchain is actually used by at least one member. Still useful to have MSVC support even if no one on the dev team is using it, can just make it harder to maintain 12:35:19 you could always not maintain it, and I'll keep downloading stuff from the master and look for problems if they crop up 12:35:43 if we do it well, the master repository would get all the compat changes merged with no problems anywhere right 12:35:49 -!- Kellhus has quit [Quit: Page closed] 12:36:08 -!- ProzacElf has joined ##crawl-dev 12:36:11 it surely won't be worse than years behind even if something does come up 12:37:28 I guess I'm volunteering to maintain it 12:37:39 -!- scummos__ has quit [Ping timeout: 260 seconds] 12:39:03 yeah, obviously if someone is regularly working to keep it alive, that's better 12:39:39 We lost our previous MSVC user when mumra left; I know dracoomega was on windows, but I'm not sure if he used msys or MSVC 12:39:46 I want to say it was MSVC though 12:39:59 I know he often complained about not having a debugger 12:40:31 speaking of msys, I wonder how out of date our msys2 instructions have become... 12:40:52 that was my primary reason for wanting to get it to work, the debugging 12:40:59 it's fairly nice 12:41:16 gammafunk: they aren't too bad 12:41:49 I was able to compile in msys2 without many problems, the main problem was the first go around, I tried using msys1 - but that wasn't the fault of the documentation 12:42:21 svendre: try running util/configure on .cflag 12:42:24 *.cflags 12:42:25 the regular MinGW installer, that was only because someone mentioned to use MinGW and I headed to the web and downloaded it 12:42:39 ok so "sh configure .cflag" ? 12:42:56 "sh configure *.cflags" 12:43:05 maybe 12:43:09 util/configure .cflags 12:43:11 ${QUIET_GEN}util/configure "$(CXX)" $(STDFLAG) $(ALL_CFLAGS) 12:43:17 is the relevant pair of makefile lines 12:43:25 it ran 12:43:29 neat! 12:43:41 but it didn't exactly say what it did, no output 12:44:41 with what current working directory should I have been running that? from source? 12:45:13 probably 12:45:26 it's supposed to modify config.h, iirc. 12:45:40 no 12:46:00 I ran it with the util current working directory, looks like it created a config.h file which I don't think was there before 12:46:06 what's the executable name for the compiler? 12:46:37 that's what the argument is supposed to be 12:46:49 devenv.exe 12:47:19 it may create new threads when it compiles though I'd have to verify that 12:47:28 that's the executable in memory with the ide open at least 12:48:54 that sounds wrong 12:49:05 I think it's cse.exe 12:49:12 csc.exe 12:49:32 that's for c# i think, i think the C++ one is cl.exe 12:49:35 ugh that's c# 12:50:24 yes you're right it is cl.exe 12:50:27 though util/configure uses -c as an argument flag and it probably has to use /C for cl.exe 12:50:33 maybe it works 12:52:02 all are undef'ed in config.h 12:52:29 -!- tealeaves has quit [Quit: Bye] 12:52:35 the date/time stamp on the file verifies, it was just created however 12:52:36 -!- mopl has quit [Quit: Page closed] 12:53:18 I used what pf said: "sh configure .cflags" 12:53:34 *.cflags 12:54:22 yeah I can confirm, that generated the file again - but still all are undefined 12:54:26 yeah the argument to configure is supposed to be cl.exe 12:54:44 ${QUIET_GEN}util/configure "$(CXX)" $(STDFLAG) $(ALL_CFLAGS) 12:54:54 CXX is the C++ compiler executable name 12:54:57 oh 12:55:04 duh missed the second line then 12:55:48 "sh configure .cflags ${QUIET_GEN}util/configure "$(CXX)" $(STDFLAG) $(ALL_CFLAGS)" << is that correct? 12:56:17 or you saying I need cl.exe in there too? 12:56:19 -!- Ququman has joined ##crawl-dev 12:57:12 "sh configure ${QUIET_GEN}util/configure "$(Cl.exe)" $(STDFLAG) $(ALL_CFLAGS)" ?? 12:57:24 no 12:57:34 sorry, this wouldn't be obvious to someone who doesn't do much shell programming 12:57:40 try `sh configure cl.exe` 12:58:12 it recreated config.h but all are undefined still 12:58:24 if the file is still empty, try finding the absolute path to cl.exe (C:\Program Files\etc.) and use that instead 12:58:39 ok, yeah I was going to say - it's not in the path 12:59:13 but, this is a bash shell - what is it going to do with cl.exe ?! 12:59:30 it can still run it 12:59:51 wow, ok.. I'd like to see that 13:00:02 -!- omarax has quit [Remote host closed the connection] 13:00:25 if this still doesn't work, try editing util/configure lines 19, 38, and 56 to use /c instead -c 13:02:36 but, testing on my end, it looks like that shouldn't be necessary 13:03:15 here's the path: C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin 13:03:41 yeah so run `util/configure "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin"` 13:03:48 i just tested, this worked for me 13:04:05 wait a sec, you're running that from source directory? 13:04:11 my CWD is util 13:04:26 so we want that config.h to be created in source? 13:05:22 yes 13:05:41 everything includes it as "config.h" not "util/config.h" afaik 13:05:57 Unstable branch on crawl.akrasiac.org updated to: 0.19-a0-36-g4a0968a (34) 13:06:07 yeah 13:06:20 util/configure "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin" 13:06:22 ran 13:07:04 does your config.h have several #undefs now? 13:07:11 oh ffs 13:07:20 it's util/configure "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\cl.exe" 13:07:44 you missed the executable name itself 13:07:53 heh yeh I thought so 13:08:08 [01:03] <+wheals> yeah so run `util/configure "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin"` 13:08:16 ok so it's re-run 13:08:27 i should learn2read 13:08:44 config.h is now in source - but it's still three undef statements 13:09:00 -!- Xenobreeder has quit [Ping timeout: 250 seconds] 13:09:01 yeah that's what it should look like 13:09:47 so just try and compile now and see what happens? 13:10:08 yeah 13:10:13 I need to include that config.h file into the project I'm pretty sure though 13:10:55 oh 13:11:06 i don't know anything about that, but i don't think you need to 13:11:13 ok ill try it both ways 13:11:32 the file is/will be (once we sort it out) autogenerated by the build process 13:11:45 it's included in syscalls.h already too 13:12:04 ahah the ide is already telling me external sources modified a file such as compflag.h 13:12:56 I'm getting that compflag.h is being modified every time I build now 13:13:02 or was modified 13:13:26 looks like it's part of the build process 13:13:27 https://github.com/crawl/crawl/blob/aded821ddbe1c3b7ad94d041a63f9239611b0701/crawl-ref/source/MSVC/crawl.vcxproj#L104 13:13:31 OK we're golden, the compile error is gone 13:13:48 I did not include config.h 13:13:52 into the project 13:13:58 awesome :D 13:14:29 don;t add it to the project unless you can teach the project how to create it 13:14:51 -!- GauHelldragon has quit [Ping timeout: 250 seconds] 13:15:49 that was really weird...... a MinGW bash shell running a script pointing to a win32 executable, resulting in a definition appearing in a compile - where config.h isn't even included in the project, it must have been the change to that compflag.h file that made the difference 13:16:01 -!- Lightli has joined ##crawl-dev 13:16:27 I could add running that bash shell to the pre-compile to-do list 13:16:43 yeah 13:16:58 but adding config.h to the project, automated - that might get trickier, but if it's not needed it - screw it. 13:17:55 -!- lobf has joined ##crawl-dev 13:17:58 !source compflag.h:1 13:17:58 https://github.com/crawl/crawl/blob/master/crawl-ref/source/compflag.h#l1 13:18:32 weird, that link gives a 404 13:18:32 -!- noobcanoe has quit [Ping timeout: 250 seconds] 13:18:41 !source idontexist.h:1 13:18:42 Can't find idontexist.h. 13:19:25 it's an autogenerated file, so it exists on Sequell's copy but not the repository 13:19:46 OK down to *3* errors 13:20:01 you guys down to help me blast through these quicker? 13:20:10 I think one is perhaps simple 13:20:52 !source l_moninf.cc:319 13:20:53 https://github.com/crawl/crawl/blob/master/crawl-ref/source/l_moninf.cc#l319 13:21:04 syntax error: '}' 13:22:18 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 13:22:34 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 13:25:01 try putting surrounding the line with { }? 13:25:05 er 13:25:15 put curly braces around it 13:25:22 would have to see what the lua macros expanded to. really 13:26:39 -!- rossi has quit [Ping timeout: 276 seconds] 13:27:13 but yes, if the unbrace police didn't "fix" lines 313-316 then maybe braces are needed there 13:27:26 braces was correct 13:27:37 just around that one line after the if (st== 13:27:44 the unbrace police 13:27:46 heh 13:27:50 -!- LordSloth has quit [Ping timeout: 244 seconds] 13:28:14 incidentally, i've decided that the biggest reason to mourn the loss of cszo is the increased lag on cbro 13:28:26 not that i blame neil in the least for not wanting to put up with it 13:28:45 !source spl-transloc.cc:70 13:28:45 https://github.com/crawl/crawl/blob/master/crawl-ref/source/spl-transloc.cc#l70 13:28:54 'disjunction': ambiguous symbol 13:29:13 it thinks disjunction(); is ambiguous 13:29:49 The compiler cannot determine which symbol you are referring to. 13:30:20 can occur if a header file includes a using Directive (C++), and a subsequent header file is #include'd and contains a type that is also in the namespace specified in the using directive. Specify a using directive only after all your header files are specified with #include 13:30:53 I see only one definition, with no overloads 13:31:12 but maybe the declaration in spl-transloc.h should have extern on it? 13:31:42 ProzacElf: there are rumors that cszo will return under a new master 13:31:48 ...although that would be weird if nothing else is failing 13:32:02 heh 13:32:08 i've been hearing those rumors =p 13:32:09 also cjr will be ready soon 13:32:17 and is playable now 13:32:21 -!- lobf has quit [Quit: lobf] 13:32:32 maybe it will fix the ghost moth bug :P secretly failing (jk..) 13:32:35 will it be ready for the tourney though? 13:32:43 it's already ready for t 13:32:44 so yeah 13:32:49 ah cool 13:32:53 maybe i'll give it a shot 13:33:18 cjr is montreal based right? 13:33:25 yep 13:34:12 roughly the same distance from me as atlanta as the crow flies. maybe not in interweb tube distance though =p 13:34:49 -!- infrashortfoo_ has quit [Ping timeout: 260 seconds] 13:35:18 svendre: maybe try moving the cast_disjunction function below the disjunction() one in spl-transloc.cc? that really shouldn't matter but maybe it does somehow 13:35:33 ProzacElf: just be warned that on that server, jorgrun does 4x damage 13:35:39 something to keep in mind 13:35:59 just like how xtahua is on cxc 13:36:24 extern void disjunction(); on line 7 in spl-transloc.h ? is that the other suggestion? 13:37:11 svendre, Ican't actually see how that could help. but the other possibility is that something in MSVC headers defines a `disjunction` 13:37:13 i don't think that could hurt, at any rate 13:37:56 oh LOL 13:38:00 moving the order of the functions did nothing 13:38:02 std::disjunction is in C++17 13:38:04 -!- Kintak has quit [Ping timeout: 240 seconds] 13:38:17 we're gonna have to rename the spell! 13:38:40 man, wonder if they have std::singularity 13:38:51 -!- PleasingFungus has quit [Remote host closed the connection] 13:39:07 -!- Zekka has quit [Ping timeout: 250 seconds] 13:39:08 try undoing those two changes, and change every use of disjunction() to disjunction_tick() 13:39:19 "every use" including the definition and declaration 13:39:32 I haven't tried the extern void yet 13:39:46 this is going to have SERIOUS effects on my plan to rename Gell's Gravitas to Conjunction 13:39:55 ok, don't even bother with it 13:39:59 actually I was about to suggest putting at the top of spl-transloc.h: #define disjunction disjunction_foo 13:40:00 the extern void thing 13:40:04 (or _tick or whatever_ 13:40:30 wheals: ok I will try changing all occurances to disjunction_tick() 13:42:35 gammafunk: i've never been killed by jorgrun, maybe it'll be a nice change of pace =p 13:42:59 -!- scummos__ has quit [Ping timeout: 260 seconds] 13:43:04 !killratio jorgrun 13:43:06 !killratio devteam 13:43:11 jorgrun wins 2.276% of battles. 13:43:13