00:00:03 -!- omarax has quit [Read error: Connection reset by peer] 00:02:05 -!- Blade- has quit [Ping timeout: 240 seconds] 00:05:44 yred enslave soul 13https://crawl.develz.org/mantis/view.php?id=10376 by KSK 00:06:38 nice, spectral lom lobon. 00:07:31 -!- mibe has quit [Ping timeout: 250 seconds] 00:07:45 -!- mibe_ is now known as mibe 00:07:57 -!- SirLicksAlot has quit [Ping timeout: 250 seconds] 00:09:02 not sure if he's saying the named pan lords turn into random pan lords on enslave 00:09:25 (s)he, I guess 00:10:03 I think it's more random panlords become different random pan lords? 00:10:11 heh 00:18:38 does "falchion" communicate to players "this is the crap sword"? 00:18:52 it sounds a lot cooler than long sword 00:20:18 jean falchion 00:24:47 -!- tealeaves has quit [Quit: Bye] 00:24:52 -!- Nerem has quit [Ping timeout: 246 seconds] 00:25:05 -!- TacoSundae has quit [Quit: Page closed] 00:25:08 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 00:26:44 <|amethyst> I think there are three different complaints 00:26:55 @??orc warlord 00:26:55 orc warlord (11o) | Spd: 10 | HD: 15 | HP: 96-131 | AC/EV: 12/7 | Dam: 32 | 10weapons, 10items, 10doors, fighter | Res: 06magic(60) | XP: 1666 | Sp: battlecry [11!AM] | Sz: Medium | Int: human. 00:27:13 <|amethyst> err, five separate complaints 00:27:29 <|amethyst> which I haven't verified, but which make sense 00:27:41 @??orc 00:27:41 orc (04o) | Spd: 10 | HD: 1 | HP: 6-8 | AC/EV: 1/9 | Dam: 5 | 10weapons, 10items, 10doors | XP: 3 | Sz: Medium | Int: human. 00:28:19 -!- mibe has quit [Ping timeout: 250 seconds] 00:28:23 -!- tgcid9999 has quit [Quit: Page closed] 00:28:44 -!- destroythecore has quit [Read error: Connection reset by peer] 00:29:30 elliptic: would you rather solve this by a) ignoring it b) looking at the data and simplifying it c) extending the max column size d) something else: loaddb.py:645: Warning: Data truncated for column 'noun' at row 1 00:29:41 <|amethyst> 1. random pan lords have their EV and AC re-randomized, become speed 10, and get crap damage 00:31:32 -!- Dracunos has quit [Ping timeout: 252 seconds] 00:31:42 <|amethyst> I'm not sure about the damage thing, but it does look like EV, AC, and speed are rerandomized 00:32:56 <|amethyst> 2. spectralised hell lords get crap damage (certainly this spectral ereshkigal doesn't seem to be doing 40) 00:35:12 <|amethyst> 3. at least those three lords, and maybe other things, revert to normal spectre speed, not their own normal speed, when haste expires 00:35:37 spectralized hell lords? 00:35:51 oh, from yred 00:36:00 <|amethyst> I can verify 3, and it doesn't depend on whether they were hasted when they converted 00:37:35 <|amethyst> also happens if you convert them (speed 20 for gloorx for example), then haste them (speed 15!), then haste expires (speed 10!) 00:37:35 -!- NeremWorld has quit [Ping timeout: 252 seconds] 00:38:19 <|amethyst> 4. not a bug: spectral lom will probably kill you, because their spells aren't very friendly to allies 00:38:32 <|amethyst> and 0. spectral hell serpent crashes when it breathes 00:39:05 why can you enslave soul on them anyway? 00:39:11 <|amethyst> why not? 00:39:14 -!- Rust3dCor3 has quit [Ping timeout: 252 seconds] 00:39:24 <|amethyst> it used to be that you couldn't enslave demons or holies 00:39:30 right 00:39:32 <|amethyst> that was changed for fun 00:39:34 ah 00:39:39 <|amethyst> and to make yred more useful later in the game 00:39:40 -!- ystael has quit [Ping timeout: 276 seconds] 00:39:43 -!- mibe_ is now known as mibe 00:40:00 fair enough i guess 00:40:34 <|amethyst> I can confirm 0 too 00:40:34 neil (L20 HuFi) ASSERT(mons->type >= MONS_SERPENT_OF_HELL) in 'mon-cast.cc' at line 4875 failed. (D:1) 00:40:35 but i still can't fulfill my dream of enslaving jory can i? 00:40:36 <|amethyst> :) 00:41:23 <|amethyst> I think problems 1-3 are all about enslaved spectrals taking data from the base monster type rather than from the original monster's ghost_demon structure 00:41:37 autofight doesn't approach detected enemies 13https://crawl.develz.org/mantis/view.php?id=10377 by pumpyscump 00:41:37 <|amethyst> I wonder if maybe the slave could hold a copy of the original monster 00:41:39 vampires have souls too! 00:41:52 <|amethyst> the way orc corpses do 00:41:56 that sounds like an rc problem 00:42:03 out of old pumpyscump there 00:42:10 -!- shnurlf has quit [Quit: Page closed] 00:42:36 <|amethyst> I don't think it's an rc problem 00:42:56 <|amethyst> probably autofight doesn't consider detected monsters to be enemies 00:43:19 -!- Athaboros has quit [Ping timeout: 260 seconds] 00:43:24 4 might be a bug. I had a patch accepted to stop friendly pan lords shattering 00:43:40 (this was for pan lords from pentagram card, which may no longer be a thing) 00:43:48 Lom Lobon (12&) | Spd: 10 | HD: 19 | HP: 323-463 | AC/EV: 10/20 | Dam: 4012(antimagic) | 05demonic, 10doors, fighter, unholy, see invisible, fly | Res: 13magic(immune), 05fire, 12cold+++, 11elec+++, 03poison, 04rot, 13neg+++, 13torm | Vul: 08holy++ | XP: 10966 | Sp: glaciate (10-132) [06!sil], conjure ball lightning [06!sil], major healing [06!sil], tornado [06!sil], blink range [06!sil] | Sz: Large | Int: human. 00:43:48 <|amethyst> %??lom lobon 00:43:58 oh wait 00:44:01 <|amethyst> I guess there's still glaciate 00:44:12 detected as in from antennae or something i guess 00:44:14 <|amethyst> which is slightly less likely to kill the player 00:44:19 i was totally misinterpreting that 00:44:26 <|amethyst> ProzacElf: yeah.. if detected by antennae, it makes sense 00:44:28 i've been awake way too long today 00:44:32 <|amethyst> because they're not even in LOS 00:44:37 right 00:44:45 <|amethyst> but there are also disturbances in clouds 00:45:16 <|amethyst> or antennae 1/2 + invisible creatures 00:46:32 -!- eb has quit [] 00:48:11 <|amethyst> 0. is that SoH breath checks mons->type rather than something like mons_class_is_zombified(mon->type) ? mons->base_monster : mons->type 00:48:47 mons_base_type, probably 00:48:47 -!- AlphaQ has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.2/20160407164938]] 00:48:49 but yeah 00:48:52 <|amethyst> I was thinking about that 00:49:09 <|amethyst> do spectrals lose their sub-species monster type? 00:49:18 yeah, don't mind me saying dumb stuff. my sleep schedule has been thrown way off 00:49:24 <|amethyst> because maybe you'd want to preserve that for SoH 00:49:43 <|amethyst> mons_base_type explicitly converts base_monster to a species 00:49:54 it looks like it's just define_zombie(mon, mon->type, MONS_SPECTRAL_THING); 00:50:06 so it should keep it? 00:50:17 <|amethyst> aha 00:50:43 <|amethyst> so then you'd want to use what I wrote instead of mons_base_type (or add a flag to mons_base_type) 00:51:00 ah, yeah, good call 00:51:05 <|amethyst> so that you don't collapse them all down to geh SoH 00:51:33 or just add another function 00:52:13 <|amethyst> mons_base_type_for_real 00:52:21 <|amethyst> mons_slightly_less_base_type 00:53:20 <|amethyst> mons_debased_type 01:00:03 -!- omarax has quit [Remote host closed the connection] 01:00:04 :) 01:00:24 "the Serpent of Hell the spectral Serpent of Hell" 01:01:35 -!- Zibudo has quit [Ping timeout: 240 seconds] 01:01:41 <|amethyst> sounds legit 01:01:45 hmmm 01:01:53 ASSERT(mons->heads() == ARRAYSZ(serpent_of_hell_breaths[idx])) in 'mon-cast.cc' at line 4893 failed. 01:02:07 does enslave soul not retain head count 01:02:07 <|amethyst> oh, err 01:02:11 <|amethyst> probably not, or only for hydras 01:02:17 <|amethyst> except hydras aren't intelligenet 01:03:58 <|amethyst> however, most of them can spell better than I 01:04:54 huh, it looks like it should work, actually 01:07:15 Hazardous clouds can spawn on a branch's exit stairwell, blocking travel commands 13https://crawl.develz.org/mantis/view.php?id=10378 by pumpyscump 01:09:15 is that actually a bug? 01:09:31 <|amethyst> it certainly sounds annoying 01:09:35 it is 01:09:51 i've had miasma blocking the depths exit before 01:09:58 ah, has_hydra_multi_attack also needs to check the base type 01:18:28 -!- Nerem has quit [Ping timeout: 276 seconds] 01:18:54 -!- Blade- has joined ##crawl-dev 01:20:22 on a similar note, the other side of a staircase being excluded won't actually stop autotravel from using that staircase, unless the exclusion is centered on the staircase 01:20:28 -!- ursan has quit [Ping timeout: 250 seconds] 01:20:31 it will use the staircase, then notice you're in an excluded area, then stop 01:22:38 first vault, mostly just a test feel free to reject. tips on what to do better welcome! 13https://crawl.develz.org/mantis/view.php?id=10379 by pumpyscump 01:24:06 more ecu altar vaults! please accept on principle even if the weight is nerfed 01:24:46 ubuntu 01:24:50 my phone is not a CD-ROM drive 01:24:59 lies 01:25:01 that is why you are having trouble mounting it as one 01:25:07 really? because it's read only and not a floppy disk 01:25:54 chequers, that looks almost like a nicolae vault 01:25:54 -!- BanMido_ has quit [Ping timeout: 268 seconds] 01:26:35 i don't have enough inside knowledge to parse the intent of that statement 01:28:22 -!- Zeor has quit [Quit: Leaving.] 01:29:09 you know, alphabet shops, steel large rocks; multiple ecumenical altars wouldn't seem out of place 01:29:22 :) 01:30:04 i just like the idea of more ecu vaults and also early jiyva. Although I think the place chance and jiyva chance need a nerf 01:30:16 you could get jiyva in like 5% of games with that weight 01:31:31 -!- Marvin is now known as Guest43011 01:33:46 there should be a higher J chance anyway 01:34:08 since he's been carefully excised from early game outside of the ecu altar =p 01:35:09 -!- Harudoku has quit [Ping timeout: 268 seconds] 01:35:16 -!- NeremWorld has quit [Ping timeout: 250 seconds] 01:36:02 -!- hellmonk has quit [Quit: Page closed] 01:36:13 -!- Guest43011 has quit [Ping timeout: 276 seconds] 01:36:21 -!- namelastname112 has quit [Ping timeout: 250 seconds] 01:37:15 -!- Adeon is now known as Badeon 01:39:09 -!- Badeon is now known as Adeon 01:41:00 -!- Blazinghand has joined ##crawl-dev 01:46:36 03doy02 07* 0.18-a0-1806-g4ed6cac: use the base type for serpent of hell breaths 10(44 minutes ago, 1 file, 11+ 8-) 13https://github.com/crawl/crawl/commit/4ed6cac5aad9 01:46:36 03doy02 07* 0.18-a0-1807-g3cf0328: give zombified serpents of hell multiple heads too 10(36 minutes ago, 1 file, 1+ 1-) 13https://github.com/crawl/crawl/commit/3cf032851fba 01:46:36 03doy02 07* 0.18-a0-1808-g3e993bd: avoid "the Serpent of Hell the spectral Serpent of Hell" 10(3 minutes ago, 1 file, 4+ 0-) 13https://github.com/crawl/crawl/commit/3e993bd8f721 01:49:21 -!- shnurlf has quit [Ping timeout: 250 seconds] 01:51:00 -!- zxc has joined ##crawl-dev 01:51:07 -!- amalloy is now known as amalloy_ 01:52:47 -!- Kalir has quit [Changing host] 01:57:20 -!- FireSight has quit [] 02:00:04 -!- omarax has quit [Remote host closed the connection] 02:00:28 -!- Idolo has quit [] 02:10:35 -!- Leszczynek has quit [Ping timeout: 260 seconds] 02:10:55 -!- zxc_ has joined ##crawl-dev 02:12:55 -!- zxc has quit [Ping timeout: 244 seconds] 02:16:59 -!- PleasingFungus has joined ##crawl-dev 02:18:17 -!- ProzacElf has quit [Ping timeout: 276 seconds] 02:29:39 |amethyst: :) 02:29:39 PleasingFungus: You have 1 message. Use !messages to read it. 02:29:55 !tell chequers send me a tell when it's ready to link, then! :) 02:29:55 PleasingFungus: OK, I'll let chequers know. 02:31:39 -!- travis-ci has joined ##crawl-dev 02:31:40 The build passed. (master - 3e993bd #5324 : Jesse Luehrs): https://travis-ci.org/crawl/crawl/builds/125750513 02:31:40 -!- travis-ci has left ##crawl-dev 02:34:02 -!- amalloy_ is now known as amalloy 02:44:11 -!- amalloy is now known as amalloy_ 02:47:01 -!- Krakhan has quit [Ping timeout: 244 seconds] 02:48:30 -!- glaas has quit [Ping timeout: 260 seconds] 02:49:48 -!- FunkyBomb has quit [Ping timeout: 250 seconds] 02:51:37 -!- ystael has quit [Ping timeout: 276 seconds] 02:52:57 -!- CanOfWorms has quit [Quit: ChatZilla 0.9.92 [Firefox 3.6.28/20120306064154]] 02:53:29 -!- Alatreon_ has quit [Ping timeout: 250 seconds] 03:00:03 -!- omarax has quit [Remote host closed the connection] 03:04:21 -!- amalloy_ is now known as amalloy 03:11:46 Unstable branch on crawl.beRotato.org updated to: 0.18-a0-1808-g3e993bd (34) 03:13:34 -!- scummos| has quit [Ping timeout: 250 seconds] 03:13:52 -!- amalloy is now known as amalloy_ 03:17:16 -!- Marvin is now known as Guest74027 03:21:00 -!- tksquared_ has quit [Ping timeout: 250 seconds] 03:21:59 -!- Guest74027 has quit [Ping timeout: 276 seconds] 03:22:53 -!- PleasingFungus has quit [Quit: ChatZilla 0.9.92 [Firefox 45.0.2/20160407164938]] 03:26:48 -!- pikaro has quit [Ping timeout: 244 seconds] 03:26:51 -!- mibe has quit [Ping timeout: 250 seconds] 03:30:37 -!- DaneiTHREE has quit [Read error: Connection reset by peer] 03:31:05 -!- GauHelldragon has quit [Ping timeout: 240 seconds] 03:33:33 -!- Blade- has quit [Ping timeout: 268 seconds] 03:34:54 -!- molotove has quit [Quit: Leaving.] 03:39:40 -!- Kalir has quit [Quit: I'M OUT SON. PEACE, LOVE, EXPLOSIONS.] 03:44:16 -!- amalloy_ is now known as amalloy 03:48:18 -!- Shard1697 has joined ##crawl-dev 03:49:10 -!- ursan_ has quit [Ping timeout: 250 seconds] 03:55:48 -!- Blazinghand has quit [Read error: Connection reset by peer] 04:00:02 -!- Naruni has quit [Remote host closed the connection] 04:00:04 -!- omarax has quit [Remote host closed the connection] 04:09:35 -!- pikaro has quit [Ping timeout: 260 seconds] 04:19:36 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 04:21:54 -!- bonghitz has quit [Remote host closed the connection] 04:32:04 -!- ontoclasm1 has joined ##crawl-dev 04:34:05 -!- ontoclasm has quit [Ping timeout: 240 seconds] 04:34:30 -!- hexstein has quit [Quit: Leaving] 04:38:07 -!- Patashu has joined ##crawl-dev 04:39:24 -!- ontoclasm1 has quit [Quit: Leaving.] 04:40:42 -!- Evablue has quit [Quit: Evablue] 04:51:52 -!- ursan_ has quit [Ping timeout: 276 seconds] 04:52:01 -!- koboldina has quit [Quit: Page closed] 04:56:48 -!- dtsund has quit [Ping timeout: 268 seconds] 04:57:12 -!- tripout has quit [Ping timeout: 250 seconds] 05:00:04 -!- omarax has quit [Remote host closed the connection] 05:02:54 -!- ystael has quit [Ping timeout: 260 seconds] 05:03:10 -!- aurelian has quit [Quit: Page closed] 05:18:00 -!- Marvin is now known as Guest59161 05:22:53 -!- Guest59161 has quit [Ping timeout: 276 seconds] 05:29:56 xom.cc uses a spell called WARP_BRAND - should that be Warp Weapon, or is it a special xom spell or something? 05:49:30 -!- vale_ has quit [Remote host closed the connection] 06:00:01 -!- omarax has quit [Remote host closed the connection] 06:00:13 -!- NotKat has quit [Quit: Page closed] 06:18:49 -!- Marvin is now known as Guest63797 06:19:52 -!- edsrzf has quit [Ping timeout: 250 seconds] 06:22:57 -!- Guest63797 has quit [Ping timeout: 252 seconds] 06:28:57 -!- Doll has quit [Quit: Lost terminal] 06:37:41 -!- bonghitz has quit [Remote host closed the connection] 06:42:35 -!- bonghitz has quit [Ping timeout: 244 seconds] 06:42:35 -!- techieAgnostic has quit [Read error: Connection reset by peer] 06:51:15 WARP_BRAND is Warp Weapon 06:53:28 -!- ursan_ has quit [Ping timeout: 260 seconds] 07:00:01 -!- omarax has quit [Remote host closed the connection] 07:00:33 -!- jefus has quit [Ping timeout: 240 seconds] 07:03:16 -!- jefus has joined ##crawl-dev 07:14:03 -!- wheals has quit [Ping timeout: 240 seconds] 07:14:40 ??cbro 07:14:40 chequers: You have 2 messages. Use !messages to read them. 07:14:40 cbro[1/4]: Server in Georgia, US: crawl.beRotato.org -- ssh port 22, username crawler, keys at http://crawl.beRotato.org/crawl/keys (no password access). In case of DNS problems, use crawl.boylecraft.net. Webtiles at: http://crawl.beRotato.org. Use glyph/sigil ^ for bots 07:14:44 !messages 07:14:45 !messages 07:14:45 (1/2) |amethyst said (9h 7m ago): 0.0 in that map thing is suspicious... makes it sound like the file got truncated or something? 07:14:45 (1/1) PleasingFungus said (4h 44m 52s ago): send me a tell when it's ready to link, then! :) 07:15:29 -!- ystael has quit [Ping timeout: 276 seconds] 07:19:17 -!- MarvinPA has joined ##crawl-dev 07:21:30 elliptic: what's hare start time? 07:27:40 -!- Dracunos has quit [Quit: Bye] 07:29:17 -!- Lasty has joined ##crawl-dev 07:31:09 ??cbro 07:31:10 cbro[1/4]: Server in Georgia, US: crawl.beRotato.org -- ssh port 22, username crawler, keys at http://crawl.beRotato.org/crawl/keys (no password access). In case of DNS problems, use crawl.boylecraft.net. Webtiles at: http://crawl.beRotato.org. Use glyph/sigil ^ for bots 07:34:42 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 07:35:56 -!- nikheizen has quit [Quit: leaving] 07:41:12 -!- Doll has quit [Quit: Lost terminal] 07:43:26 -!- bonghitz has quit [Ping timeout: 276 seconds] 07:47:41 -!- mizu_no_oto has quit [Quit: Computer has gone to sleep.] 07:50:39 -!- techieAgnostic has quit [Quit: WeeChat 1.4-dev] 07:53:58 -!- ursan_ has quit [Ping timeout: 250 seconds] 07:54:01 !tell pleasingfungus if you want to check the dates this is ready to go live http://dobrazupa.org/tournament/0.18/ 07:54:01 chequers: OK, I'll let pleasingfungus know. 07:55:08 !tell pleasingfungus i made up a time for the clan cutoff btw. Also this tourney duration is +1 day longer than the last 07:55:08 chequers: OK, I'll let pleasingfungus know. 07:55:20 chequers: "hare" refers to the 100 points for the win with the latest start time; hare start time is the time at which the scripts begin to track these points (usually set to 24 hours before tourney end) 07:56:27 chequers: any particular reason to end the tourney on a monday rather than a sunday? we've always ended on a weekend before so that more players would be around for the end... 07:56:32 ah 07:58:41 elliptic: yeah I was wondering about that 08:00:01 -!- omarax has quit [Remote host closed the connection] 08:01:10 -!- amalloy is now known as amalloy_ 08:01:44 -!- Lasty has quit [Quit: Leaving.] 08:01:50 !tell pleasingfungus duration is now the same 08:01:50 chequers: OK, I'll let pleasingfungus know. 08:02:21 about the truncated noun field, I think it is pretty harmless to truncate it but increasing the column size would be fine too 08:02:56 yeah, one truncation seems ok 08:03:27 I forget exactly what milestones lead to really long nouns... it might just be a crash or some other milestone that isn't used for anything 08:06:57 ??lg 08:06:57 listgame[1/5]: !lg command displays info about past games. The manual is available here: https://github.com/crawl/sequell/blob/master/docs/listgame.md 08:07:22 !lm * current x=noun max=length(noun) 08:07:27 3843446. [2016-01-31 06:56:17] [noun=ASSERT(!monster at(p) || monster at(p)->submerged() || fedhas passthrough(monster at(p)) || mons is player shadow(monster at(p))) in 'player.cc' at line 523 failed.] ayayaya the Brawler (L19 TrHu of Ukayaw) ASSERT(!monster at(p) || monster at(p)->submerged() || fedhas passthrough(monster at(p)) || mons is player shadow(monster at(p))) in 'player.cc' at line 523... 08:07:41 probably fine to truncate 8) 08:08:02 !lm * current !crash x=noun max=length(noun) 08:08:08 3842369. [2016-02-05 14:59:14] [noun=blasted by a ball python (exploding inner flame) (transmuted by the player character (hexed by the player character))] Banto the Scratcher (L6 FeTm of Cheibriados) blasted by a ball python (exploding inner flame) (transmuted by the player character (hexed by the player character)) (D:6) 08:08:36 -!- ajacob has quit [Ping timeout: 276 seconds] 08:08:37 that one hopefully fits in the field still, I forget how long it is 08:09:20 though possibly (transmuted by the player character (hexed by the player character)) is a bug? I don't actually know what that means 08:09:53 anyway truncating felid death milestones is not a big deal either of course 08:10:19 117 chars 08:10:22 so should fit 08:10:37 actualy, noun is 100 08:10:37 !lm * current !crash !death x=noun max=length(noun) 08:10:44 3833707. [2016-02-27 08:35:29] [noun=remembered their ancestor Shedsu-nefertum's death as being explosive.] SatanTheUgly the Cleaver (L14 HOSk of Hepliaklqana) remembered their ancestor Shedsu-nefertum's death as being explosive on turn 20907. (Lair:5) 08:11:13 so nice of pleasingfungus to make big logs, they will compress better than expected :^) 08:19:32 -!- Marvin is now known as Guest20755 08:24:07 -!- Guest20755 has quit [Ping timeout: 260 seconds] 08:26:57 -!- Insomniak` has quit [Ping timeout: 244 seconds] 08:33:55 -!- debo_ has joined ##crawl-dev 08:34:18 -!- debo_ is now known as Guest17842 08:35:47 -!- elliptic has quit [Quit: Leaving] 08:35:51 -!- Doll has quit [Quit: Lost terminal] 08:39:40 -!- Doll has quit [Client Quit] 08:42:42 -!- AreBrandon has joined ##crawl-dev 08:44:03 -!- bonghitz has quit [Ping timeout: 240 seconds] 08:45:58 -!- Patashu has quit [Ping timeout: 252 seconds] 08:52:33 -!- ECbian has quit [Read error: Connection reset by peer] 08:54:22 -!- johlstei_ has quit [Read error: Connection reset by peer] 08:55:00 -!- ursan_ has quit [Ping timeout: 250 seconds] 08:59:52 -!- johlstei has joined ##crawl-dev 09:00:02 -!- omarax has quit [Remote host closed the connection] 09:01:24 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 09:07:25 -!- debo has quit [Ping timeout: 252 seconds] 09:09:45 -!- Surgo has quit [Read error: Connection reset by peer] 09:10:41 -!- debo has joined ##crawl-dev 09:12:32 -!- Doll has quit [Quit: Lost terminal] 09:20:49 -!- ololoev has quit [Quit: Page closed] 09:27:08 -!- Dracunos has quit [Quit: Bye] 09:28:16 -!- Evablue has quit [Quit: Evablue] 09:30:00 -!- Tux[Qyou] has joined ##crawl-dev 09:30:45 -!- Ratboiler has quit [Quit: Page closed] 09:38:51 -!- Lasty_ has quit [Quit: Leaving.] 09:40:05 -!- tealeaves has quit [Quit: Bye] 09:42:17 -!- AreBrandon has quit [Ping timeout: 260 seconds] 09:46:28 -!- bonghitz has quit [Ping timeout: 252 seconds] 09:53:43 -!- AreBrandon has joined ##crawl-dev 09:54:19 -!- Guest17842 is now known as debo__ 10:00:02 -!- omarax has quit [Remote host closed the connection] 10:01:03 -!- Rust3dCor3 has quit [Ping timeout: 276 seconds] 10:04:46 -!- Ubk has quit [Ping timeout: 250 seconds] 10:08:19 -!- mizu_no_oto has quit [Read error: Connection reset by peer] 10:10:03 -!- ystael has quit [Read error: Connection reset by peer] 10:15:50 -!- mizu_no_oto has quit [Client Quit] 10:20:14 -!- Marvin is now known as Guest3130 10:24:50 -!- Guest3130 has quit [Ping timeout: 268 seconds] 10:29:08 -!- SurpriseTRex has quit [Read error: Connection reset by peer] 10:32:54 -!- Shard1697 has quit [Ping timeout: 276 seconds] 10:37:31 -!- tealeaves has quit [Quit: Bye] 10:45:26 -!- Dracunos has quit [Ping timeout: 276 seconds] 10:47:35 -!- tealeaves has quit [Quit: Bye] 10:50:43 -!- grimmulfr has quit [Remote host closed the connection] 10:50:58 -!- Ubk has joined ##crawl-dev 10:52:18 -!- zxc has joined ##crawl-dev 10:52:36 -!- Kat_ is now known as Kat 10:52:39 -!- ursan_ has quit [Ping timeout: 260 seconds] 10:52:56 -!- Kat is now known as NotKat 10:53:04 -!- Shard1697 has joined ##crawl-dev 10:54:43 -!- zxc_ has quit [Ping timeout: 244 seconds] 10:57:30 -!- bonghitz has quit [Remote host closed the connection] 10:59:00 -!- Nerem has quit [Ping timeout: 250 seconds] 11:00:01 -!- omarax has quit [Remote host closed the connection] 11:00:34 -!- bonghitz has quit [Remote host closed the connection] 11:01:06 -!- AreBrandon has quit [Ping timeout: 250 seconds] 11:01:50 -!- AreBrandon has joined ##crawl-dev 11:06:41 -!- BigBluFrog has quit [Quit: Page closed] 11:08:01 -!- ystael has quit [Read error: Connection reset by peer] 11:08:35 -!- ystael has quit [Read error: Connection reset by peer] 11:13:55 -!- Dracunos7 is now known as Dracunos 11:16:07 -!- Tux[Qyou] has quit [Read error: Connection reset by peer] 11:22:03 -!- tealeaves has quit [Quit: Bye] 11:26:41 -!- scummos__ has quit [Ping timeout: 250 seconds] 11:28:58 -!- Daekdroom has quit [Quit: Leaving] 11:31:32 -!- namelastname112 has joined ##crawl-dev 11:31:53 can you get blurry vision as a race with acute eyesight? 11:36:30 <|amethyst> namelastname112: looks like no: 11:36:34 <|amethyst> if (you.innate_mutation[b] >= you.mutation[b]) 11:36:34 <|amethyst> return -1; 11:36:40 <|amethyst> in _handle_conflicting_mutations 11:37:04 thanks 11:37:05 <|amethyst> where here b would be MUT_ACUTE_VISION 11:37:50 <|amethyst> oddly, that is prevented here even though I think you *could* have both permanent non-innate acute eyesight and temporary (wretched star) blurry vision 11:51:03 -!- siepu has quit [Quit: Leaving] 12:00:02 -!- omarax has quit [Remote host closed the connection] 12:03:52 -!- MarvinPA has quit [Read error: Connection reset by peer] 12:05:33 -!- ystael has quit [Read error: Connection reset by peer] 12:07:24 -!- bonghitz has quit [Remote host closed the connection] 12:08:27 -!- MarvinPA has joined ##crawl-dev 12:12:37 -!- svendre has joined ##crawl-dev 12:12:47 -!- molotove has quit [Quit: Leaving.] 12:15:44 hi, can anyone please help me figure out how to get past a compile error? I've pasted the end of the output here: http://pastebin.com/c5HRssft 12:16:05 It was done with MinGW SDK 64 12:17:18 the makefile on that line ends with: config.h: util/configure .cflags ${QUIET_GEN}util/configure "$(CXX)" $(STDFLAG) $(ALL_CFLAGS) 12:19:57 -!- ystael has quit [Read error: Connection reset by peer] 12:21:04 -!- Marvin is now known as Guest72064 12:25:11 -!- Guest72064 has quit [Ping timeout: 250 seconds] 12:25:41 -!- amalloy_ is now known as amalloy 12:27:32 hmm, how come the "Mace of Variability" and the "Sceptre of Torment" get their weapon type capitalised, but the "sword of Jihad" and the "trident of the Octopus King" don't 12:29:14 -!- Blazinghand has joined ##crawl-dev 12:29:15 -!- Zibudo has joined ##crawl-dev 12:30:02 if it were consistent, it wouldn't be crawl >.> 12:35:26 -!- wheals has joined ##crawl-dev 12:35:31 -!- wheals has quit [Remote host closed the connection] 12:35:53 -!- Ququman has joined ##crawl-dev 12:41:30 -!- tealeaves has quit [Quit: Bye] 12:41:52 -!- PleasingFungus has joined ##crawl-dev 12:43:32 -!- bonghitz has quit [Remote host closed the connection] 12:45:24 !tell chequers The Final Tournament Page Nit: i'm fairly certain the 22nd is not a monday... also, all, the top bar links on that tournament page are 404s 12:45:24 PleasingFungus: You have 3 messages. Use !messages to read them. 12:45:24 PleasingFungus: OK, I'll let chequers know. 12:46:15 !tell chequers the clan cutoff is traditionally "a week into the tournament", so friday the 13th would be reasonable (!), but it's w/e 12:46:16 PleasingFungus: OK, I'll let chequers know. 12:47:16 svendre: what's up? 12:47:25 once again the compile error info is here: http://pastebin.com/c5HRssft 12:47:36 the makefile on that line ends with: config.h: util/configure .cflags ${QUIET_GEN}util/configure "$(CXX)" $(STDFLAG) $(ALL_CFLAGS) 12:48:23 trying to get a compile to work, it's failing on Makefile line 1626 (the source was downloaded earlier today) 12:48:45 -!- debo__ has quit [Ping timeout: 276 seconds] 12:48:51 i'm not going to be able to help here, sorry, but for the record, what platform are you compiling on? some version of windows, linux, os x...? 12:49:07 windows7 MinGW SDK 64 12:49:14 ahh 12:49:16 !seen wheals 12:49:16 I last saw wheals at Tue Apr 26 16:35:32 2016 UTC (13m 44s ago) quitting, saying 'Remote host closed the connection'. 12:49:29 i would probably talk to wheals or |amethyst about this 12:49:31 maybe I should give cygwin a try? 12:49:32 if you haven't already 12:49:34 maybe! 12:49:51 I see, they are the build engineers? 12:50:13 ha ha ha 12:50:20 -!- AreBrandon has quit [Ping timeout: 246 seconds] 12:50:40 wheals is the only dev i know of who compiles on windows, and amethyst is the one with the most knowledge of the build scripts, iirc. 12:50:56 i know nothing about either. 12:51:10 mmkay, then maybe an easier solution would be for me to compile on linux instead 12:51:21 if you can, probably, yeah 12:51:32 windows also doesn't have stack traces, it's kind of a PITA to work on 12:51:45 also iirc compilation is quite slow there 12:51:45 studio does 12:52:05 the msvc build? is taht currently working? 12:52:26 the help file talks about it working, but I don't know if it's dated... the windows binaries must be getting generated by someone.... 12:53:43 fair point. i never remember who makes those builds 12:53:56 -!- AreBrandon has joined ##crawl-dev 12:54:45 <|amethyst> official windows binaries are built on CDO using mingw cross compiler 12:55:05 hi amethyst 12:55:09 <|amethyst> probably mumra was the last person to try an MSVC build 12:55:11 <|amethyst> hi 12:55:22 -!- NotKat has quit [Ping timeout: 250 seconds] 12:55:22 no, someone did more recently, i recall 12:55:27 a year or two ago 12:55:28 did you happen to see my question about the compile error? 12:55:36 also hi!!! 12:55:50 hey and by the way, thanks for getting the score stats back online :D 12:56:36 -!- RBrandon has joined ##crawl-dev 12:57:33 the closest thing I could find was: The make command is failing for the simple reason that the ./configure script did not complete successfully, as indicated by the error messages 12:58:07 the configure script can't find something 12:58:09 <|amethyst> that's strange 12:58:31 <|amethyst> ohh 12:58:39 <|amethyst> you script has Windows line endings 12:58:47 http://pastebin.com/c5HRssft 12:58:54 <|amethyst> I don't remember the setting, but there's some way to tell Windows git not to do that 12:58:57 <|amethyst> ??crlf 12:58:57 I don't have a page labeled crlf in my learndb. 12:58:59 <|amethyst> ?/crlf 12:58:59 No matches. 12:59:03 ahh the crap about EOL codes? 12:59:08 <|amethyst> yeah 12:59:20 <|amethyst> ": not foundure: 2: util/configure:" 12:59:31 hmm yeah I recall running into problems like that in perl a long time ago 12:59:50 some editors putting it in if you so much as open the file 13:00:01 -!- omarax has quit [Remote host closed the connection] 13:00:03 -!- Zibudo has quit [Ping timeout: 240 seconds] 13:00:04 <|amethyst> there is also a git setting about that 13:00:15 <|amethyst> and IIRC the default is to convert to Windows line endings 13:00:21 <|amethyst> which doesn't work for things like shell scripts 13:00:28 -!- Zibudo has joined ##crawl-dev 13:00:52 so, maybe try stripping those control codes out of the file? 13:01:06 -!- AreBrandon has quit [Ping timeout: 276 seconds] 13:01:14 -!- debo__ has joined ##crawl-dev 13:02:05 <|amethyst> yes, or looking up that git setting and doing a fresh checkout 13:02:16 <|amethyst> gtg now, sorry to drop in and run 13:02:27 cool, thanks I'll mess around with that 13:02:31 https://help.github.com/articles/dealing-with-line-endings/ 13:02:43 03MarvinPA02 07* 0.18-a0-1809-g8064f64: Remove the Talos armour unrand 10(42 minutes ago, 5 files, 4+ 1-) 13https://github.com/crawl/crawl/commit/8064f645b216 13:02:49 says what to set, and what to do if you already check out your repo with the wrong setting 13:03:03 amalloy: thanks 13:03:20 -!- ystael has quit [Read error: Connection reset by peer] 13:04:49 Unstable branch on crawl.akrasiac.org updated to: 0.18-a0-1808-g3e993bd (34) 13:05:30 -!- MarvinPA has quit [Remote host closed the connection] 13:07:59 -!- MarvinPA has joined ##crawl-dev 13:09:45 -!- Blade- has joined ##crawl-dev 13:10:09 though since the repo itself is fine, and you only need to update your working copy, i'd say you probably need only stes 2 and 3 13:14:54 lol, well... I did a simple replace in the file "configure" only, [CR]LF into [LF] only, and the compile is going on it's merry way -- odd that it doesn't care about the [CR] codes in the Makefile or other places 13:15:12 -!- Twiggytwiggytwig has quit [Quit: See ya guys later ;)] 13:16:30 I'm curious now if it'll make it all the way (pun not intended) 13:17:03 maybe something can be done with that one file so the whole process is less finicky 13:17:03 -!- Ratboiler has quit [Quit: Page closed] 13:17:19 -!- GauHelldragon has quit [Ping timeout: 244 seconds] 13:17:37 -!- ystael has quit [Read error: Connection reset by peer] 13:18:11 maybe it has something to do with a script calling another script instead of the script being run directly 13:28:56 hah - it completed! 13:29:11 (: 13:29:15 I Helped 13:29:21 now to see if it runes.. yeah you did 13:29:30 amethyst nailed it though :D 13:29:54 couldn't that script in configure just be integrated into the makefile?? 13:30:00 it's pretty short 13:30:56 .... and the compilation.... worked! game started 13:31:27 0.18-a0-1805-g8ab820f 13:31:54 time to start hacking 13:32:46 is there a list of pre-approved changes/features that need worked on that noone has claimed yet? 13:33:13 -!- Blazinghand has quit [Read error: Connection reset by peer] 13:34:00 in Mantis? 13:34:16 sort of, there are implementables on mantis 13:34:29 some are old and out-of-date though 13:34:54 I should probably start with something relatively simple until I know where stuff is better 13:36:00 if you filter by category: implementable you should see them, i think PF put up a few code-cleanup-y ones recently that might be a good starting point 13:36:10 ok 13:38:25 i really need to look at that item pickup thing someone posted 13:38:41 naruni 13:40:14 item pickup thing, that sounds like something I wrote 13:40:35 the thing with filtering by type? 13:40:39 n 13:40:43 pickup with full inventory 13:41:03 yeah, they were in here chatting about it the other day, i failed to be helpful but it looked like maybe quite a complicated thing to implement 13:41:09 if you mean the using items from the floor thing 13:41:12 ya 13:41:23 svendre: the problem is, if a dev thinks of something straightforward and interesitng to do, they'll probably just do it. the simplest thing i have lying around is the implementable for rewriting notes.cc; shouldn't have an impact on gameplay but would help you cut your teeth on the codebase 13:41:58 making it conform to coding standards? 13:42:12 'standards' is a strong term. making it not awful 13:42:16 or actually cleaning it up 13:42:22 I'll take a look 13:42:32 !bug 10282 13:42:32 https://crawl.develz.org/mantis/view.php?id=10282 13:42:46 lemme know if there's anything unclear 13:43:25 alright, no guarantees of any immediate results but I'll start examining it 13:43:33 ofc :) 13:44:19 !learn del amalloy_todo[$ 13:44:19 Deleted amalloy todo[6/6]: destroy ontoclasm and all ontoclasm holds dear 13:45:12 wow, didn't realize you'd finished that already! 13:48:35 -!- Ironfoot has quit [Quit: Page closed] 13:51:36 -!- CanOfWorms has joined ##crawl-dev 13:53:45 PleasingFungus: do you have any preferences as far as these types of approaches? http://stackoverflow.com/questions/14136721/converting-many-if-else-statements-to-a-cleaner-approach 13:54:30 heh, that's very java. 13:54:54 Let me refresh my memory on the code. 13:56:44 -!- svendre_ has joined ##crawl-dev 13:57:00 sorry - had to reconnect, may have missed a reply 13:57:08 nah 13:58:12 -!- svendre has quit [Ping timeout: 250 seconds] 13:58:21 Okay. Two horrible things. One, the very long list in _is_noteworthy(). Two, the big switch/case in Note::describe(). 13:59:37 First is simpler to handle. Could do it two ways: either use a map (MB_TRUE, MB_FALSE, MB_MAYBE - see enum.h) and continue special-casing anything that's not always true/false... 14:00:01 -!- omarax has quit [Remote host closed the connection] 14:00:12 special casing... 14:00:19 Sometimes special cases are okay! 14:00:43 Or, use a map> and have most of the note types point to a static const "always return true" or "always return false" function. 14:01:07 -!- ystael has quit [Read error: Connection reset by peer] 14:02:08 e.g. static bool _never_note(const Note& /*unused*/) { return false; } 14:02:17 > noteworthy = { { NOTE_MP_CHANGE, _never_note }, ... 14:02:34 also probably the ones that are always false should be removed, there's no reason to maintain them. 14:02:46 that's a separate issue, just something i noticed while looking through this. 14:02:50 with me so far? 14:03:05 I'm taking notes to follow up on 14:03:19 my most recent projects were fully oop in c++ 14:03:19 -!- Yermak has quit [Quit: Page closed] 14:03:24 and they weren't recent haha 14:03:54 this is more like, script 14:03:57 oop is obsolete. c with gotos is the future 14:04:19 gotos hah 14:04:20 10 print "hello world" 14:04:23 20 goto 10 14:04:47 just so 14:04:54 C64 basic 14:05:03 <|amethyst> in general we prefer, if possible, doing things with tables of data rather than inheritance and virtual functions 14:05:09 oh I forgot the 10 print "hello world"; 14:05:18 ya 14:06:08 I once had a program that would use poke commands on the C64 and print text and hit enter on it, so the code would modify itself and then re-run itself, those were the days 14:06:10 <|amethyst> IMO it isn't much benefit to change case FOO: blah; break; case BAR: fum; break; .... into Foo::thingy() { blah } Bar::thingy() { fum } 14:06:38 ya 14:06:53 <|amethyst> but if you can make that into something more like thingies = { { FOO, blahdata }, { BAR, fumdata } } it's definitely a win 14:08:00 anyway, the big switch/case is more of a mess. that gets into a bigger issue with this: we're saving and loading this data, and expecting all notes to have the same set of fields. so they each have two generic int fields and two generic string fields, which are reinterpreted for each note type. quite messy 14:11:57 alright, I've saved all the comments as notes, I just need time to look at it and see how it connects with the rest of the game and look at stuff 14:12:15 my feeling is that the simplest approach here is to discard a constraint. right now we're saving and loading actual note objects; i don't think there's any particular reason to do that. we can just save the output of the note-taking process, a string or list of strings. the only functionality we would lose from that is that players changing their settings midway through a game would no... 14:12:15 get up to speed, etc. 14:12:16 ...longer need to be able to hide or show previously made notes for skill level changes 14:12:49 are these notes what are used to generate the morgue files? 14:13:11 a small part of them 14:13:12 or it's just, when to print something .... you reached level X in skill, etc... 14:13:20 no, they're not printed in-game 14:13:24 they're like 14:13:39 7167 | D:7 | Killed Duvessa 14:13:43 11135 | D:11 | Reached XP level 11. HP: 84/84 MP: 11/11 14:13:55 -!- Kalir has quit [Changing host] 14:14:11 i guess we'd need to store a turn number, a place, and the string, but we wouldn't need the generic ints & strings, which are my real problem with the current setup. 14:14:22 -!- dtsund has joined ##crawl-dev 14:15:24 -!- ystael has quit [Read error: Connection reset by peer] 14:15:56 we might be able to ditch the note enum system entirely (except for loading old saves), and just have separate functions for taking different types of notes (as appropriate) 14:16:08 are they used to determine various logic in other places? 14:16:12 no 14:16:29 I'm puzzled then what is their purpose, besides (partial?) morgue file generation 14:16:29 they're quite separate from the rest of the game, which is one reason why i put them up as an implementable 14:16:32 that's it 14:16:32 -!- tealeaves has quit [Quit: Bye] 14:16:35 they're used in morgue files 14:17:06 <|amethyst> and ?: of course 14:17:22 so in other places, someone calls these things... to say that X or Y or Z happened, and this is the file which processes that? 14:17:44 and they've become like generic whatever ppl want to pass? 14:18:05 |amethyst: :) 14:18:12 svendre_: yes to the first part 14:18:18 not sure what you mean by the second 14:18:37 they just call a particular event, not passing any params? 14:18:45 the params what you meant about first, second, 14:19:30 err it's building strings 14:19:41 this seems .. strange 14:19:46 why not just have a database table of events 14:19:47 I still don't understand what you're asking. 14:20:07 What would a database offer over an array, here? 14:20:13 It's not like we're doing queries on this. 14:20:16 I'm just kind of puzzled what this thing does, it's like a string builder 14:20:28 It's a very ornate string builder, yeah. 14:20:36 With some added filtering functionality. 14:20:36 name looks like the main thing it's inserting over and over 14:21:39 -!- Dracunos has quit [Ping timeout: 268 seconds] 14:21:46 -!- Marvin is now known as Guest35990 14:21:57 ok let me try and say this more clearly 14:22:03 I'm talking about seperating the data from the logic 14:22:23 -!- cang has quit [Quit: Page closed] 14:24:29 well, I'll just look at it some more and get back about it, I don't know I may be off track until I understand what it's doing better first.. so, I'll get back to you later :D going to read through stuff 14:24:37 cool! 14:24:41 :) 14:26:02 -!- Guest35990 has quit [Ping timeout: 244 seconds] 14:26:04 -!- Nattefrost has quit [Ping timeout: 240 seconds] 14:26:32 -!- bonghitz has quit [Remote host closed the connection] 14:26:58 -!- RBrandon has quit [Ping timeout: 252 seconds] 14:28:15 -!- Dracunos7 has quit [Ping timeout: 250 seconds] 14:29:41 -!- hccc has quit [Quit: Page closed] 14:39:28 -!- Blade- has quit [Ping timeout: 244 seconds] 14:40:49 -!- scummos| has quit [Ping timeout: 250 seconds] 14:41:22 -!- ontoclasm has joined ##crawl-dev 14:49:06 -!- PleasingFungus has quit [Ping timeout: 250 seconds] 14:51:05 -!- ProzacElf has joined ##crawl-dev 14:52:21 -!- tealeaves has quit [Quit: Bye] 14:53:23 oh god, I see now more of what is going on 14:53:34 indeed it's messy 14:53:48 -!- PleasingFungus has joined ##crawl-dev 14:53:59 take_note ..... if _is_noteworthy... etc. etc. 14:55:35 HMM 14:56:25 -!- Dracunos7 has quit [Read error: Connection reset by peer] 14:56:36 -!- Denapoli has quit [Quit: Page closed] 14:58:13 -!- Dracunos has quit [Ping timeout: 250 seconds] 14:58:20 -!- Marvin is now known as Guest44116 14:58:55 -!- ystael has quit [Read error: Connection reset by peer] 15:00:02 -!- omarax has quit [Remote host closed the connection] 15:03:47 -!- ystael has quit [Ping timeout: 250 seconds] 15:05:55 -!- Tux[Qyou] has joined ##crawl-dev 15:06:10 i guess people would probably be sad if we removed the messages for newly equipped weapons "bursting into flame" etc 15:07:04 -!- Zibudo has quit [Ping timeout: 240 seconds] 15:07:24 "Your +1 falchion of flaming bursts into flame!" is a very silly message, though 15:07:29 it's just silliness all the way down 15:07:43 w/e 15:07:51 -!- hewge has quit [Ping timeout: 276 seconds] 15:07:55 -!- Zibudo has joined ##crawl-dev 15:08:24 -!- Cabb has quit [Quit: Leaving] 15:09:43 "ignites" 15:10:04 -!- Zekka has quit [Ping timeout: 240 seconds] 15:10:16 "You notice your +1 falchion of flaming heating up a delicious Hot Pocket!" 15:10:31 hah 15:10:44 "Your +1 falchion of flaming is hot, hot, HOT!" 15:10:58 -!- Shadou has quit [Quit: Page closed] 15:13:41 03PleasingFungus02 07* 0.18-a0-1810-g4d79ab2: checkwhite & unbrace 10(14 minutes ago, 2 files, 2+ 4-) 13https://github.com/crawl/crawl/commit/4d79ab255802 15:13:41 03PleasingFungus02 07* 0.18-a0-1811-g3a71842: Reduce wield message ambiguity (10369, Naruni) 10(2 minutes ago, 1 file, 27+ 12-) 13https://github.com/crawl/crawl/commit/3a7184276089 15:14:54 -!- svendre_ has quit [Ping timeout: 250 seconds] 15:15:19 -!- t4nk484 has quit [Client Quit] 15:18:15 -!- simmarine has joined ##crawl-dev 15:18:23 -!- Dracunos7 is now known as Dracunos 15:18:31 -!- scummos__ has quit [Ping timeout: 250 seconds] 15:18:53 -!- svendre has joined ##crawl-dev 15:21:17 I'm a bit puzzled, I only see about 5 namespaces 15:21:27 we don't really use namespaces 15:21:30 std geom worley 15:21:33 and arena 15:21:36 -!- bonghitz has quit [Remote host closed the connection] 15:22:11 so it's like one big giant pool of globals? 15:22:41 -!- Guest44116 has quit [Remote host closed the connection] 15:22:50 -!- zxc has quit [Read error: Connection reset by peer] 15:23:13 -!- zxc has joined ##crawl-dev 15:24:25 I was thinking something cool to track events could be done with polymorphism, but it looks like it would be a major overhaul to attempt that 15:24:35 cool like what? 15:25:04 sort of like a running debug log which tracks the actual calls 15:25:27 then you would have too much data, and another class would filter it down to what you want to see and translate into text 15:25:40 Isn't that what we have right now? 15:25:52 no, they are manual calls 15:26:00 take_note(...blahblah) 15:26:11 So what would you be tracking? Every function call? 15:26:16 where it could be automatic tracking of various class function calls by name 15:26:26 only functions defined that way 15:26:59 So you want, what, function decorators? 15:27:11 Sounds quite a lot more complex than the current system. 15:27:16 Not sure what the advantage would be? 15:28:08 it can be useful, it doesn't have to be that difficult - if you inherit farther upstream 15:28:34 It sounds like you want to rewrite our entire codebase into another style, tbh. 15:28:36 Im not sure that it would work to try and do it with the current code base though, it would require a lot of overhauls... I'm trying to wrap my head around it 15:29:27 not really want to, it's more like - I'm trying to go from what I was more used to back to script 15:29:38 it's kind of a mindfuck :D 15:29:54 'script' is an interesting term. 15:30:10 I'm really impressed that it's this big and not coming apart 15:30:21 easier in some ways harder in others 15:30:46 it's an adventure 15:30:49 I haven't read a lot of it though still 15:31:17 when I was writing, I was doing multi-threaded apps with a lot of inheritance 15:31:18 for a fun time, look at initfile.cc 15:31:33 we're technically multithreaded, iirc 15:31:35 in tiles 15:32:01 we've still got some good subtle bugs from that which no one's tracked down 15:32:09 I know of one 15:32:12 at least online 15:32:20 where your character tile gets ghosted 15:32:22 webtiles isn't multithreaded. 15:32:29 Or, well, not in a relevant way. 15:32:35 or a menu dialog box won't close if someone just joined spectator at the same time you opened it 15:32:44 !source initfile.cc:3514 15:32:44 https://github.com/crawl/crawl/blob/master/crawl-ref/source/initfile.cc#l3514 15:32:49 ^ good initfile line 15:33:03 tell me more about the 'ghosting', i haven't heard of htat one 15:33:06 anyways I see what's going on with the notes system 15:33:33 I'm not saying it's bad (well it could be cleaned up) it's just a simple way to post stick-its to the wall when someone wants and then go from there 15:33:53 it's me that gets all wrapped around the axel thinking about more complex designs, in this case, probably not relevant - 15:33:58 -!- zxc has quit [Read error: Connection reset by peer] 15:34:16 but what I was talking about is kind of nice, to have for debugging... sort of like an internal trace 15:34:26 you can add it with an outer shell wrapper fairly easily 15:34:29 ok the ghosting bug 15:34:42 so what happens sometimes, online in webtiles: 15:34:43 i mean, if you wanted that, wouldn't you just go in with gdb or s/t? 15:35:07 occasionally when moving, the picture of the character is shown in a position where you are not anymore (you see yourself twice in two places) 15:35:16 it disappears when you walk on top of the square and move again 15:35:25 neat 15:35:28 what browser? 15:35:34 I'm not sure, but I suspect it's related to spectators joining 15:35:40 speculation... 15:35:43 IE at least, I think also Chrome 15:35:47 imo report it with a screenshot the next time it happens 15:35:48 lol ie 15:36:02 I can tell you for sure there is a bug about the inventory or skills windows opening up timed with a spectator joining 15:36:07 then the window cannot be closed 15:36:15 sure 15:36:24 next time I can snap it I will 15:36:50 ok so I've got a question 15:37:08 seems in a lot of cases, people are passing different variables in the middle of the notes text 15:37:43 if that data is accessible to notes.cc 15:39:29 couldn't you have a defined format per note, like text text text $variableX text text $variableY, where it was more static - all in one place? 15:40:29 Just use a printf, you mean? 15:40:46 "Took %d damage in area %s" 15:40:57 yeah something like that 15:41:17 and each "note" has it's output defined like that 15:41:23 all in one location 15:41:31 Absolutely. 15:41:41 then the logic enumerates through the definition to build the string 15:42:17 Why not just use printf? 15:42:24 -!- Leszczynek has quit [Quit: KVIrc 4.2.0 Equilibrium http://www.kvirc.net/] 15:43:00 well, agreed why not 15:43:05 or make_stringf(), I guess 15:43:47 you could have one cleaner function which pulls the format based on the keyword 15:43:52 then just print it 15:44:23 You wouldn't need a function for that, just a map 15:45:23 so pretty much that would just mean rounding up all the calls scattered around the code - getting them together in one place 15:45:41 the data in them at least 15:46:27 I'm not sure I follow. 15:46:54 in a place where take_note is called 15:47:06 -!- Yermak has joined ##crawl-dev 15:47:16 instead of take_note(blah blah blah, blah blah $variableX, $variableY) 15:47:27 it would be take_note(Note_keyword) 15:47:37 and those other details would be centralized 15:48:10 hrm 15:48:23 that seems to imply there's no context-sensitive detail 15:48:30