00:00:25 Stable (0.11) branch on crawl.s-z.org updated to: 0.11.1-14-gb33f2e8 00:01:09 Unstable branch on crawl.s-z.org updated to: 0.12-a0-1261-g70e25bb (34) 00:01:11 Unstable branch on crawl.develz.org updated to: 0.12-a0-1261-g70e25bb (34) 00:02:35 -!- ToastyP has quit [Quit: ChatZilla 0.9.89 [Firefox 17.0.1/20121128204232]] 00:07:39 Windows builds of master branch on crawl.develz.org updated to: 0.12-a0-1261-g70e25bb 00:09:47 -!- MarvinPA has quit [Ping timeout: 260 seconds] 00:14:40 -!- Datul has quit [Quit: Page closed] 00:21:11 -!- jeremie has quit [Quit: Page closed] 00:26:54 -!- SurpriseTRex has quit [Ping timeout: 240 seconds] 00:32:11 -!- Dixbert has joined ##crawl-dev 00:36:12 -!- mamga has quit [Quit: Page closed] 00:43:14 -!- Blazinghand_ has quit [Ping timeout: 240 seconds] 00:43:28 -!- Crazylemon64 has quit [Ping timeout: 252 seconds] 00:52:08 -!- monqy has quit [Quit: hello] 01:00:09 -!- ophanim has quit [Read error: Connection reset by peer] 01:07:11 -!- virigoth has quit [Ping timeout: 252 seconds] 01:21:36 -!- Kalir has quit [Quit: CADENZA-CLASS CLOCKWORK KNIGHT--OPERATION TERMINATED] 01:22:45 -!- kekekela has quit [Quit: Page closed] 01:37:22 -!- NeremWorld has quit [Ping timeout: 252 seconds] 01:38:27 -!- Senjai has quit [Ping timeout: 260 seconds] 01:51:01 -!- Crazylemon64 has quit [Ping timeout: 244 seconds] 01:58:47 -!- crate has quit [Quit: Leaving] 02:07:51 -!- sym` has quit [] 02:11:06 -!- remyroy has quit [Read error: Connection reset by peer] 02:18:39 -!- casmith789 has quit [Ping timeout: 255 seconds] 02:20:27 -!- Crazylemon64 has quit [Quit: Crazylemon64] 02:24:34 -!- WalkerBoh has quit [Quit: Page closed] 02:41:39 -!- Crazylemon64 has quit [Ping timeout: 244 seconds] 02:44:32 -!- dtsund has quit [Quit: dtsund] 02:52:37 -!- Blazinghand_ has quit [Ping timeout: 248 seconds] 02:56:19 -!- rast has quit [Remote host closed the connection] 02:58:40 -!- _dd has joined ##crawl-dev 03:00:01 -!- Ragdoll has joined ##crawl-dev 03:17:48 -!- clouded_ has quit [Ping timeout: 250 seconds] 03:19:23 -!- smeea has quit [Read error: Connection reset by peer] 04:02:53 -!- edlothiol has joined ##crawl-dev 04:05:27 -!- G-Flex has quit [Ping timeout: 260 seconds] 04:14:38 -!- ZyrKx_ has quit [Read error: Connection reset by peer] 04:15:26 -!- Nietzsche_ has quit [Client Quit] 04:17:38 -!- TacoSundae has quit [Quit: Leaving.] 04:18:42 -!- Zhukov has quit [Ping timeout: 252 seconds] 04:28:48 -!- vendetta has quit [Ping timeout: 245 seconds] 04:46:21 -!- nooodl_ has joined ##crawl-dev 04:52:00 -!- bonghitz has quit [Quit: bonghitz] 04:56:56 -!- DracoOmega has quit [Quit: Leaving] 05:00:04 OSX builds of master branch on crawl.develz.org updated to: 0.12-a0-1261-g70e25bb 05:00:49 -!- syllogism has joined ##crawl-dev 05:02:27 -!- Zifmia has quit [Remote host closed the connection] 05:08:43 -!- MarvinPA has joined ##crawl-dev 05:15:22 -!- Zaba has quit [Ping timeout: 265 seconds] 05:17:29 -!- Zaba has joined ##crawl-dev 05:24:13 -!- eurtek has quit [Ping timeout: 245 seconds] 05:31:47 -!- Zaba has quit [Ping timeout: 260 seconds] 05:41:12 -!- Zaba has joined ##crawl-dev 05:46:08 -!- alefury has joined ##crawl-dev 05:53:25 -!- domiryuu has quit [Quit: leaving] 06:13:06 -!- DainDwarf has quit [Quit: Dain's default quit message] 06:19:54 -!- stanzill has quit [Quit: tierarzt, mumpf] 06:25:35 -!- MarvinPA has quit [Ping timeout: 260 seconds] 06:26:29 -!- phirt has quit [Quit: Page closed] 06:33:09 -!- fernandotakai has quit [Remote host closed the connection] 06:37:48 -!- vogonpoet has quit [Quit: Page closed] 06:50:49 -!- Pikkle has joined ##crawl-dev 06:55:00 -!- monqy has joined ##crawl-dev 07:01:20 -!- Poncheis has quit [Read error: Connection reset by peer] 07:18:11 -!- cybie04 has quit [Ping timeout: 260 seconds] 07:23:50 -!- Serfuzz has quit [Remote host closed the connection] 07:32:02 -!- kek has joined ##crawl-dev 07:32:56 -!- _D_ has quit [Quit: leaving] 07:50:30 -!- archl has quit [Ping timeout: 264 seconds] 07:56:00 -!- ZyrKx has quit [Ping timeout: 264 seconds] 07:56:26 -!- cybie04 has quit [Ping timeout: 255 seconds] 08:00:23 -!- MarvinPA has joined ##crawl-dev 08:16:40 -!- scummos has quit [Ping timeout: 252 seconds] 08:26:23 -!- _D_ has quit [Quit: leaving] 08:28:27 -!- anele has quit [Read error: Connection reset by peer] 08:32:54 -!- Nightbeer has quit [Ping timeout: 240 seconds] 08:49:54 -!- ilyak has quit [Quit: Lost terminal] 08:51:38 -!- Xenobreeder has quit [Quit: Leaving] 08:55:10 -!- Dedagen has quit [Quit: Leaving.] 09:09:13 -!- kekekela has quit [Ping timeout: 245 seconds] 09:25:11 -!- shmup has quit [Quit: leaving] 09:26:36 -!- Dixbert has quit [Ping timeout: 264 seconds] 09:28:34 -!- cybie04 has quit [Ping timeout: 240 seconds] 09:36:18 -!- Kellhus has quit [Ping timeout: 245 seconds] 09:37:13 -!- monqy has quit [Quit: hello] 09:52:24 -!- archl has quit [Quit: ChatZilla 0.9.89 [Firefox 17.0/20121120062532]] 10:02:06 -!- mamga has quit [Quit: Page closed] 10:08:01 -!- dagonfive has quit [Read error: Connection reset by peer] 10:09:23 -!- Kalir has quit [Changing host] 10:18:24 -!- faketrog_ is now known as OCTOTROG 10:25:32 -!- shirish has joined ##crawl-dev 10:26:07 -!- shmup has quit [Quit: leaving] 10:37:08 -!- Datul has quit [Quit: Page closed] 10:37:24 -!- Spavven has quit [Ping timeout: 264 seconds] 10:42:08 -!- Phrizz11 has quit [Ping timeout: 245 seconds] 10:42:22 -!- elliptic has quit [Quit: Leaving] 10:44:46 -!- elliptic has joined ##crawl-dev 10:46:46 -!- kek has quit [Quit: f00d] 11:02:16 -!- Daekdroom has quit [Quit: Saindo] 11:06:59 -!- kek has joined ##crawl-dev 11:14:00 -!- bh has joined ##crawl-dev 11:15:13 morning 11:26:05 evenin' 11:28:31 afternoon 11:29:06 whoa.... 11:40:21 <|amethyst> no Australians to say "night"? 11:40:30 <|amethyst> what has become of crawl? 11:40:35 or anyone in Guam? 11:41:19 due is sleeping already 11:41:54 -!- DaneiTWO has quit [] 11:42:05 * kilobyte hasn't seen him past 15-16:00 my time 11:42:14 (18:42 right now) 11:44:29 -!- Xares has quit [Quit: Leaving] 11:46:33 -!- stenno has quit [Disconnected by services] 11:46:35 -!- stenno__ is now known as stenno 11:46:43 -!- stenno has quit [Changing host] 11:47:03 -!- valrus has joined ##crawl-dev 11:47:56 -!- stenno has quit [Remote host closed the connection] 11:47:56 -!- stenno__ has quit [Remote host closed the connection] 11:49:06 -!- Vizer has quit [Quit: bye] 11:57:06 -!- Kalir has quit [Quit: CADENZA-CLASS CLOCKWORK KNIGHT--OPERATION TERMINATED] 12:02:15 -!- shirish has quit [Remote host closed the connection] 12:06:42 -!- BorekL is now known as Mandevil 12:07:46 -!- Cheibriados has joined ##crawl-dev 12:07:46 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chit-chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to pastebin.ca please | Immortal Warwalrus and Crazy Yiuf forever. 12:07:46 -!- The topic of ##crawl is: CAO is back, in time for tournament play! | Play Crawl online now: type ??cao, ??cdo, ??cszo, or ??webtiles for instructions | http://crawl.develz.org | FooTV: termcast.develz.org | ##crawl-offtopic: You got your gender in my peanut butter! Xom thinks this is hilarious! 12:09:20 -!- Cheibriados has joined ##crawl-dev 12:09:20 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chit-chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to pastebin.ca please | Immortal Warwalrus and Crazy Yiuf forever. 12:09:20 -!- The topic of ##crawl is: CAO is back, in time for tournament play! | Play Crawl online now: type ??cao, ??cdo, ??cszo, or ??webtiles for instructions | http://crawl.develz.org | FooTV: termcast.develz.org | ##crawl-offtopic: You got your gender in my peanut butter! Xom thinks this is hilarious! 12:10:04 -!- jacobian has quit [Read error: Operation timed out] 12:14:32 -!- Cheibriados has joined ##crawl-dev 12:14:32 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chit-chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to pastebin.ca please | Immortal Warwalrus and Crazy Yiuf forever. 12:14:33 -!- The topic of ##crawl is: CAO is back, in time for tournament play! | Play Crawl online now: type ??cao, ??cdo, ??cszo, or ??webtiles for instructions | http://crawl.develz.org | FooTV: termcast.develz.org | ##crawl-offtopic: You got your gender in my peanut butter! Xom thinks this is hilarious! 12:16:37 -!- Cheibriados has joined ##crawl-dev 12:16:37 -!- The topic of ##crawl-dev is: Crawl Development | Logs: http://s-z.org/crawl-dev/ | People with +v have commit access. | Please keep general Crawl-related chit-chat to ##crawl. | Dev wiki: http://crawl.develz.org/wiki | Long stuff to pastebin.ca please | Immortal Warwalrus and Crazy Yiuf forever. 12:16:37 -!- The topic of ##crawl is: CAO is back, in time for tournament play! | Play Crawl online now: type ??cao, ??cdo, ??cszo, or ??webtiles for instructions | http://crawl.develz.org | FooTV: termcast.develz.org | ##crawl-offtopic: You got your gender in my peanut butter! Xom thinks this is hilarious! 12:17:44 -!- Rofaner has quit [Quit: Leaving] 12:18:43 -!- st_ has joined ##crawl-dev 12:19:11 MarvinPA: only actual vaults show in wizmode, Vaults vaults are merged into the layout via lua instead of using regular vault code 12:19:58 aha, i assumed it must be something to do with how vaults places things, yeah 12:20:54 -!- Pthing has quit [Ping timeout: 240 seconds] 12:20:59 kilobyte: lava orcs? :( 12:22:49 too cold for them 12:23:03 the weather at my place didn't get the news about global warming 12:24:15 -!- joosa has joined ##crawl-dev 12:26:45 03MarvinPA 07* 0.12-a0-1266-g0686492: Fix some item descriptions 10(24 minutes ago, 1 file, 10+ 19-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=06864923c1cc 12:26:45 03MarvinPA 07* 0.12-a0-1267-ge65f7ee: Remove a Vaults vault 10(9 minutes ago, 1 file, 0+ 28-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=e65f7eed6e98 12:29:18 -!- Jayrays has quit [] 12:32:07 wow. I am a horrendously slow cyclist. 12:32:18 IRC timestamps confirm :) 12:33:08 <|amethyst> since Chei missed some commits because of my restarting it 12:33:09 <|amethyst> %git 973a71b 12:33:09 03kilobyte * 0.12-a0-1265-g973a71b: Remove bh from the list of contributors. 10(36 minutes ago, 1 file, 7+ 8-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=973a71b2202c 12:33:52 |amethyst: that's a cheeky commit message ;) 12:34:05 -!- cybie04 has quit [Ping timeout: 255 seconds] 12:34:23 haha 12:34:27 <|amethyst> I think kilobyte and MarvinPA have been in a competition to see who can have the most misleading commit messages 12:34:37 <|amethyst> IIRC elliptic competes occasionally 12:34:44 <|amethyst> and I have been known to every now and again 12:34:51 i think kilobyte is a pretty clear leader :P 12:35:28 |amethyst: not crawl, but my most misleading commits happen when patching bad security bugs "Minor refactoring, nothing to see here" 12:35:38 <|amethyst> heh 12:36:09 <|amethyst> Or when you're working for the NSA and you make a commit called "Fix some valgrind warnings" 12:36:18 -!- rossi has quit [Quit: WeeChat 0.3.9.2] 12:36:39 i clearly should have titled my orb mimic commit "Add some tests." 12:36:39 or when you're Debian 12:36:51 <|amethyst> elliott: that was what I was referring to :P 12:36:54 |amethyst: "Implement some creative ideas from Ken Thompson" and slip Reflections on Trusting Trust into clang 12:37:06 |amethyst: I am just here to ruin the jokes 12:37:08 elliott: bad-keys? 12:37:30 the openssl fiasco 12:37:39 <|amethyst> they keys weren't *bad* 12:37:41 if and when we get inception merged, the commit should be something like "Go deeper" 12:37:45 <|amethyst> there just weren't enough of them :/ 12:38:08 bh: too bad, at least in Debian clang is compiled using gcc 12:38:31 clang isn't self-hosting? 12:38:52 <|amethyst> presumably it's not mandatorily self-hosting 12:39:35 clang can compile itself, yeah, but 1. gcc is the default compiler, and 2. quite a few people push hard for eliminating as many build-dependency loops as possible 12:42:16 -!- y2s82 has quit [Remote host closed the connection] 12:43:57 -!- Senjai has quit [Changing host] 12:43:57 -!- Senjai has quit [Changing host] 12:44:09 kilobyte: anything I need to do on my end? is there a secret handshake I should learn? 12:44:49 git remote add gs git@gitorious.org:crawl/crawl.git 12:45:09 (you probably already have it as "origin" but in read-only mode) 12:46:14 <|amethyst> you're an admin on CAO now (and already were on CSZO) 12:46:39 <|amethyst> dgl admin, which really means just save backup access, rebuilder, and wizmode 12:46:41 sweet. Now I can cheat at robot finds kitten 12:47:31 if only :( 12:47:44 even devs don't have that power 12:47:46 kilobyte: I'm going to nuke that tornado experiment branch. While I find it neat that walls screw with the winds and hitting stuff around the corner is fun, I don't think it's anything anyone would ever want 12:48:21 -!- Vizerr has quit [Ping timeout: 276 seconds] 12:49:29 I'm pondering adding a check if you can walk from place A to B and leaving it at that 12:49:59 MarvinPA: actually, I remember that the item_desc for "helm" is used for _something_, I just can't remember what 12:50:35 oh hmm, i assumed it was a mistake and couldn't find anything referring to it... i didn't look very carefully though 12:50:37 MarvinPA: db_lint is a tool to find such descs, and I researched everything that should not be. 12:50:54 for player ghosts do we have access to cause of death at creation time? 12:50:56 I can't seem to find any uses today :( 12:51:37 huh, weird 12:53:05 -!- jeanjacques has joined ##crawl-dev 12:53:52 actually, grepping for "helm" shows no occurences that are not false positives 12:53:54 <|amethyst> kilobyte: talking about replacing Grunt's check so that grates aren't airtight any more? 12:54:11 so either something changed or I was on crack when messing with db_lint 12:55:25 |amethyst: Grun't check was requiring a straight line without obstacles, which broke assumptions causing crashes. I replaced it with a quick hack for grates only. 12:55:44 -!- broquaint has quit [Quit: Lost terminal] 12:56:43 <|amethyst> kilobyte: right, you mentioned a check if you can walk from place A to B? 12:58:31 -!- broquaint has joined ##crawl-dev 12:59:07 fly to be exact; yeah 12:59:20 -!- Sequell has quit [Quit: Sequell] 12:59:23 it's not perfect as it doesn't handle an U-shaped room well 12:59:35 <|amethyst> kilobyte: what if you call tornado_damage once per N aut, instead of once per player turn? 12:59:56 <|amethyst> I guess things can still get moved more than one space then... :( 13:00:03 <|amethyst> s/get/be/ 13:00:50 there's be terrible randomness 13:00:58 -!- Sequell has joined ##crawl-dev 13:01:04 <|amethyst> hm, yeah 13:01:18 also, that U-shaped room would end up with everyone piled up on one side 13:01:49 <|amethyst> I don't think we can handle a U-shaped room reasonably in a way that doesn't confuse the player 13:01:52 <|amethyst> well 13:02:17 <|amethyst> you could make the tornado temporarily cut out at radius >= N if there is a solid feature at distance N 13:02:23 03kilobyte 07* 0.12-a0-1268-g50fbf73: Remove db_lint's special case for "helm". 10(6 minutes ago, 1 file, 0+ 1-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=50fbf7352a13 13:02:23 03kilobyte 07* 0.12-a0-1269-g8542156: Purge translations for "helm". 10(4 minutes ago, 8 files, 0+ 32-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=854215607e92 13:02:32 <|amethyst> that would be easy to understand, but probably too much of a nerf 13:03:51 -!- nooodl_ has quit [Read error: Connection reset by peer] 13:04:17 -!- nooodl_ has joined ##crawl-dev 13:04:50 -!- johnthebear has quit [Quit: Computer has gone to sleep.] 13:07:38 since we already know the region is bi-connected, there is a guarantee there exists a flow 13:08:50 <|amethyst> but it seems like the flow would have to be a bijection 13:09:05 <|amethyst> or at least injective 13:09:26 <|amethyst> so that you don't get collisions when advancing monsters 13:12:10 <|amethyst> but I guess if you have many monsters and a tight passage you can just "squirt" them through by advancing multiple spaces 13:12:37 yeah, which will happen in the case two branches of a flow merge 13:13:54 <|amethyst> what do you mean exactly by "flow"? An edge-weighted directed graph? 13:13:54 -!- valrus has quit [Read error: Connection reset by peer] 13:16:19 -!- kwel01 has quit [Quit: Page closed] 13:17:29 sorry for using that word, forgot it matches an actual term in English 13:21:06 kilobyte: does my mantis account need to be upgraded? "Access Level: Updater" "Project Access Level: Developer" 13:22:23 hrm, I can't seem to find why after a commit that shouldn't be related, suddenly the builder stops finding any layout vaults (but still managed to find regular ones) 13:22:46 New branch created: wip-0.11-compat (1 commit) 13:22:46 03kilobyte 07[wip-0.11-compat] * 0.12-a0-1268-g9bc1e9b: Restore save compatibility with 0.11 final. 10(21 minutes ago, 9 files, 234+ 21-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=9bc1e9bbaad0 13:23:28 -!- DracoOmega has joined ##crawl-dev 13:23:51 bh: it says "Access level: developer" for you, although it's possible I'm missing something 13:24:11 -!- Kromgart has quit [Quit: Leaving] 13:24:48 if something doesn't work I'll let you know 13:27:16 I realize I poked about this only the other day, but since I got no real response, I will attempt to pester someone again: what, if any, are the outstanding issues with the tentacle patch and how might I be able to help address them, if there is any? :) 13:29:06 would there be any interest in using something like rietveld? http://code.google.com/p/rietveld/ 13:29:48 cause another tool would make everything even more awesome ;) 13:31:38 DracoOmega: mostly serious lack of time on our part; that set of patches is pretty large so they need quite a load of reviewing 13:31:57 [brb] 13:32:18 kilobyte: Well, like I said, if there is anything I can do to make that more expedient.... 13:32:28 DracoOmega: can you link me to the bug? 13:32:39 What bug? 13:32:50 the mantis bug corresponding to your patch 13:33:00 i compiled it locally and didn't see any obvious problems but the tentacle code is all a bit over my head so i wouldn't feel confident pushing it, unfortunately :P 13:33:04 bh: it's in the tentacallis branch 13:33:17 bh: And the branch has another minor change or two on top of it 13:33:17 MarvinPA: k 13:33:36 MarvinPA: So, is this the downside of taking the trouble to fix code that no one understands? :) 13:33:43 it seems so :P 13:34:14 I would say "Trust me!", but I know well enough never to assume our own work is infalible :P 13:35:44 -!- Vizerr has quit [Ping timeout: 244 seconds] 13:35:51 DracoOmega: a@a.com that's a splendid e-mail address. I bet you get a lot of spam ;) 13:37:55 Haha 13:38:56 DracoOmega: does the whole thing need to be looked at, or just everything after some commit? 13:40:50 I'm not sure exactly what you mean. At least, nothing much substantive has changed since the branch was made 13:40:59 Just a minor edit or two 13:41:17 -!- HDA has quit [Ping timeout: 245 seconds] 13:42:12 I'll try to make some time for this tonight (Pacific time) 13:43:05 That would be nice :) 13:43:08 03MarvinPA 07* 0.12-a0-1270-gd42e671: Fix a reference to amulets of controlled flight 10(8 minutes ago, 1 file, 1+ 1-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=d42e671c7322 13:43:08 03MarvinPA 07* 0.12-a0-1271-g9efa46c: Spacing fix 10(8 minutes ago, 1 file, 1+ 1-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=9efa46c62655 13:43:23 I have a bunch more stuff I probably WOULD have coded, but had been sort of waiting on the last stuff to get moving forward before doing so 13:45:49 MarvinPA: would there be any interest in using a code review tool? If we did it right I think it could really expedite getting contributions in and clean 13:47:03 hm, i don't really know anything about such tools 13:48:40 as far as getting patches in goes, i think the main blocker is usually just in finding people who understand the relevant code and also have spare time to look at the patch :P 13:48:58 Does ANYONE understand the relevant code? 13:49:16 I thought that was the reason no one else wanted to try tidying it up in the first place ^^; 13:49:27 DracoOmega for president of tentacles 13:49:33 I will accept that position! 13:49:35 first job is to give mnoleg tentacles 13:49:38 Haha 13:49:46 Honestly, that would not be that difficult, post-patch 13:50:15 i was considering trying it for fun after looking at the patch actually, yeah :P 13:50:18 MarvinPA: gerrit is based on reitveld which is in turn based on mondrian, Google's code review tool. It takes git commits, shows an inline diff and a reviewer can add comments line by line 13:50:24 ??mnoleg 13:50:24 mnoleg[1/2]: Guardian of the Glowing Rune. Comes with hordes of neqoxecs. If you die to him in hive, you get a prize! 13:50:46 if gerrit is what I think it is it is an awful mess to use 13:50:59 at least if I remember it correctly 13:51:25 elliott: here's chromium's gerrit http://gerrit.chromium.org/ 13:52:36 that looks like the thing I remember being kind of awful, yaeh 13:52:44 maybe it is better now 13:53:45 I'm a fan of code review because it makes it easy to say "This part is *awesome* and this part needs these minor changes" 13:55:58 i feel like for crawl it's usually pretty easy to make minor changes just with mantis comments or whatever, although admittedly that's not so true for rewrites like the abyss, or big new features or whatever 13:59:07 and sanitizing tentacle code is one of such big rewrites 13:59:15 (much needed, too) 14:00:35 -!- LoremIpsum has quit [Remote host closed the connection] 14:00:35 -!- fernandotakai has quit [Remote host closed the connection] 14:00:54 -!- LoremIpsum_ is now known as LoremIpsum 14:00:56 -!- fernandotakai_ is now known as fernandotakai 14:01:11 -!- medgno1 has quit [Read error: Connection reset by peer] 14:01:12 -!- Mandevil has quit [Read error: No buffer space available] 14:02:46 Clearly the solution is to make me a dev so that *I* can review my own code and give it the stamp of approval. Problem solved! :P 14:03:40 -!- absolutego has quit [Quit: leaving] 14:04:14 -!- Nightbeer has quit [Ping timeout: 240 seconds] 14:04:22 so basically the github features people were stating to "never use" in here 14:04:23 :P 14:08:10 -!- psch has joined ##crawl-dev 14:08:44 im curious about issue 0006376 14:08:55 it happened twice to me on tCSZO today 14:09:08 but i can't reproduce it on a local build that pulled after the first crash 14:10:10 <|amethyst> there was a similar (or the same?) bug fixed some time ago 14:10:34 <|amethyst> ah, you have to get a --More-- 14:11:45 local tiles gives me the level-up message, --More--, and then the color 14:12:02 tCSZO drops me straight to menu so to speak 14:12:07 <|amethyst> the crash was webtiles? 14:12:10 yes 14:12:22 <|amethyst> entirely different code paths, so it's not surprising 14:12:38 i see 14:12:45 <|amethyst> but, yeah, any redraw while levelling up before skills are fixed up will crash 14:12:55 <|amethyst> in webtiles at least 14:13:28 so they way to avoid the crashes is not playing anything draconian that trains skills where the apts might change? 14:13:51 <|amethyst> where they might decrease 14:14:01 oh, yes 14:14:03 <|amethyst> or save just before levelling and scum :P 14:14:14 that's possible on webtiles? 14:14:29 <|amethyst> I mean, save when you're at L6 and 90% 14:14:36 oh right 14:14:41 so reduce the time to reroll 14:14:42 <|amethyst> then if you do crash when levelling, you can try again 14:16:16 makes sense to reduce the time 14:17:17 the mantis issue for the crash where i added a note was local tiles i think 14:17:24 should i open a new one for webtiles explicitly? 14:17:38 <|amethyst> I adjusted the bug 14:18:00 okay, thanks 14:18:04 <|amethyst> so now it's Local or Remote: Both and indicates it's in 0.12 14:18:58 i think local is fixed 14:19:04 at least i couldnt reproduce 14:19:10 and you said it was fixed somewhen back 14:19:21 <|amethyst> the conditions to trigger it are probably different 14:19:25 <|amethyst> and, yes, it might be fixed 14:19:30 oh 14:19:40 yeah i obviously don't know the code 14:19:43 just trying to help 14:19:58 anyway, that's all 14:20:02 <|amethyst> I fixed a similar bug some time ago, trying to find that 14:20:09 -!- WalkerBoh has quit [Quit: Page closed] 14:20:31 <|amethyst> %git 1e862324 14:20:31 03|amethyst * 0.10-a0-3013-g1e86232: Don't crash when draconians gain XL 7 and lose skill levels. 10(12 months ago, 1 file, 2+ 1-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=1e8623247bbf 14:21:00 <|amethyst> that one was an explicit redraw 14:21:11 i see 14:21:52 for my curiousity, webtiles branch is origin/webtiles-unicode? 14:22:08 <|amethyst> edlothiol: any thoughts on the webtiles part of https://crawl.develz.org/mantis/view.php?id=6376 ? There's an mpr while drac skills are still unfixed-up, and at least on webtiles if there's a More that can trigger a redraw and hence crash 14:23:00 -!- Solvent has quit [Remote host closed the connection] 14:25:39 <|amethyst> psch: I have an idea 14:25:49 <|amethyst> do you have a crashing save? 14:25:57 yeah 14:26:04 or rather 14:26:05 <|amethyst> webtiles doesn't have a branch, btw 14:26:08 oh 14:26:10 <|amethyst> it's just a compile flag 14:26:13 i have the save that would crash 14:26:16 if it rolls the same colour 14:26:24 i didnt continue since the crash 14:27:04 <|amethyst> can you upload that to the mantis issue? 14:27:09 from webtiles? 14:27:13 <|amethyst> oh, right 14:27:21 <|amethyst> there's no "save backup" option in webtiles 14:27:23 im not sure how far from XL:7 the char is 14:27:25 <|amethyst> I'll grab a copy 14:27:38 6 27% 14:27:52 <|amethyst> actually 14:27:58 should i play up to 90% something 14:28:00 <|amethyst> it's easy enough for me to reproduce 14:28:04 oh alright 14:28:08 <|amethyst> so don't worry about it 14:28:13 i noticed wizmode doesn't give colour selection 14:28:21 which made trying to reproduce locally a bit tedious 14:29:50 <|amethyst> just set every skill that can drop to 3.0 or so :) 14:30:15 yeah, that's what i ended up trying 14:30:16 <|amethyst> hrm 14:30:28 but it didn't crash 14:30:39 <|amethyst> have you had it crash more than once on cszo? 14:30:42 yeah 14:30:45 <|amethyst> hm 14:31:00 http://dobrazupa.org/morgue/psch/crash-psch-20121208-123754.txt is the one in the issue 14:31:07 <|amethyst> because I can't figure out how it's getting into that codepath without a spectator joining during that --More-- 14:31:10 http://dobrazupa.org/morgue/psch/crash-psch-20121208-195150.txt was a bit ago 14:31:22 i didn't have any spectators afair 14:31:55 <|amethyst> oh wait 14:32:12 <|amethyst> update_input_mode is also called from a header file, missed that one 14:32:26 hmm 14:33:31 why exactly does it crash? 14:34:04 <|amethyst> edlothiol: When a draconian gets its scale colour, that changes skill apts, meaning some can be at say 120% 14:34:15 I know why the redraw is called, but I'd prefer to keep it that way and make the redraw not crash 14:34:35 <|amethyst> edlothiol: it does things that might print messages and hence cause a redraw before fixing up the skills 14:35:09 the two crashes i had both involved a skill trained getting worse apt and a untrained getting better apt, in case that matters 14:35:28 <|amethyst> it doesn't help to move the fixup loop earlier, because the fixup process itself can produce messages 14:36:24 <|amethyst> well, it would "help" as in make the crash less likely, but not fix it 14:37:20 -!- elliptic has quit [Quit: ChatZilla 0.9.89 [Firefox 17.0.1/20121128204232]] 14:37:26 <|amethyst> edlothiol: looking at player.cc:3211 (which changes the apts) to 3222 (the fixup) 14:38:28 <|amethyst> the assertion about in-bounds skills could be removed, of course, but I'd rather not do that 14:38:56 -!- elliptic has joined ##crawl-dev 14:39:25 I think the ideal solution would be delaying the messages or at least the more until the game is in a consistent state again, but that might get quite complicated 14:40:52 <|amethyst> yeah, if _change_level didn't print or could be made to queue its output, we could move the loop a little earlier and fix the crash 14:40:54 another way would be detecting the inconsistent state and avoiding the player_title call 14:41:14 though that would mostly just paper over the problem 14:53:44 -!- scummos has quit [Quit: Konversation terminated!] 14:53:54 -!- jeanjacques has quit [Quit: HydraIRC -> http://www.hydrairc.com <- Go on, try it!] 15:05:11 <|amethyst> we could pass false to check_skill_level_change... but then there would be no messages 15:06:14 <|amethyst> (and no notes, etc) 15:07:25 is anyone else excited about the proposition of using a code review tool? :) 15:08:34 <|amethyst> I thought only managers got excited about such things 15:08:53 |amethyst: does that mean there's greatness in my future? 15:08:59 <|amethyst> :) 15:13:15 <|amethyst> edlothiol: you could save the skill array, do the fixup with do_level_up = false so there are no messages etc, then skill-by-skill restore an array element and call check_skill_level_change() again with do_level_up = true 15:16:05 -!- Calisca has quit [Ping timeout: 255 seconds] 15:17:44 -!- dtsund has joined ##crawl-dev 15:18:36 or extract the messaging into its own function and call that 15:22:19 -!- Demon__ has quit [Client Quit] 15:23:23 -!- Chozo has quit [Read error: Connection reset by peer] 15:23:32 -!- yon2 has quit [Ping timeout: 248 seconds] 15:25:55 |amethyst: did you get a crashing savegame? 15:26:02 <|amethyst> well, the messaging needs the old and new levels anyway 15:26:11 <|amethyst> edlothiol: no, but psch has one 15:26:26 <|amethyst> except it's saved at L6 and 26% 15:26:38 <|amethyst> so you still have to arrange that the level-up gives you a --More-- 15:26:48 <|amethyst> let me try 15:26:51 and hope for a crashing color 15:28:14 does adding a force_more for the message work? 15:28:41 (with the right force_mores, that might be an easy way to savescum for a specific colour...) 15:33:39 <|amethyst> yup, got a crash 15:33:49 <|amethyst> not even reported, odd 15:33:58 <|amethyst> !lm neil 15:34:02 7022. [2012-12-08 16:45:44] neil the Gusty (L4 DrAE) killed the ghost of zazu2006 the Magician, an average HEWz of Okawaru on turn 2031. (D:3) 15:34:24 maybe because of wizmode? 15:34:33 <|amethyst> oh, yeah 15:34:43 <|amethyst> I was thinking wizmode crashes were reported but I guess not 15:35:24 <|amethyst> http://dobrazupa.org/morgue/neil/crash-neil-20121208-213330.txt 15:39:51 <|amethyst> http://dobrazupa.org/saves/neil-crawl-git-70e25bb2b1-121208-2136.tar.bz2 15:40:48 <|amethyst> only crashes when there is a webtiles watcher 15:40:54 <|amethyst> but doesn't matter who's controlling it 15:40:56 <|amethyst> as expected 15:41:32 <|amethyst> I added force_more_messages for all the skill increase/decrease/gained/lost messages 15:42:09 force_more_message = . 15:42:15 <|amethyst> that works too :) 15:42:43 safety assured, you'll never miss a message 15:46:48 hrm 15:46:56 the scale colour message is also a problem 15:47:01 if you have a force_more 15:47:17 <|amethyst> my fix handles that I think 15:47:29 oh, I might not be up to date 15:47:30 <|amethyst> I need to test on local webtiles 15:47:40 <|amethyst> I mean the one I haven't pushed yet 15:48:01 ah 15:48:47 how does it handle it? 15:49:21 <|amethyst> first do the loop with do_level_up = false but save the old skill levels 15:49:36 <|amethyst> immediately after changing the player's species 15:49:49 ah 15:49:54 -!- Dedagen has quit [Ping timeout: 240 seconds] 15:50:00 <|amethyst> then, in the current spot, restore each level from the saved copy and call it again with do_level_up = true 15:50:30 <|amethyst> one-at-a-time so at most the level being updated is wrong 15:50:40 <|amethyst> and _change_skill_level makes the change before printing any messages 15:55:49 <|amethyst> unfortunately I'm not going to have time to test it right now, so I'll upload tonight. I've assigned the bug to myself 15:57:24 -!- BlackSheep_ has joined ##crawl-dev 15:58:30 ok 16:04:45 -!- HangedMan has joined ##crawl-dev 16:08:10 -!- astralTentacle has quit [Quit: Page closed] 16:08:27 -!- ark____ has joined ##crawl-dev 16:10:59 03|amethyst 07* 0.12-a0-1272-g27ada97: Avoid a draconian scale acquisition crash (#6376). 10(18 minutes ago, 1 file, 25+ 2-) 13http://git.develz.org/?p=crawl.git;a=commitdiff;h=27ada97c038e 16:11:21 <|amethyst> Haven't actually tested whether that fixes it yet, but it at least doesn't break 16:11:32 <|amethyst> don't have local webtiles set up 16:15:06 Unstable branch on crawl.s-z.org updated to: 0.12-a0-1272-g27ada97 (34) 16:15:48 -!- stanzill has quit [Quit: sofakartoffel] 16:15:55 <|amethyst> okay, that does fix it 16:16:37 -!- HellTiger has quit [Read error: Connection reset by peer] 16:16:40 Stable (0.11) branch on crawl.s-z.org updated to: 0.11.1-15-gb341d8e 16:16:53 !seen MrBones18 16:16:53 Sorry Napkin, I haven't seen MrBones18. 16:16:53 Sorry Napkin, I haven't seen MrBones18. 16:16:58 !seen MrBones118 16:16:58 Sorry Napkin, I haven't seen MrBones118. 16:16:58 Sorry Napkin, I haven't seen MrBones118. 16:17:22 * kilobyte meows at Napkin. 16:17:32 -!- Senjai has quit [Ping timeout: 245 seconds] 16:17:42 550 5.1.1 : Recipient address rejected: 16:17:44 User unknown in virtual alias table 16:17:45 grrr 16:17:51 hi kilobyte :) 16:17:55 <|amethyst> !tell MrBones118 I'm marking 6376 as done; I fixed the webtiles crash and can't reproduce in local tiles 16:17:55 |amethyst: OK, I'll let MrBones118 know. 16:18:30 <|amethyst> !tell MrBones118 re-open if it happens again in 0.11.1-15 or later, or in trunk 0.12-a0-1272 or later 16:18:30 |amethyst: OK, I'll let MrBones118 know. 16:19:11 <|amethyst> all right, I'm out for the evening 16:21:11 Cherry-picked 1 commit into stone_soup-0.11 16:21:15 -!- kek has quit [Quit: ""] 16:22:29 -!- bh has quit [Quit: Page closed] 16:36:53 thanks for fixing the bug 16:37:03 or crash rather 16:37:22 that i got black again is just crawl being crawl heh 16:42:57 -!- BlackSheep_ has quit [Quit: Leaving] 17:02:46 -!- Ystah has quit [] 17:06:39 -!- Senjai has quit [Changing host] 17:06:46 -!- Blazinghand_ has quit [Ping timeout: 250 seconds] 17:09:32 -!- TacoSundae has quit [Quit: Leaving.] 17:12:08 -!- vogonpoet has quit [Quit: Page closed] 17:12:18 -!- mrwooster_ has joined ##crawl-dev 17:21:11 -!- TacoSundae has quit [Quit: Leaving.] 17:24:36 -!- Writ has quit [Ping timeout: 276 seconds] 17:26:41 -!- Blazinghand_ has quit [Ping timeout: 244 seconds] 17:27:05 -!- Ragdoll has quit [Quit: Ik ben weg] 17:31:54 -!- edlothiol has quit [Ping timeout: 240 seconds] 17:40:53 -!- psch has left ##crawl-dev 17:43:13 -!- Namey has quit [Quit: Leaving] 17:47:25 -!- Lomky has quit [Quit: Page closed] 17:51:54 -!- Writ has quit [Ping timeout: 276 seconds] 17:52:04 -!- monqy has joined ##crawl-dev 17:59:52 -!- Solvent has quit [Quit: Leaving] 18:07:56 -!- alefury has quit [] 18:08:17 -!- Kalir has quit [Changing host] 18:13:20 -!- getdunked has quit [Client Quit] 18:22:22 -!- Kromgart has quit [Quit: Leaving] 18:32:24 -!- syllogism has quit [] 18:33:54 -!- TacoSundae has quit [Quit: Leaving.] 18:35:08 * kilobyte ponders the DNS domain xn--co-gia being unregistered. 18:37:02 -!- Zifmia has quit [Read error: Connection reset by peer] 18:38:30 -!- wheals has quit [Ping timeout: 264 seconds] 18:38:46 -!- wheals_ is now known as wheals 18:46:47 -!- kek has joined ##crawl-dev 18:52:32 -!- domiryuu has quit [Ping timeout: 255 seconds] 18:58:38 -!- Aryth has quit [Quit: KVIrc 4.0.4 Insomnia http://www.kvirc.net/] 19:00:03 -!- mamga has quit [Ping timeout: 245 seconds] 19:01:10 -!- _dd has quit [Ping timeout: 250 seconds] 19:08:36 -!- maha has quit [Client Quit] 19:13:58 -!- wheals has quit [Read error: Connection reset by peer] 19:14:40 -!- Soadreqm has quit [*.net *.split] 19:14:40 -!- remyroy has quit [*.net *.split] 19:14:40 -!- tensorpudding has quit [*.net *.split] 19:14:40 -!- Grunt has quit [*.net *.split] 19:14:40 -!- SwissStopwatch has quit [*.net *.split] 19:14:40 -!- blackflare has quit [*.net *.split] 19:15:15 -!- Mandevil has quit [Read error: No buffer space available] 19:15:17 -!- nooodl_ has quit [Read error: Connection reset by peer] 19:15:20 -!- Nightbeer has quit [Read error: Connection reset by peer] 19:15:42 -!- nooodl_ has joined ##crawl-dev 19:16:55 -!- Grunt has joined ##crawl-dev 19:18:56 -!- Calisca has quit [Ping timeout: 250 seconds] 19:20:04 -!- Kalir has quit [Quit: CADENZA-CLASS CLOCKWORK KNIGHT--OPERATION TERMINATED] 19:30:50 -!- Daekdroom has quit [Quit: Saindo] 19:37:51 -!- scummos has quit [Ping timeout: 260 seconds] 19:43:58 -!- Nightbeer has quit [Read error: Connection reset by peer] 19:53:34 -!- Crazylemon64 has quit [Ping timeout: 240 seconds] 20:01:14 -!- Pthing has quit [Ping timeout: 240 seconds] 20:13:19 -!- Zifmia has quit [Ping timeout: 264 seconds] 20:18:49 -!- WalkerBoh has quit [Quit: Page closed] 20:26:34 -!- scummos^ has quit [Ping timeout: 240 seconds] 20:31:14 -!- Pthingg has quit [Ping timeout: 240 seconds] 20:42:20 -!- yon2 has quit [Quit: Leaving.] 20:47:09 -!- Sab0t has quit [Ping timeout: 244 seconds] 21:05:35 -!- kek has quit [Quit: gonna suicide, brb] 21:12:57 -!- Kellhus has quit [Ping timeout: 245 seconds] 21:15:08 -!- dtsund has quit [Ping timeout: 245 seconds] 21:18:33 -!- Pthing has quit [Remote host closed the connection] 21:18:39 -!- bmfx has quit [Ping timeout: 260 seconds] 21:20:30 -!- nooodl_ has quit [Ping timeout: 264 seconds] 21:33:44 -!- Daekdroom has quit [Quit: Saindo] 21:34:52 -!- Vizerr has quit [Ping timeout: 246 seconds] 21:40:47 -!- dtsund has joined ##crawl-dev 21:43:47 -!- MarvinPA has quit [Ping timeout: 265 seconds] 21:49:09 -!- MarvinPA has joined ##crawl-dev 21:51:51 -!- rkd has quit [] 21:52:14 -!- Crazylemon64 has quit [Ping timeout: 255 seconds] 21:59:34 -!- ark____ has quit [Quit: Leaving] 22:00:17 -!- HangedMan has quit [Read error: Connection reset by peer] 22:11:15 -!- cybie04 has quit [Ping timeout: 276 seconds] 22:19:03 -!- MaxFrost has quit [Ping timeout: 276 seconds] 22:23:18 -!- cybie04 has quit [Ping timeout: 252 seconds] 22:28:19 -!- minqmay has quit [Quit: Leaving] 22:30:34 -!- Pikkle has quit [Quit: Computer has gone to sleep.] 22:32:17 -!- _dd has joined ##crawl-dev 22:32:48 -!- bonghitz has quit [Quit: bonghitz] 22:35:58 -!- Pikkle has joined ##crawl-dev 22:40:24 -!- Pikkle has quit [Ping timeout: 264 seconds] 22:41:54 -!- Senjai is now known as Senjai|XCOM| 22:43:50 -!- Pikkle has joined ##crawl-dev 22:56:06 -!- cybie04 has quit [Ping timeout: 276 seconds] 23:11:02 -!- Fhqwhgads has quit [Remote host closed the connection] 23:17:41 -!- bmfx_ is now known as bmfx 23:22:32 -!- Datul has quit [Ping timeout: 245 seconds] 23:31:54 -!- Staplefun has quit [Ping timeout: 264 seconds] 23:35:54 -!- rossi has quit [Ping timeout: 240 seconds] 23:37:39 mudo (L27 VpAE) ASSERT(zombie_class_size(cs) == Z_NOZOMBIE || zombie_class_size(cs) == mons_zombie_size(base)) in 'mon-place.cc' at line 2053 failed. (Zig:3) 23:49:56 -!- Kalir has quit [Changing host]